@devries-cameron20 / t3code-1 / commits / 6ae0d3feec
Fork 0

The best way to control Claude Code, Codex and more from any computer or phone

perf(mobile): skip unchanged terminal toolbar fade updates (#25312)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Alex Southwell committed Nov 5, 2026 at 18:30 UTC 6ae0d3feecc02f78e8a41999a051438f75162022
1 file changed +46 -24
apps/mobile/src/components/ComposerToolbar.tsx
+46 -24
@@ -1,5 +1,5 @@
1 import type { ComponentProps, ReactNode } from "react";
2 -import { useState } from "react";
2 +import { useCallback, useRef, useState } from "react";
3 import {
4 Pressable,
5 ScrollView,
@@ -149,37 +149,59 @@ export function ComposerToolbarScroller(props: {
149 readonly fadeSurface?: "card" | "sheet";
150 readonly contentPaddingRight?: number;
151 }) {
152 - const [metrics, setMetrics] = useState({
152 + const metricsRef = useRef({
153 contentWidth: 0,
154 offsetX: 0,
155 viewportWidth: 0,
156 + showLeftFade: false,
157 + showRightFade: false,
158 + });
159 + const [scrollEdges, setScrollEdges] = useState({
160 + showLeftFade: false,
161 + showRightFade: false,
162 });
163
158 - const maxOffset = Math.max(0, metrics.contentWidth - metrics.viewportWidth);
159 - const scrollEdges = {
160 - showLeftFade: metrics.offsetX > COMPOSER_TOOLBAR_SCROLL_EPSILON,
161 - showRightFade: metrics.offsetX < maxOffset - COMPOSER_TOOLBAR_SCROLL_EPSILON,
162 - };
164 + const updateScrollEdges = useCallback(() => {
165 + const metrics = metricsRef.current;
166 + const maxOffset = Math.max(0, metrics.contentWidth - metrics.viewportWidth);
167 + const showLeftFade = metrics.offsetX > COMPOSER_TOOLBAR_SCROLL_EPSILON;
168 + const showRightFade = metrics.offsetX < maxOffset - COMPOSER_TOOLBAR_SCROLL_EPSILON;
169 + if (metrics.showLeftFade === showLeftFade && metrics.showRightFade === showRightFade) {
170 + return;
171 + }
172 + metrics.showLeftFade = showLeftFade;
173 + metrics.showRightFade = showRightFade;
174 + setScrollEdges({ showLeftFade, showRightFade });
175 + }, []);
176
164 - const handleLayout = (event: LayoutChangeEvent) => {
165 - const viewportWidth = event.nativeEvent.layout.width;
166 - setMetrics((current) =>
167 - current.viewportWidth === viewportWidth ? current : { ...current, viewportWidth },
168 - );
169 - };
177 + const handleLayout = useCallback(
178 + (event: LayoutChangeEvent) => {
179 + const viewportWidth = event.nativeEvent.layout.width;
180 + if (metricsRef.current.viewportWidth === viewportWidth) return;
181 + metricsRef.current.viewportWidth = viewportWidth;
182 + updateScrollEdges();
183 + },
184 + [updateScrollEdges],
185 + );
186
171 - const handleContentSizeChange = (contentWidth: number) => {
172 - setMetrics((current) =>
173 - current.contentWidth === contentWidth ? current : { ...current, contentWidth },
174 - );
175 - };
187 + const handleContentSizeChange = useCallback(
188 + (contentWidth: number) => {
189 + if (metricsRef.current.contentWidth === contentWidth) return;
190 + metricsRef.current.contentWidth = contentWidth;
191 + updateScrollEdges();
192 + },
193 + [updateScrollEdges],
194 + );
195
177 - const handleScroll = (event: NativeSyntheticEvent<NativeScrollEvent>) => {
178 - const offsetX = event.nativeEvent.contentOffset.x;
179 - setMetrics((current) =>
180 - Math.abs(current.offsetX - offsetX) < 1 ? current : { ...current, offsetX },
181 - );
182 - };
196 + const handleScroll = useCallback(
197 + (event: NativeSyntheticEvent<NativeScrollEvent>) => {
198 + const offsetX = event.nativeEvent.contentOffset.x;
199 + if (Math.abs(metricsRef.current.offsetX - offsetX) < 1) return;
200 + metricsRef.current.offsetX = offsetX;
201 + updateScrollEdges();
202 + },
203 + [updateScrollEdges],
204 + );
205
206 return (
207 <View className="relative min-w-0 flex-1">