@devries-cameron20 / t3code-1 / commits / 6e72f540f6
Fork 0

The best way to control Claude Code, Codex and more from any computer or phone

fix(prs): classify generated files and evals correctly (#26563)

Jake Leventhal committed Oct 30, 2026 at 17:20 UTC 6e72f540f6327451e908d042231186566f227a49
2 files changed +6 -2
packages/shared/src/changedFileKind.test.ts
+3
@@ -7,6 +7,9 @@ describe("classifyChangedFile", () => {
7 ["src/contest.py", "code"],
8 ["test/fixtures/pr.json", "mocks"],
9 ["pnpm-lock.yaml", "generated"],
10 + ["convex/_generated/api.d.ts", "generated"],
11 + ["src/agent.eval.ts", "tests"],
12 + ["evals/title-generation.ts", "tests"],
13 ["README.md", "docs"],
14 ["tests/README.md", "tests"],
15 ] as const)("%s is %s", (path, kind) => {
packages/shared/src/changedFileKind.ts
+3 -2
@@ -26,7 +26,7 @@ const GENERATED_FILES = new Set([
26 ]);
27 const GENERATED_NAME =
28 /(\.generated\.|\.gen\.|\.g\.dart$|\.pb\.go$|_pb2(_grpc)?\.py$|\.pb\.(cc|h)$|\.min\.(js|css)$|\.(js|css)\.map$)/;
29 -const GENERATED_DIRS = new Set(["__generated__", "generated"]);
29 +const GENERATED_DIRS = new Set(["__generated__", "_generated", "generated"]);
30
31 const MOCK_NAME =
32 /(\.snap$|\.(mocks?|fixtures?|stubs?|fakes?)\.[^.]+$|^(mocks?|fixtures?|stubs?|fakes?)([-_.A-Z]|$))/;
@@ -44,7 +44,7 @@ const MOCK_DIRS = new Set([
44 ]);
45
46 const TEST_NAME =
47 - /(\.(test|spec|e2e)\.[^.]+$|_(test|spec)\.[^.]+$|^test_.+\.py$|^conftest\.py$|^(vitest|jest)\.setup\.[^.]+$)/i;
47 + /(\.(test|spec|e2e|eval)\.[^.]+$|_(test|spec)\.[^.]+$|^test_.+\.py$|^conftest\.py$|^(vitest|jest)\.setup\.[^.]+$)/i;
48 // Case-sensitive: `FooTest.java` is a test class, `Latest.java` is not.
49 const CLASS_TEST_NAME = /(Tests?|Spec)\.(java|kt|kts|scala|groovy|cs|php|swift|m)$/;
50 const TEST_DIRS = new Set([
@@ -52,6 +52,7 @@ const TEST_DIRS = new Set([
52 "__test__",
53 "cypress",
54 "e2e",
55 + "evals",
56 "spec",
57 "specs",
58 "test",