The best way to control Claude Code, Codex and more from any computer or phone
fix(server): skip provider CLI update when already on latest (#24763)
Co-authored-by: maria-rcks <maria@kuuro.net>
samkelly880 committed
Oct 31, 2026 at 10:08 UTC
6eaf39754b5c85bb32d53cee3dbcfc90ace36efc
2 files changed
+291
-20
apps/server/src/provider/providerMaintenanceRunner.test.ts
+243
-16
@@ -153,6 +153,9 @@ function layerMockSpawner(
153
154
function makeRegistry(
155
initialProviders: ServerProvider | ReadonlyArray<ServerProvider> = baseProvider,
156
+ options?: {
157
+ readonly installedVersionAfterUpdate?: string;
158
+ },
159
) {
160
return Effect.gen(function* () {
161
const providersRef = yield* Ref.make<ReadonlyArray<ServerProvider>>(
@@ -193,7 +196,18 @@ function makeRegistry(
196
refresh: () => Ref.get(providersRef),
197
refreshInstance: () => Ref.get(providersRef),
198
reloadSecretsAndRefresh: () => Ref.get(providersRef),
196
- refreshAfterUpdate: () => Ref.get(providersRef),
199
+ refreshAfterUpdate: () => {
200
+ const version = options?.installedVersionAfterUpdate;
201
+ if (version === undefined) {
202
+ return Ref.get(providersRef);
203
+ }
204
+ return Ref.updateAndGet(providersRef, (providers) =>
205
+ providers.map((provider) => ({
206
+ ...provider,
207
+ version,
208
+ })),
209
+ );
210
+ },
211
refreshWorkspaceSnapshot: () => Ref.get(providersRef),
212
getProviderMaintenanceCapabilitiesForInstance: (_instanceId, provider) =>
213
Effect.succeed(lifecycleFor(provider)),
@@ -220,6 +234,7 @@ const makeTestRunner = (
234
ranges: [],
235
})),
236
},
237
+ latestVersions: Layer.Layer<ProviderLatestVersions.ProviderLatestVersions> = ProviderLatestVersions.layer,
238
) =>
239
Effect.service(ProviderMaintenanceRunner.ProviderMaintenanceRunner).pipe(
240
Effect.provide(
@@ -233,13 +248,28 @@ const makeTestRunner = (
248
forceRefresh: Effect.succeed(manifest),
249
refreshInBackground: Effect.void,
250
}),
236
- ProviderLatestVersions.layer,
251
+ latestVersions,
252
),
253
),
254
),
255
),
256
);
257
258
+function layerFailingLatestLookupAfterFirst() {
259
+ let lookups = 0;
260
+ return Layer.succeed(ProviderLatestVersions.ProviderLatestVersions, {
261
+ cached: (_key, lookup) =>
262
+ Effect.gen(function* () {
263
+ lookups += 1;
264
+ if (lookups > 1) {
265
+ return yield* Effect.die("latest lookup failed");
266
+ }
267
+ return yield* lookup;
268
+ }),
269
+ invalidate: () => Effect.void,
270
+ });
271
+}
272
+
273
describe("providerMaintenanceRunner", () => {
274
it.effect("runs the allowlisted provider update command and records success", () => {
275
const calls: Array<{ command: string; args: ReadonlyArray<string> }> = [];
@@ -269,7 +299,190 @@ describe("providerMaintenanceRunner", () => {
299
Effect.provide(
300
Layer.mergeAll(
301
layerNonWindowsPlatform,
272
- layerLatestVersionHttpClient("0.0.0"),
302
+ layerLatestVersionHttpClient("1.0.0"),
303
+ layerMockSpawner((command, args) => {
304
+ calls.push({ command, args });
305
+ return { stdout: "updated" };
306
+ }),
307
+ ),
308
+ ),
309
+ );
310
+ });
311
+
312
+ it.effect.each([
313
+ { name: "current", probe: {}, skip: true },
314
+ { name: "failed", probe: { status: "error" }, skip: false },
315
+ { name: "behind", probe: { version: "2.1.309" }, skip: false },
316
+ { name: "unknown", probe: { version: null }, skip: false },
317
+ {
318
+ name: "installed current",
319
+ probe: { version: "2.1.309", installedVersion: "2.1.310" },
320
+ skip: true,
321
+ },
322
+ { name: "installed behind", probe: { installedVersion: "2.1.309" }, skip: false },
323
+ { name: "installed unknown", probe: { installedVersion: null }, skip: false },
324
+ ] as const)("only skips a successful fresh current probe: $name", ({ probe, skip }) => {
325
+ const calls: Array<{ command: string; args: ReadonlyArray<string> }> = [];
326
+ const refreshedInstanceIds: Array<ProviderInstanceId> = [];
327
+ return Effect.gen(function* () {
328
+ const { registry, updateStatesRef, providersRef } = yield* makeRegistry({
329
+ ...baseProvider,
330
+ version: "2.1.309",
331
+ versionAdvisory: {
332
+ status: "behind_latest",
333
+ currentVersion: "2.1.309",
334
+ latestVersion: "2.1.310",
335
+ updateCommand: "claude update",
336
+ canUpdate: true,
337
+ checkedAt: "2026-04-10T00:00:00.000Z",
338
+ message: "Update available.",
339
+ },
340
+ });
341
+ const updater = yield* makeTestRunner({
342
+ ...registry,
343
+ refreshInstance: (instanceId) => {
344
+ refreshedInstanceIds.push(instanceId);
345
+ return Ref.updateAndGet(providersRef, (providers) =>
346
+ providers.map((provider) =>
347
+ provider.instanceId === instanceId
348
+ ? {
349
+ ...provider,
350
+ version: "2.1.310",
351
+ ...probe,
352
+ checkedAt: "2026-04-10T00:00:01.000Z",
353
+ }
354
+ : provider,
355
+ ),
356
+ );
357
+ },
358
+ getProviderMaintenanceCapabilitiesForInstance: () =>
359
+ Effect.succeed(
360
+ makeProviderMaintenanceCapabilities({
361
+ provider: CODEX_DRIVER,
362
+ packageName: "@anthropic-ai/claude-code",
363
+ updateExecutable: "claude",
364
+ updateArgs: ["update"],
365
+ updateLockKey: "claudeAgent-native",
366
+ }),
367
+ ),
368
+ });
369
+
370
+ const result = yield* updater.updateProvider(CODEX_DRIVER);
371
+ assert.deepStrictEqual(refreshedInstanceIds, [CODEX_INSTANCE_ID]);
372
+ assert.deepStrictEqual(calls, skip ? [] : [{ command: "claude", args: ["update"] }]);
373
+ if (!skip) return;
374
+ assert.strictEqual(result.providers[0]?.updateState?.status, "succeeded");
375
+ assert.strictEqual(result.providers[0]?.updateState?.message, "Already up to date.");
376
+ assert.deepStrictEqual(
377
+ (yield* Ref.get(updateStatesRef)).map((state) => [state.status, state.message]),
378
+ [
379
+ ["queued", "Waiting for another provider update to finish."],
380
+ ["running", "Checking for the latest version"],
381
+ ["succeeded", "Already up to date."],
382
+ ],
383
+ );
384
+ }).pipe(
385
+ Effect.provide(
386
+ Layer.mergeAll(
387
+ layerNonWindowsPlatform,
388
+ layerLatestVersionHttpClient("2.1.310"),
389
+ layerMockSpawner((command, args) => {
390
+ calls.push({ command, args });
391
+ return { stdout: "updated" };
392
+ }),
393
+ ),
394
+ ),
395
+ );
396
+ });
397
+
398
+ it.effect("still runs the installer when refreshInstance returns the cached snapshot", () => {
399
+ const calls: Array<{ command: string; args: ReadonlyArray<string> }> = [];
400
+ return Effect.gen(function* () {
401
+ const { registry } = yield* makeRegistry({
402
+ ...baseProvider,
403
+ version: "2.1.310",
404
+ });
405
+ const updater = yield* makeTestRunner({
406
+ ...registry,
407
+ getProviderMaintenanceCapabilitiesForInstance: () =>
408
+ Effect.succeed(
409
+ makeProviderMaintenanceCapabilities({
410
+ provider: CODEX_DRIVER,
411
+ packageName: "@anthropic-ai/claude-code",
412
+ updateExecutable: "claude",
413
+ updateArgs: ["update"],
414
+ updateLockKey: "claudeAgent-native",
415
+ }),
416
+ ),
417
+ });
418
+
419
+ const result = yield* updater.updateProvider(CODEX_DRIVER);
420
+ assert.deepStrictEqual(calls, [{ command: "claude", args: ["update"] }]);
421
+ assert.strictEqual(result.providers[0]?.updateState?.status, "succeeded");
422
+ }).pipe(
423
+ Effect.provide(
424
+ Layer.mergeAll(
425
+ layerNonWindowsPlatform,
426
+ layerLatestVersionHttpClient("2.1.310"),
427
+ layerMockSpawner((command, args) => {
428
+ calls.push({ command, args });
429
+ return { stdout: "updated" };
430
+ }),
431
+ ),
432
+ ),
433
+ );
434
+ });
435
+
436
+ it.effect("still runs the installer when precheck advisory enrichment fails", () => {
437
+ const calls: Array<{ command: string; args: ReadonlyArray<string> }> = [];
438
+ return Effect.gen(function* () {
439
+ const { registry, providersRef } = yield* makeRegistry({
440
+ ...baseProvider,
441
+ version: "2.1.310",
442
+ versionAdvisory: {
443
+ status: "current",
444
+ currentVersion: "2.1.310",
445
+ latestVersion: "2.1.310",
446
+ updateCommand: "claude update",
447
+ canUpdate: true,
448
+ checkedAt: "2026-04-10T00:00:00.000Z",
449
+ message: null,
450
+ },
451
+ });
452
+ const updater = yield* makeTestRunner(
453
+ {
454
+ ...registry,
455
+ refreshInstance: (instanceId) =>
456
+ Ref.updateAndGet(providersRef, (providers) =>
457
+ providers.map((provider) =>
458
+ provider.instanceId === instanceId
459
+ ? { ...provider, checkedAt: "2026-04-10T00:00:01.000Z" }
460
+ : provider,
461
+ ),
462
+ ),
463
+ getProviderMaintenanceCapabilitiesForInstance: () =>
464
+ Effect.succeed(
465
+ makeProviderMaintenanceCapabilities({
466
+ provider: CODEX_DRIVER,
467
+ packageName: "@anthropic-ai/claude-code",
468
+ updateExecutable: "claude",
469
+ updateArgs: ["update"],
470
+ updateLockKey: "claudeAgent-native",
471
+ }),
472
+ ),
473
+ },
474
+ undefined,
475
+ layerFailingLatestLookupAfterFirst(),
476
+ );
477
+
478
+ const result = yield* updater.updateProvider(CODEX_DRIVER);
479
+ assert.deepStrictEqual(calls, [{ command: "claude", args: ["update"] }]);
480
+ assert.strictEqual(result.providers[0]?.updateState?.status, "succeeded");
481
+ }).pipe(
482
+ Effect.provide(
483
+ Layer.mergeAll(
484
+ layerNonWindowsPlatform,
485
+ layerLatestVersionHttpClient("2.1.310"),
486
layerMockSpawner((command, args) => {
487
calls.push({ command, args });
488
return { stdout: "updated" };
@@ -298,7 +511,7 @@ describe("providerMaintenanceRunner", () => {
511
Effect.provide(
512
Layer.mergeAll(
513
layerNonWindowsPlatform,
301
- layerLatestVersionHttpClient("0.0.0"),
514
+ layerLatestVersionHttpClient("1.0.0"),
515
layerMockSpawner(() => ({ stdout: "updated" })),
516
),
517
),
@@ -331,7 +544,7 @@ describe("providerMaintenanceRunner", () => {
544
Effect.provide(
545
Layer.mergeAll(
546
layerNonWindowsPlatform,
334
- layerLatestVersionHttpClient("0.0.0"),
547
+ layerLatestVersionHttpClient("1.0.0"),
548
layerMockSpawner((_command, _args, options) => {
549
seen.push(options.env);
550
return { stdout: "updated" };
@@ -371,7 +584,7 @@ describe("providerMaintenanceRunner", () => {
584
Effect.provide(
585
Layer.mergeAll(
586
layerNonWindowsPlatform,
374
- layerLatestVersionHttpClient("0.0.0"),
587
+ layerLatestVersionHttpClient("1.0.0"),
588
layerMockSpawner((command, args) => {
589
calls.push({ command, args });
590
return { stdout: "updated" };
@@ -433,7 +646,7 @@ describe("providerMaintenanceRunner", () => {
646
Effect.provide(
647
Layer.mergeAll(
648
layerNonWindowsPlatform,
436
- layerLatestVersionHttpClient("0.0.0"),
649
+ layerLatestVersionHttpClient("1.0.0"),
650
layerMockSpawner((command) => {
651
calls.push(command);
652
return { stdout: "updated" };
@@ -461,7 +674,7 @@ describe("providerMaintenanceRunner", () => {
674
Effect.provide(
675
Layer.mergeAll(
676
layerNonWindowsPlatform,
464
- layerLatestVersionHttpClient("0.0.0"),
677
+ layerLatestVersionHttpClient("1.0.0"),
678
layerMockSpawner(() => ({
679
stdout: "checking install\n",
680
stderr: "Error: Could not detect the Codex installation method.\n\n",
@@ -487,7 +700,7 @@ describe("providerMaintenanceRunner", () => {
700
Effect.provide(
701
Layer.mergeAll(
702
layerNonWindowsPlatform,
490
- layerLatestVersionHttpClient("0.0.0"),
703
+ layerLatestVersionHttpClient("1.0.0"),
704
layerMockSpawner(() => ({ code: 1 })),
705
),
706
),
@@ -552,7 +765,7 @@ describe("providerMaintenanceRunner", () => {
765
Effect.provide(
766
Layer.mergeAll(
767
layerNonWindowsPlatform,
555
- layerLatestVersionHttpClient("0.0.0"),
768
+ layerLatestVersionHttpClient("1.0.0"),
769
layerMockSpawner(() => {
770
startedLatch.resolve();
771
return {
@@ -571,7 +784,9 @@ describe("providerMaintenanceRunner", () => {
784
"releases the running-provider marker when interrupted after queuing but before the lock run starts",
785
() =>
786
Effect.gen(function* () {
574
- const { registry } = yield* makeRegistry(baseProvider);
787
+ const { registry } = yield* makeRegistry(baseProvider, {
788
+ installedVersionAfterUpdate: "1.0.0",
789
+ });
790
let blockQueuedState = true;
791
const queuedStateWrittenLatch: { resolve: () => void } = { resolve: () => {} };
792
const releaseQueuedStateLatch: { resolve: () => void } = { resolve: () => {} };
@@ -612,7 +827,7 @@ describe("providerMaintenanceRunner", () => {
827
Effect.provide(
828
Layer.mergeAll(
829
layerNonWindowsPlatform,
615
- layerLatestVersionHttpClient("0.0.0"),
830
+ layerLatestVersionHttpClient("1.0.0"),
831
layerMockSpawner(() => ({ stdout: "updated" })),
832
),
833
),
@@ -626,7 +841,9 @@ describe("providerMaintenanceRunner", () => {
841
readonly shell: boolean | string | undefined;
842
}> = [];
843
return Effect.gen(function* () {
629
- const { registry } = yield* makeRegistry(baseProvider);
844
+ const { registry } = yield* makeRegistry(baseProvider, {
845
+ installedVersionAfterUpdate: "1.0.0",
846
+ });
847
const runner = yield* makeTestRunner(registry);
848
849
const result = yield* runner.updateProvider(CODEX_DRIVER);
@@ -652,7 +869,7 @@ describe("providerMaintenanceRunner", () => {
869
Layer.succeed(SpawnExecutableResolution, (command) =>
870
command === "npm" ? "C:\\fake\\npm\\npm.cmd" : undefined,
871
),
655
- layerLatestVersionHttpClient("0.0.0"),
872
+ layerLatestVersionHttpClient("1.0.0"),
873
Layer.succeed(
874
ChildProcessSpawner.ChildProcessSpawner,
875
ChildProcessSpawner.make((command) => {
@@ -689,8 +906,14 @@ it.effect.each([
906
status: "succeeded",
907
},
908
{
692
- mode: "unknown",
909
+ mode: "targeted-current",
910
version: "1.14.20",
911
+ installation: { installedVersion: "1.14.20" },
912
+ status: "succeeded",
913
+ },
914
+ {
915
+ mode: "unknown",
916
+ version: "1.14.19",
917
installation: { installedVersion: null },
918
status: "unchanged",
919
},
@@ -723,6 +946,10 @@ it.effect.each([
946
const updater = yield* makeTestRunner(
947
{
948
...registry,
949
+ refreshInstance: () =>
950
+ Ref.updateAndGet(providersRef, (providers) =>
951
+ providers.map((provider) => ({ ...provider, checkedAt: "2026-04-10T00:00:01.000Z" })),
952
+ ),
953
getProviderMaintenanceCapabilitiesForInstance: () => Effect.succeed(pinnedCapabilities),
954
refreshAfterUpdate: () =>
955
Effect.gen(function* () {
@@ -786,7 +1013,7 @@ it.effect(
1013
"uses fresh installer versions for post-update verification and compatibility checks",
1014
() => {
1015
const calls: string[] = [];
789
- let latest = "1.0.0";
1016
+ let latest = "2.0.0";
1017
const manifest: ModelManifest.ModelManifestData = {
1018
version: 1,
1019
currentModels: {},
apps/server/src/provider/providerMaintenanceRunner.ts
+48
-4
@@ -83,6 +83,7 @@ class ProviderMaintenanceCommandError extends Data.TaggedError("ProviderMaintena
83
interface VerifiedProviderRefresh {
84
readonly providers: ReadonlyArray<ServerProvider>;
85
readonly verifiedProviders: ReadonlyArray<ServerProvider>;
86
+ readonly advisoryEnriched: boolean;
87
}
88
89
const nowIso = Effect.map(DateTime.now, DateTime.formatIso);
@@ -315,12 +316,14 @@ export const make = Effect.fn("ProviderMaintenanceRunner.make")(function* () {
316
}),
317
});
318
318
- const verifyRefreshedProvider = (
319
+ const verifyFromRefresh = (
320
+ refresh: Effect.Effect<ReadonlyArray<ServerProvider>>,
321
provider: ProviderDriverKind,
322
maintenanceCapabilities: ProviderMaintenanceCapabilities,
323
instanceId: ProviderInstanceId,
324
+ phase: "pre-update" | "post-update",
325
): Effect.Effect<VerifiedProviderRefresh> =>
323
- providerRegistry.refreshAfterUpdate(provider, instanceId).pipe(
326
+ refresh.pipe(
327
Effect.flatMap((providers) => {
328
const refreshedProviders = providers.filter(
329
(candidate) => candidate.driver === provider && candidate.instanceId === instanceId,
@@ -329,6 +332,7 @@ export const make = Effect.fn("ProviderMaintenanceRunner.make")(function* () {
332
return Effect.succeed<VerifiedProviderRefresh>({
333
providers,
334
verifiedProviders: [],
335
+ advisoryEnriched: true,
336
});
337
}
338
return Effect.forEach(
@@ -348,15 +352,18 @@ export const make = Effect.fn("ProviderMaintenanceRunner.make")(function* () {
352
Effect.map((verifiedProviders): VerifiedProviderRefresh => ({
353
providers,
354
verifiedProviders,
355
+ advisoryEnriched: true,
356
})),
357
Effect.catchCause((cause) =>
353
- Effect.logWarning("Provider post-update version verification failed", {
358
+ Effect.logWarning("Provider version verification failed", {
359
provider,
360
+ phase,
361
cause: Cause.pretty(cause),
362
}).pipe(
363
Effect.as<VerifiedProviderRefresh>({
364
providers,
365
verifiedProviders: refreshedProviders,
366
+ advisoryEnriched: false,
367
}),
368
),
369
),
@@ -481,6 +488,41 @@ export const make = Effect.fn("ProviderMaintenanceRunner.make")(function* () {
488
}),
489
);
490
}
491
+
492
+ if (targetVersion === undefined) {
493
+ const prior = (yield* providerRegistry.getProviders).find(
494
+ (candidate) => candidate.instanceId === instanceId,
495
+ );
496
+ const precheck = yield* verifyFromRefresh(
497
+ providerRegistry.refreshInstance(instanceId),
498
+ provider,
499
+ fresh,
500
+ instanceId,
501
+ "pre-update",
502
+ );
503
+ const alreadyCurrent =
504
+ precheck.advisoryEnriched &&
505
+ prior !== undefined &&
506
+ precheck.verifiedProviders.length > 0 &&
507
+ precheck.verifiedProviders.every(
508
+ (verified) =>
509
+ verified.checkedAt !== prior.checkedAt &&
510
+ verified.installed &&
511
+ verified.status !== "error" &&
512
+ verified.versionAdvisory?.status === "current",
513
+ );
514
+ if (alreadyCurrent) {
515
+ return yield* finish(
516
+ makeUpdateState({
517
+ status: "succeeded",
518
+ startedAt,
519
+ finishedAt: yield* nowIso,
520
+ message: "Already up to date.",
521
+ }),
522
+ );
523
+ }
524
+ }
525
+
526
yield* setRunningMessage(`Running ${describeCommand(command)}`);
527
const result = yield* runMaintenanceCommand(command, setRunningMessage);
528
const finishedAt = yield* nowIso;
@@ -512,10 +554,12 @@ export const make = Effect.fn("ProviderMaintenanceRunner.make")(function* () {
554
yield* invalidateLatestProviderVersion(verified).pipe(
555
Effect.provideService(ProviderLatestVersions.ProviderLatestVersions, latestVersions),
556
);
515
- const { verifiedProviders } = yield* verifyRefreshedProvider(
557
+ const { verifiedProviders } = yield* verifyFromRefresh(
558
+ providerRegistry.refreshAfterUpdate(provider, instanceId),
559
provider,
560
verified,
561
instanceId,
562
+ "post-update",
563
);
564
// Cursor about probes can fail transiently; missing versions alone do not imply failure.
565
const couldNotVerify =