@devries-cameron20 / t3code-1 / commits / 8344de78eb
Fork 0

The best way to control Claude Code, Codex and more from any computer or phone

ci(release): JS bundle jobs stop building an unused Linux helper (#31941)

Release and macOS preview bundle jobs can check out a ref from before build:desktop:bundle existed. Those refs now install libsecret and run build:desktop as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Theo Browne committed Nov 6, 2026 at 03:01 UTC 8344de78eb5e1ee1c32a685bea62cf89afcf1752
4 files changed +38 -10
.github/workflows/desktop-macos-preview.yml
+14 -3
@@ -73,16 +73,27 @@ jobs:
73 # Public T3 Connect identifiers (Clerk publishable key, relay URL).
74 cp .env.example .env
75
76 - - uses: ./.github/actions/setup-apt-mirrors
76 + # PR heads from before build:desktop:bundle use the full build, which
77 + # compiles the Linux browser secret helper and needs libsecret.
78 + - name: Check bundle-only build support
79 + id: bundle_build
80 + run: |
81 + script="$(node -p "require('./package.json').scripts['build:desktop:bundle'] ? 'build:desktop:bundle' : 'build:desktop'")"
82 + echo "script=$script" >> "$GITHUB_OUTPUT"
83 +
84 + - if: steps.bundle_build.outputs.script == 'build:desktop'
85 + uses: ./.github/actions/setup-apt-mirrors
86
87 - name: Install browser secret helper build libraries
88 + if: steps.bundle_build.outputs.script == 'build:desktop'
89 run: sudo apt-get update && sudo apt-get install -y libsecret-1-dev pkg-config
90
81 - # desktop-macos-preview-publish.yml packages this bundle as the preview channel.
91 + # desktop-macos-preview-publish.yml packages this bundle as the preview
92 + # channel. The Linux browser secret helper is not part of a macOS app.
93 - name: Build JS bundle
94 env:
95 T3CODE_TELEMETRY_CHANNEL: ${{ github.repository == 'pingdotgg/t3code' && 'preview' || 'dev' }}
85 - run: vp run build:desktop
96 + run: vp run ${{ steps.bundle_build.outputs.script }}
97
98 # Same layout as release.yml's js-bundle so release-desktop.yml can
99 # package it unchanged.
.github/workflows/release.yml
+17 -7
@@ -565,22 +565,32 @@ jobs:
565 - name: Align package versions to release version
566 run: node scripts/update-release-package-versions.ts "${{ needs.preflight.outputs.version }}"
567
568 - - uses: ./.github/actions/setup-apt-mirrors
568 + # Older release refs lack build:desktop:bundle and use the full build,
569 + # which compiles the Linux browser secret helper and needs libsecret.
570 + - name: Check bundle-only build support
571 + id: bundle_build
572 + run: |
573 + script="$(node -p "require('./package.json').scripts['build:desktop:bundle'] ? 'build:desktop:bundle' : 'build:desktop'")"
574 + echo "script=$script" >> "$GITHUB_OUTPUT"
575 +
576 + - if: steps.bundle_build.outputs.script == 'build:desktop'
577 + uses: ./.github/actions/setup-apt-mirrors
578
570 - # @t3tools/desktop#build compiles the Linux browser secret helper on a
571 - # Linux host before packing, and that needs libsecret headers.
579 - name: Install browser secret helper build libraries
580 + if: steps.bundle_build.outputs.script == 'build:desktop'
581 run: sudo apt-get update && sudo apt-get install -y libsecret-1-dev pkg-config
582
575 - # Runs t3#build (which depends on @t3tools/web#build) and
576 - # @t3tools/desktop#build, so apps/server/dist holds the server bundle
577 - # plus the web client and apps/desktop/dist-electron the Electron main.
583 + # Runs t3#build (which depends on @t3tools/web#build) and the desktop
584 + # bundle, so apps/server/dist holds the server bundle plus the web client
585 + # and apps/desktop/dist-electron the Electron main. build:desktop:bundle
586 + # skips the Linux browser secret helper, which this artifact does not
587 + # carry; each Linux package job compiles its own per arch.
588 # The release channel is already stable, nightly, or preview. Builds in
589 # other repositories report "dev" telemetry.
590 - name: Build JS bundle
591 env:
592 T3CODE_TELEMETRY_CHANNEL: ${{ github.repository == 'pingdotgg/t3code' && needs.preflight.outputs.release_channel || 'dev' }}
583 - run: vp run build:desktop
593 + run: vp run ${{ steps.bundle_build.outputs.script }}
594
595 # Two paths under apps/ so the artifact root is apps/; consumers download
596 # into `apps` to restore both at their original locations.
apps/desktop/vite.config.ts
+6
@@ -25,6 +25,12 @@ export default defineConfig({
25 dependsOn: ["t3#build"],
26 cache: false,
27 },
28 + // CI bundle jobs skip the Linux browser secret helper; packaging stages one per arch.
29 + "build:bundle": {
30 + command: "node scripts/build-preview-annotation-css.mjs && vp pack",
31 + dependsOn: ["t3#build"],
32 + cache: false,
33 + },
34 dev: {
35 command:
36 "node scripts/build-browser-secret.mjs && node scripts/build-preview-annotation-css.mjs && cross-env T3CODE_DESKTOP_DEV=1 vp pack --watch",
package.json
+1
@@ -24,6 +24,7 @@
24 "build": "vp run --filter './apps/*' build",
25 "build:marketing": "vp run --filter @t3tools/marketing build",
26 "build:desktop": "vp run --filter @t3tools/desktop --filter t3 build",
27 + "build:desktop:bundle": "vp run --filter @t3tools/desktop build:bundle",
28 "build:resource-monitor": "cargo build --locked --release --manifest-path native/resource-monitor/Cargo.toml",
29 "typecheck": "vp run -r --cache --concurrency-limit 4 typecheck",
30 "tc": "vp run -r --cache --concurrency-limit 4 typecheck",