The best way to control Claude Code, Codex and more from any computer or phone
fix(scenarios): second server startup failure no longer hangs (#37847)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Wout Stiens committed
Nov 17, 2026 at 02:47 UTC
88fc9ace2dcb8958a1832156c9837357d475ec63
2 files changed
+52
-3
scripts/scenarios/second-server.test.ts
new
+32
@@ -0,0 +1,32 @@
1
+// @effect-diagnostics nodeBuiltinImport:off - runs a failing server fixture in an isolated directory.
2
+import * as NodeFSP from "node:fs/promises";
3
+import * as NodePath from "node:path";
4
+import { expect, it, vi } from "vite-plus/test";
5
+
6
+const root = await vi.hoisted(async () => {
7
+ const fs = await import("node:fs/promises");
8
+ const os = await import("node:os");
9
+ const path = await import("node:path");
10
+ return fs.mkdtemp(path.join(os.tmpdir(), "second-server-exit-"));
11
+});
12
+
13
+vi.mock("../e2e.config.ts", () => ({
14
+ APP_DIR: root,
15
+ T3_HOME: NodePath.join(root, "home"),
16
+}));
17
+
18
+import { startSecondServer } from "./second-server.ts";
19
+
20
+it("rejects readiness when the second server exits before printing a token", async () => {
21
+ await NodeFSP.mkdir(NodePath.join(root, "apps/server/src"), { recursive: true });
22
+ await NodeFSP.writeFile(NodePath.join(root, "apps/server/src/bin.ts"), "process.exit(1);\n");
23
+ const server = startSecondServer("http://127.0.0.1:5733");
24
+ try {
25
+ await expect(server.ready).rejects.toMatchObject({
26
+ message: "The second server exited with code 1 at startup.",
27
+ });
28
+ } finally {
29
+ await server.stop();
30
+ await NodeFSP.rm(root, { recursive: true, force: true });
31
+ }
32
+});
scripts/scenarios/second-server.ts
+20
-3
@@ -3,12 +3,15 @@
3
import * as NodeServices from "@effect/platform-node/NodeServices";
4
import * as HostProcess from "@t3tools/shared/HostProcess";
5
import * as NetService from "@t3tools/shared/Net";
6
+import * as Cause from "effect/Cause";
7
import * as Deferred from "effect/Deferred";
8
import * as Effect from "effect/Effect";
9
+import * as Exit from "effect/Exit";
10
import * as Fiber from "effect/Fiber";
11
import * as Path from "effect/Path";
12
13
import { APP_DIR, T3_HOME } from "../e2e.config.ts";
14
+import { ScenarioError } from "./shell.ts";
15
import { prepareHome, start } from "./start-app.ts";
16
17
export const SECOND_HOME = `${T3_HOME}-second-environment`;
@@ -25,7 +28,7 @@ const runSecondServer = Effect.fn("scenario.secondServer")(function* (
28
const port = yield* (yield* NetService.NetService).reserveLoopbackPort();
29
yield* prepareHome(SECOND_HOME);
30
const token = yield* Deferred.make<string>();
28
- yield* start({
31
+ const server = yield* start({
32
cwd: APP_DIR,
33
command: node,
34
args: [
@@ -50,7 +53,17 @@ const runSecondServer = Effect.fn("scenario.secondServer")(function* (
53
return value === undefined ? Effect.void : Deferred.succeed(token, value).pipe(Effect.asVoid);
54
},
55
});
53
- paired({ host: `http://127.0.0.1:${port}`, token: yield* Deferred.await(token) });
56
+ // A server that exits before printing its token never will: fail instead of waiting forever.
57
+ const exited = server.exitCode.pipe(
58
+ Effect.flatMap(
59
+ (code) =>
60
+ new ScenarioError({ message: `The second server exited with code ${code} at startup.` }),
61
+ ),
62
+ );
63
+ paired({
64
+ host: `http://127.0.0.1:${port}`,
65
+ token: yield* Effect.raceFirst(Deferred.await(token), exited),
66
+ });
67
return yield* Effect.never;
68
});
69
@@ -63,6 +76,10 @@ export function startSecondServer(devUrl: string) {
76
Effect.provide([NodeServices.layer, NetService.layer]),
77
),
78
);
66
- server.addObserver(() => pairing.reject(new Error("The second server stopped.")));
79
+ server.addObserver((exit) =>
80
+ pairing.reject(
81
+ Exit.isFailure(exit) ? Cause.squash(exit.cause) : new Error("The second server stopped."),
82
+ ),
83
+ );
84
return { ready: pairing.promise, stop: () => Effect.runPromise(Fiber.interrupt(server)) };
85
}