@devries-cameron20 / t3code-1 / commits / 8a80ea1f7f
Fork 0

The best way to control Claude Code, Codex and more from any computer or phone

fix(cursor): save SDK credentials with undefined optional fields (#24702)

Co-authored-by: maria-rcks <maria@kuuro.net>

Onkar Pradip Jadhav committed Oct 31, 2026 at 02:37 UTC 8a80ea1f7f87c63df785220988228a5466358548
2 files changed +52 -2
packages/provider-cursor/src/server/credentialStore.test.ts
+45
@@ -1,3 +1,4 @@
1 +import type { StoredSdkCredentials } from "@cursor/sdk";
2 import * as NodeServices from "@effect/platform-node/NodeServices";
3 import { assert, it } from "@effect/vitest";
4 import { ProviderInstanceId } from "@t3tools/contracts";
@@ -95,3 +96,47 @@ it.effect(
96 );
97 }).pipe(Effect.provide(layerHost)),
98 );
99 +
100 +it.effect.each([
101 + {
102 + name: "an undefined email",
103 + optionalFields: { email: undefined, apiKeyExpiresAtMs: 1000 },
104 + expectedFields: { apiKeyExpiresAtMs: 1000 },
105 + },
106 + {
107 + name: "an undefined expiry",
108 + optionalFields: { email: "test@example.com", apiKeyExpiresAtMs: undefined },
109 + expectedFields: { email: "test@example.com" },
110 + },
111 + {
112 + name: "both optional fields undefined",
113 + optionalFields: { email: undefined, apiKeyExpiresAtMs: undefined },
114 + expectedFields: {},
115 + },
116 + {
117 + name: "both optional fields omitted",
118 + optionalFields: {},
119 + expectedFields: {},
120 + },
121 +])("restores SDK credentials with $name in a new store", ({ optionalFields, expectedFields }) =>
122 + Effect.gen(function* () {
123 + const instanceId = ProviderInstanceId.make("personal");
124 + const { store } = yield* makeCursorCredentialStore(instanceId);
125 + const requiredFields: StoredSdkCredentials = {
126 + version: 1,
127 + backendUrl: "https://api.cursor.com",
128 + apiKey: "test-only-key",
129 + createdAtMs: 100,
130 + };
131 + const credentials = { ...requiredFields };
132 + // Match the SDK's runtime values without relying on its stricter declarations.
133 + Object.assign(credentials, optionalFields);
134 + yield* Effect.tryPromise(() => store.save(credentials));
135 +
136 + const restored = yield* makeCursorCredentialStore(instanceId);
137 + assert.deepEqual(yield* Effect.tryPromise(() => restored.store.load()), {
138 + ...requiredFields,
139 + ...expectedFields,
140 + });
141 + }).pipe(Effect.provide(layerHost)),
142 +);
packages/provider-cursor/src/server/credentialStore.ts
+7 -2
@@ -67,9 +67,14 @@ export const makeCursorCredentialStore = Effect.fn("makeCursorCredentialStore")(
67 ),
68 ),
69 ),
70 - save: (value) =>
70 + // The SDK can supply undefined optional fields despite its exact optional types.
71 + save: ({ email, apiKeyExpiresAtMs, ...requiredFields }) =>
72 runPromise(
72 - encodeCredentials(value).pipe(
73 + encodeCredentials({
74 + ...requiredFields,
75 + ...(email === undefined ? {} : { email }),
76 + ...(apiKeyExpiresAtMs === undefined ? {} : { apiKeyExpiresAtMs }),
77 + }).pipe(
78 Effect.mapError(
79 () =>
80 new ProviderSetupError({