The best way to control Claude Code, Codex and more from any computer or phone
fix(mobile): use the shared rounded frame for issue details (#38491)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Alex committed
Nov 18, 2026 at 04:23 UTC
9431a9479faf0ae89a4e5cdbb061ce5f478b15c7
1 file changed
+131
-126
apps/mobile/src/features/issues/IssueRouteScreen.tsx
+131
-126
@@ -27,6 +27,7 @@ import { Chip } from "../../components/ui/Chip";
27
import { EmptyState } from "../../components/ui/EmptyState";
28
import { Menu } from "../../components/ui/Menu";
29
import { RefreshControl } from "../../components/ui/RefreshControl";
30
+import { ScreenContent } from "../../components/ui/ScreenContent";
31
import { copyTextWithHaptic } from "../../lib/copyTextWithHaptic";
32
import { useComposerBottomInset } from "../../components/ComposerSurface";
33
import { ANDROID_READING_MAX_WIDTH, CHAT_CONTENT_MAX_WIDTH } from "../../lib/layout";
@@ -542,138 +543,142 @@ function IssueRoute({ params }: { readonly params: IssueParams }) {
543
},
544
]}
545
/>
545
- {!usesNativeWorkspaceColumns ? <NativeLayoutObserver onChange={setScreenMetrics} /> : null}
546
- {/* Not a bare marker: Android wraps a refreshable scroll view, which the marker rejects. */}
547
- <NativeScrollView
548
- className="flex-1"
549
- contentInsetAdjustmentBehavior="automatic"
550
- keyboardShouldPersistTaps="handled"
551
- keyboardDismissMode="interactive"
552
- refreshControl={
553
- <RefreshControl
554
- refreshing={pullRefresh.refreshing}
555
- onRefresh={() => void pager.refresh(registry, pullRefresh.onRefresh)}
556
- />
557
- }
558
- contentContainerStyle={{
559
- paddingHorizontal: 16,
560
- paddingTop: 8,
561
- paddingBottom: showComposer ? composerHeight + 16 : 24,
562
- }}
563
- >
564
- {!issue ? (
565
- detailQuery.error && !detailQuery.isPending ? (
566
- <EmptyState
567
- title={gt("Couldn't load this issue")}
568
- detail={detailQuery.error}
569
- variant="plain"
546
+ <ScreenContent>
547
+ {!usesNativeWorkspaceColumns ? (
548
+ <NativeLayoutObserver onChange={setScreenMetrics} />
549
+ ) : null}
550
+ {/* Not a bare marker: Android wraps a refreshable scroll view, which the marker rejects. */}
551
+ <NativeScrollView
552
+ className="flex-1"
553
+ contentInsetAdjustmentBehavior="automatic"
554
+ keyboardShouldPersistTaps="handled"
555
+ keyboardDismissMode="interactive"
556
+ refreshControl={
557
+ <RefreshControl
558
+ refreshing={pullRefresh.refreshing}
559
+ onRefresh={() => void pager.refresh(registry, pullRefresh.onRefresh)}
560
/>
561
+ }
562
+ contentContainerStyle={{
563
+ paddingHorizontal: 16,
564
+ paddingTop: 8,
565
+ paddingBottom: showComposer ? composerHeight + 16 : 24,
566
+ }}
567
+ >
568
+ {!issue ? (
569
+ detailQuery.error && !detailQuery.isPending ? (
570
+ <EmptyState
571
+ title={gt("Couldn't load this issue")}
572
+ detail={detailQuery.error}
573
+ variant="plain"
574
+ />
575
+ ) : (
576
+ <AppActivityIndicator className="my-12" colorClassName="accent-icon" />
577
+ )
578
) : (
572
- <AppActivityIndicator className="my-12" colorClassName="accent-icon" />
573
- )
574
- ) : (
575
- <View className="gap-5">
576
- <IssueIdentity
577
- issue={issue}
578
- access={access}
579
- busy={busy === "state"}
580
- onMove={moveTo}
581
- onEditLabels={() => navigation.navigate("IssueLabels", identity)}
582
- onEditAssignees={() => navigation.navigate("IssueAssignees", identity)}
583
- />
584
- {error || (detail && detailQuery.error) ? (
585
- <Text selectable className="text-sm text-danger-foreground">
586
- {error ?? detailQuery.error}
587
- </Text>
588
- ) : null}
589
- {!detail ? (
590
- detailQuery.error && !detailQuery.isPending ? (
591
- <EmptyState
592
- title={gt("Couldn't load this issue")}
593
- detail={detailQuery.error}
594
- variant="plain"
595
- />
579
+ <View className="gap-5">
580
+ <IssueIdentity
581
+ issue={issue}
582
+ access={access}
583
+ busy={busy === "state"}
584
+ onMove={moveTo}
585
+ onEditLabels={() => navigation.navigate("IssueLabels", identity)}
586
+ onEditAssignees={() => navigation.navigate("IssueAssignees", identity)}
587
+ />
588
+ {error || (detail && detailQuery.error) ? (
589
+ <Text selectable className="text-sm text-danger-foreground">
590
+ {error ?? detailQuery.error}
591
+ </Text>
592
+ ) : null}
593
+ {!detail ? (
594
+ detailQuery.error && !detailQuery.isPending ? (
595
+ <EmptyState
596
+ title={gt("Couldn't load this issue")}
597
+ detail={detailQuery.error}
598
+ variant="plain"
599
+ />
600
+ ) : (
601
+ <IssueLoadingBody />
602
+ )
603
) : (
597
- <IssueLoadingBody />
598
- )
599
- ) : (
600
- <>
601
- <PullRequestDescription
602
- markdown={detail.body}
603
- footer={
604
- detail.reactions !== undefined ? (
605
- <IssueReactions
606
- params={params}
607
- reactions={detail.reactions}
608
- canReact={access?.react === true}
609
- />
610
- ) : undefined
611
- }
612
- />
613
- {detail.linkedPullRequests.length > 0 ? (
614
- <LinkedPullRequests params={params} links={detail.linkedPullRequests} />
615
- ) : null}
616
- <View className="gap-3">
617
- <PullRequestSectionHeading>
618
- {detail.commentCount > 0
619
- ? gt(
620
- "{count, plural, one {Activity · {count} comment} other {Activity · {count} comments}}",
621
- { count: detail.commentCount },
622
- )
623
- : gt("Activity")}
624
- </PullRequestSectionHeading>
625
- {nextCursor !== null ? (
626
- <Button
627
- label={loadingOlder ? gt("Loading…") : gt("Load older comments")}
628
- disabled={busy !== null || !canLoadOlder}
629
- onPress={() => void loadOlder()}
630
- />
604
+ <>
605
+ <PullRequestDescription
606
+ markdown={detail.body}
607
+ footer={
608
+ detail.reactions !== undefined ? (
609
+ <IssueReactions
610
+ params={params}
611
+ reactions={detail.reactions}
612
+ canReact={access?.react === true}
613
+ />
614
+ ) : undefined
615
+ }
616
+ />
617
+ {detail.linkedPullRequests.length > 0 ? (
618
+ <LinkedPullRequests params={params} links={detail.linkedPullRequests} />
619
) : null}
632
- {timeline.length === 0 ? (
633
- <Text className="text-sm text-foreground-muted">
634
- <T>Nothing has happened here yet.</T>
635
- </Text>
636
- ) : null}
637
- {timeline.map((item) => (
638
- <View key={item.key}>{item.content}</View>
639
- ))}
640
- </View>
641
- </>
642
- )}
643
- </View>
644
- )}
645
- </NativeScrollView>
646
- {showComposer ? (
647
- <KeyboardStickyView
648
- // On the unfolded Duo the sidebar's search shares the keyboard; follow it only for ours.
649
- enabled={deviceType !== "duo-unfolded" || composerFocused}
650
- pointerEvents="box-none"
651
- style={{ position: "absolute", bottom: 0, left: 0, right: 0, top: 0 }}
652
- offset={{ closed: 0, opened: composerBottomInset }}
653
- >
654
- <View
620
+ <View className="gap-3">
621
+ <PullRequestSectionHeading>
622
+ {detail.commentCount > 0
623
+ ? gt(
624
+ "{count, plural, one {Activity · {count} comment} other {Activity · {count} comments}}",
625
+ { count: detail.commentCount },
626
+ )
627
+ : gt("Activity")}
628
+ </PullRequestSectionHeading>
629
+ {nextCursor !== null ? (
630
+ <Button
631
+ label={loadingOlder ? gt("Loading…") : gt("Load older comments")}
632
+ disabled={busy !== null || !canLoadOlder}
633
+ onPress={() => void loadOlder()}
634
+ />
635
+ ) : null}
636
+ {timeline.length === 0 ? (
637
+ <Text className="text-sm text-foreground-muted">
638
+ <T>Nothing has happened here yet.</T>
639
+ </Text>
640
+ ) : null}
641
+ {timeline.map((item) => (
642
+ <View key={item.key}>{item.content}</View>
643
+ ))}
644
+ </View>
645
+ </>
646
+ )}
647
+ </View>
648
+ )}
649
+ </NativeScrollView>
650
+ {showComposer ? (
651
+ <KeyboardStickyView
652
+ // On the unfolded Duo the sidebar's search shares the keyboard; follow it only for ours.
653
+ enabled={deviceType !== "duo-unfolded" || composerFocused}
654
pointerEvents="box-none"
656
- style={{
657
- position: "absolute",
658
- bottom: controlInsets.bottom,
659
- left: controlInsets.left,
660
- right: controlInsets.right,
661
- }}
655
+ style={{ position: "absolute", bottom: 0, left: 0, right: 0, top: 0 }}
656
+ offset={{ closed: 0, opened: composerBottomInset }}
657
>
663
- <IssueCommentComposer
664
- ownerKey={`issue-comment:${issueParamsKey(params)}`}
665
- label={issue?.displayKey ?? params.issueKey}
666
- blocked={commentBlocked}
667
- posting={busy === "comment"}
668
- bottomInset={composerBottomInset}
669
- contentMaxWidth={contentMaxWidth}
670
- onSubmit={submitComment}
671
- onHeightChange={setComposerHeight}
672
- onFocusChange={setComposerFocused}
673
- />
674
- </View>
675
- </KeyboardStickyView>
676
- ) : null}
658
+ <View
659
+ pointerEvents="box-none"
660
+ style={{
661
+ position: "absolute",
662
+ bottom: controlInsets.bottom,
663
+ left: controlInsets.left,
664
+ right: controlInsets.right,
665
+ }}
666
+ >
667
+ <IssueCommentComposer
668
+ ownerKey={`issue-comment:${issueParamsKey(params)}`}
669
+ label={issue?.displayKey ?? params.issueKey}
670
+ blocked={commentBlocked}
671
+ posting={busy === "comment"}
672
+ bottomInset={composerBottomInset}
673
+ contentMaxWidth={contentMaxWidth}
674
+ onSubmit={submitComment}
675
+ onHeightChange={setComposerHeight}
676
+ onFocusChange={setComposerFocused}
677
+ />
678
+ </View>
679
+ </KeyboardStickyView>
680
+ ) : null}
681
+ </ScreenContent>
682
</View>
683
</PullRequestMarkdownRepository>
684
);