The best way to control Claude Code, Codex and more from any computer or phone
test(web): Settings Esc test waits for the modal's initial focus (#37089)
Julius Marminge committed
Nov 14, 2026 at 23:40 UTC
986975e9ebac0ad033a61b2ca9e91fb543a31766
1 file changed
+4
-3
apps/web/src/components/AppRouteModal.browser.test.tsx
+4
-3
@@ -32,6 +32,9 @@ describe("AppRouteModal", () => {
32
</AppRouteModal>,
33
{ router: "/settings/general" },
34
);
35
+ const settings = page.getByRole("dialog", { name: "Settings" });
36
+ // Base UI takes initial focus a frame after opening; let it land before Clerk's modal takes focus.
37
+ await expect.element(settings).toHaveFocus();
38
// Clerk renders its account modal in its own root and dismisses on a document Esc listener.
39
const foreignModal = document.body.appendChild(document.createElement("input"));
40
using _foreignModal = { [Symbol.dispose]: () => foreignModal.remove() };
@@ -39,8 +42,6 @@ describe("AppRouteModal", () => {
42
foreignModal.focus();
43
await userEvent.keyboard("{Escape}");
44
42
- await expect
43
- .element(page.getByRole("dialog", { name: "Settings" }))
44
- .toHaveAttribute("data-open");
45
+ await expect.element(settings).toHaveAttribute("data-open");
46
});
47
});