@devries-cameron20 / t3code-1 / commits / 98f885ac1a
Fork 0

The best way to control Claude Code, Codex and more from any computer or phone

fix(server): desktop preview uploads accept files over 50 MB (#30299)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

Julius Marminge committed Nov 14, 2026 at 20:45 UTC 98f885ac1aa0536786ae221a108fb11f9eab3c44
2 files changed +48 -1
apps/server/src/preview/ServerBrowserContexts.test.ts
+46
@@ -1,4 +1,8 @@
1 +// @effect-diagnostics nodeBuiltinImport:off - Hands a real file on disk to a real desktop browser.
2 import * as NodeEvents from "node:events";
3 +import * as NodeFS from "node:fs";
4 +import * as NodeOS from "node:os";
5 +import * as NodePath from "node:path";
6
7 import { INCOGNITO_BROWSER_PROFILE_ID } from "@t3tools/contracts";
8 import { chromium, type Browser, type BrowserContext, type BrowserType } from "playwright-core";
@@ -12,6 +16,7 @@ const launches = vi.hoisted(() => ({
16 mkdir: vi.fn().mockResolvedValue(undefined),
17 rm: vi.fn().mockResolvedValue(undefined),
18 }));
19 +const launchPersistentChromium = chromium.launchPersistentContext.bind(chromium);
20 vi.spyOn(chromium, "launch").mockImplementation(launches.launch);
21 vi.spyOn(chromium, "launchPersistentContext").mockImplementation(launches.persistent);
22 vi.mock("node:fs/promises", () => ({ mkdir: launches.mkdir, rm: launches.rm }));
@@ -347,4 +352,45 @@ describe("ServerBrowserContexts", () => {
352 expect(browser.close).toHaveBeenCalledTimes(1);
353 expect(browser.created[0]?.close).toHaveBeenCalled();
354 });
355 +
356 + it("uploads a file over 50 MB to a desktop tab, which shares the server's filesystem", async () => {
357 + const directory = NodeFS.mkdtempSync(NodePath.join(NodeOS.tmpdir(), "t3-desktop-upload-"));
358 + const userDataDir = NodePath.join(directory, "profile");
359 + const pool = new ServerBrowserContexts(options());
360 + try {
361 + const desktop = await launchPersistentChromium(userDataDir, {
362 + headless: true,
363 + args: ["--remote-debugging-port=0"],
364 + });
365 + try {
366 + const [port] = NodeFS.readFileSync(
367 + NodePath.join(userDataDir, "DevToolsActivePort"),
368 + "utf8",
369 + ).split("\n");
370 + const { browser, page } = await pool.connectDesktopPage(`http://127.0.0.1:${port}`);
371 + try {
372 + const file = NodePath.join(directory, "large.bin");
373 + NodeFS.writeFileSync(file, "");
374 + NodeFS.truncateSync(file, 51 * 1024 * 1024);
375 + await page.setContent(`<input type="file">`);
376 + await page.locator("input").setInputFiles(file);
377 + expect(
378 + await page.$eval("input", (input) =>
379 + Array.from(
380 + (input as unknown as { files: ArrayLike<{ name: string; size: number }> }).files,
381 + ({ name, size }) => ({ name, size }),
382 + ),
383 + ),
384 + ).toEqual([{ name: "large.bin", size: 51 * 1024 * 1024 }]);
385 + } finally {
386 + await browser.close();
387 + }
388 + } finally {
389 + await pool.close();
390 + await desktop.close();
391 + }
392 + } finally {
393 + NodeFS.rmSync(directory, { recursive: true, force: true });
394 + }
395 + });
396 });
apps/server/src/preview/ServerBrowserContexts.ts
+2 -1
@@ -279,7 +279,8 @@ export class ServerBrowserContexts {
279
280 async connectDesktopPage(endpoint: string) {
281 const { chromium } = loadPlaywright();
282 - const browser = await chromium.connectOverCDP(endpoint, { timeout: 15_000 });
282 + // Only a same-machine desktop backend gets the browser channel, so uploads can pass file paths.
283 + const browser = await chromium.connectOverCDP(endpoint, { isLocal: true, timeout: 15_000 });
284 const page = browser.contexts().flatMap((context) => context.pages())[0];
285 if (!page) {
286 await browser.close().catch(constVoid);