The best way to control Claude Code, Codex and more from any computer or phone
fix(provider-core): one failed status check no longer marks a ready provider unavailable (#34885)
Julius Marminge committed
Nov 11, 2026 at 23:53 UTC
9bcca0443c1ebe4bfa73ba5e1e4eed58412e7859
2 files changed
+74
-9
packages/provider-core/src/server/managedProvider.test.ts
+47
@@ -368,6 +368,53 @@ describe("makeManagedServerProvider", () => {
368
).pipe(Effect.provide(Layer.mergeAll(layerAlwaysRunTest, TestClock.layer()))),
369
);
370
371
+ it.effect("rechecks a ready provider after one failed periodic check before publishing it", () =>
372
+ Effect.scoped(
373
+ Effect.gen(function* () {
374
+ const checkCalls = yield* Ref.make(0);
375
+ const initialCheckDone = yield* Deferred.make<void>();
376
+ const failedSnapshot: ServerProvider = {
377
+ ...refreshedSnapshot,
378
+ status: "error",
379
+ auth: { status: "unknown" },
380
+ message: "Codex app-server provider probe failed: workspace routing discovery timed out.",
381
+ };
382
+ const provider = yield* makeManagedServerProvider<TestSettings>({
383
+ resolveMaintenance: () => Effect.succeed(maintenanceCapabilities),
384
+ getSettings: Effect.succeed({ enabled: true }),
385
+ streamSettings: Stream.empty,
386
+ haveSettingsChanged: (previous, next) => previous.enabled !== next.enabled,
387
+ initialSnapshot: () => Effect.succeed(initialSnapshot),
388
+ checkProvider: Ref.updateAndGet(checkCalls, (count) => count + 1).pipe(
389
+ Effect.tap((count) =>
390
+ count === 1
391
+ ? Deferred.succeed(initialCheckDone, undefined).pipe(Effect.ignore)
392
+ : Effect.void,
393
+ ),
394
+ Effect.map((count) => (count === 2 ? failedSnapshot : refreshedSnapshot)),
395
+ ),
396
+ refreshInterval: "5 minutes",
397
+ });
398
+ yield* Deferred.await(initialCheckDone);
399
+ const published = yield* Ref.make<ReadonlyArray<ServerProvider>>([]);
400
+ yield* provider.streamChanges.pipe(
401
+ Stream.runForEach((snapshot) => Ref.update(published, (all) => [...all, snapshot])),
402
+ Effect.forkChild,
403
+ );
404
+ yield* Effect.yieldNow;
405
+
406
+ yield* TestClock.adjust("5 minutes");
407
+ yield* TestClock.adjust("1 minute");
408
+
409
+ assert.strictEqual((yield* provider.getSnapshot).status, "ready");
410
+ assert.deepStrictEqual(
411
+ (yield* Ref.get(published)).filter((snapshot) => snapshot.status === "error"),
412
+ [],
413
+ );
414
+ }),
415
+ ).pipe(Effect.provide(Layer.mergeAll(layerAlwaysRunTest, TestClock.layer()))),
416
+ );
417
+
418
it.effect("reruns the provider check when streamed settings change", () =>
419
Effect.scoped(
420
Effect.gen(function* () {
packages/provider-core/src/server/managedProvider.ts
+27
-9
@@ -42,6 +42,8 @@ function withUsageLimits(
42
return usageLimits ? { ...rest, usageLimits } : rest;
43
}
44
45
+const FAILED_CHECK_RECHECK_DELAY = "30 seconds";
46
+
47
export const makeManagedServerProvider = Effect.fn("makeManagedServerProvider")(function* <
48
Settings,
49
>(input: {
@@ -83,6 +85,7 @@ export const makeManagedServerProvider = Effect.fn("makeManagedServerProvider")(
85
checked: false,
86
});
87
const settingsRef = yield* Ref.make(initialSettings);
88
+ const recheckPendingRef = yield* Ref.make(false);
89
const enrichmentFiberRef = yield* Ref.make<Fiber.Fiber<void, unknown> | null>(null);
90
const scope = yield* Effect.scope;
91
@@ -143,7 +146,7 @@ export const makeManagedServerProvider = Effect.fn("makeManagedServerProvider")(
146
147
const applySnapshotBase = Effect.fn("applySnapshot")(function* (
148
nextSettings: Settings,
146
- options?: { readonly forceRefresh?: boolean },
149
+ options?: { readonly forceRefresh?: boolean; readonly deferFailure?: boolean },
150
) {
151
const previousSettings = yield* Ref.get(settingsRef);
152
const settingsChanged =
@@ -176,6 +179,18 @@ export const makeManagedServerProvider = Effect.fn("makeManagedServerProvider")(
179
// A probe without usage must not erase a report published while its I/O was in flight.
180
const usageBeforeProbe = (yield* Ref.get(snapshotStateRef)).snapshot.usageLimits;
181
const probedSnapshot = yield* input.checkProvider;
182
+ // One failed periodic check over a ready provider is often transient; recheck before showing it.
183
+ if (
184
+ options?.deferFailure === true &&
185
+ probedSnapshot.status === "error" &&
186
+ probedSnapshot.auth.status !== "unauthenticated"
187
+ ) {
188
+ const { snapshot } = yield* Ref.get(snapshotStateRef);
189
+ if (snapshot.enabled && snapshot.status === "ready") {
190
+ yield* Ref.set(recheckPendingRef, true);
191
+ return snapshot;
192
+ }
193
+ }
194
const { snapshot: nextSnapshot, generation: nextGeneration } = yield* Ref.modify(
195
snapshotStateRef,
196
(state) => {
@@ -319,12 +334,14 @@ export const makeManagedServerProvider = Effect.fn("makeManagedServerProvider")(
334
input.refreshOnInterval !== false &&
335
(typeof input.refreshOnInterval !== "function" || input.refreshOnInterval(snapshot));
336
322
- const refreshOnInterval = Effect.fn("ManagedServerProvider.refreshOnInterval")(function* () {
337
+ const refreshOnInterval = Effect.fn("ManagedServerProvider.refreshOnInterval")(function* (
338
+ deferFailure: boolean,
339
+ ) {
340
const { snapshot } = yield* Ref.get(snapshotStateRef);
341
if (!snapshot.enabled) return;
342
if (!needsUsageRecovery(snapshot) || !input.checkUsageLimits) {
343
if (needsProviderRefresh(snapshot)) {
327
- yield* applySnapshotBase(yield* input.getSettings, { forceRefresh: true });
344
+ yield* applySnapshotBase(yield* input.getSettings, { forceRefresh: true, deferFailure });
345
}
346
return;
347
}
@@ -391,10 +408,11 @@ export const makeManagedServerProvider = Effect.fn("makeManagedServerProvider")(
408
).pipe(Effect.forkScoped);
409
410
yield* Effect.forever(
394
- getRefreshInterval.pipe(
395
- Effect.flatMap((refreshInterval) =>
411
+ Effect.all([getRefreshInterval, Ref.getAndSet(recheckPendingRef, false)]).pipe(
412
+ Effect.flatMap(([configuredInterval, recheckPending]) => {
413
+ const refreshInterval = recheckPending ? FAILED_CHECK_RECHECK_DELAY : configuredInterval;
414
// @effect-diagnostics-next-line raceFirstWithSleepToTimeout:off - races the interval against a settings-change signal, not a timeout
397
- Effect.raceFirst(
415
+ return Effect.raceFirst(
416
Effect.sleep(
417
Duration.toMillis(Duration.fromInputUnsafe(refreshInterval)) <= 0
418
? "60 seconds"
@@ -407,14 +425,14 @@ export const makeManagedServerProvider = Effect.fn("makeManagedServerProvider")(
425
? shouldRefreshOnInterval.pipe(
426
Effect.flatMap((shouldRefresh) =>
427
shouldRefresh
410
- ? refreshSemaphore.withPermits(1)(refreshOnInterval())
428
+ ? refreshSemaphore.withPermits(1)(refreshOnInterval(!recheckPending))
429
: Effect.void,
430
),
431
)
432
: Effect.void,
433
),
416
- ),
417
- ),
434
+ );
435
+ }),
436
Effect.ignoreCause({ log: true }),
437
),
438
).pipe(Effect.forkScoped);