@devries-cameron20 / t3code-1 / commits / 9cd337ff9a
Fork 0

The best way to control Claude Code, Codex and more from any computer or phone

fix(mobile): accept image drops in the iOS message input (#25532)

Co-authored-by: maria-rcks <maria@kuuro.net>

12ya committed Nov 9, 2026 at 14:18 UTC 9cd337ff9ac1d57001d3ceb039d742384cefa909
2 files changed +105
apps/mobile/modules/t3-composer-editor/ios/T3ComposerEditorView.swift
+20
@@ -196,6 +196,26 @@ private final class ComposerTextView: UITextView {
196 return super.canPerformAction(action, withSender: sender)
197 }
198
199 + override func canPaste(_ itemProviders: [NSItemProvider]) -> Bool {
200 + guard isEditable, !isReadOnly else { return false }
201 + // UIKit checks canPaste before forwarding a drag to UITextDropDelegate.
202 + if !itemProviders.isEmpty,
203 + itemProviders.allSatisfy({ $0.canLoadObject(ofClass: UIImage.self) }) {
204 + return true
205 + }
206 + return super.canPaste(itemProviders)
207 + }
208 +
209 + override func paste(itemProviders: [NSItemProvider]) {
210 + guard isEditable, !isReadOnly else { return }
211 + if !itemProviders.isEmpty,
212 + itemProviders.allSatisfy({ $0.canLoadObject(ofClass: UIImage.self) }) {
213 + loadImages(from: itemProviders)
214 + return
215 + }
216 + super.paste(itemProviders: itemProviders)
217 + }
218 +
219 override func paste(_ sender: Any?) {
220 guard !isReadOnly else {
221 return
apps/mobile/modules/t3-composer-editor/tests/ios/main.swift
+85
@@ -1,3 +1,4 @@
1 +import UniformTypeIdentifiers
2 import UIKit
3
4 func check(_ passed: Bool, _ message: String) {
@@ -108,3 +109,87 @@ do {
109 }
110
111 print("composer editor tests passed")
112 +
113 +private let dropEditor = ComposerTextView()
114 +private let image = UIGraphicsImageRenderer(size: CGSize(width: 8, height: 8)).image { context in
115 + UIColor.red.setFill()
116 + context.fill(CGRect(x: 0, y: 0, width: 8, height: 8))
117 +}
118 +private let imageProvider = NSItemProvider(object: image)
119 +private let pngProvider = NSItemProvider(item: image.pngData()! as NSData, typeIdentifier: UTType.png.identifier)
120 +private let textProvider = NSItemProvider(object: "plain text" as NSString)
121 +private let fileProvider = NSItemProvider(item: Data("file".utf8) as NSData, typeIdentifier: UTType.data.identifier)
122 +
123 +check(dropEditor.canPaste([imageProvider]), "An image drag must reach the composer's UITextDropDelegate")
124 +check(dropEditor.canPaste([pngProvider]), "A PNG representation must reach the image drop handler")
125 +check(dropEditor.canPaste([imageProvider, pngProvider]), "A multi-image drag must be accepted")
126 +
127 +private let defaultEditor = UITextView()
128 +for providers in [[textProvider], [], [fileProvider], [imageProvider, textProvider], [imageProvider, fileProvider]] {
129 + check(dropEditor.canPaste(providers) == defaultEditor.canPaste(providers), "Non-image-only sessions must retain UIKit behavior")
130 +}
131 +
132 +dropEditor.isReadOnly = true
133 +check(!dropEditor.canPaste([imageProvider]), "A read-only composer must reject image drops")
134 +dropEditor.isReadOnly = false
135 +dropEditor.isEditable = false
136 +check(!dropEditor.canPaste([imageProvider]), "A noneditable composer must reject image drops")
137 +dropEditor.isEditable = true
138 +check(dropEditor.canPaste([imageProvider]), "An unlocked composer must accept image drops again")
139 +print("Composer image-drop eligibility checks passed")
140 +
141 +private final class ImmediateImageProvider: NSItemProvider {
142 + let image: UIImage
143 + private(set) var loadCount = 0
144 +
145 + init(image: UIImage) {
146 + self.image = image
147 + super.init()
148 + registerObject(image, visibility: .all)
149 + }
150 +
151 + override func loadObject(
152 + ofClass aClass: NSItemProviderReading.Type,
153 + completionHandler: @escaping @Sendable (NSItemProviderReading?, Error?) -> Void
154 + ) -> Progress {
155 + loadCount += 1
156 + completionHandler(image, nil)
157 + return Progress(totalUnitCount: 1)
158 + }
159 +}
160 +
161 +private let pasteEditor = ComposerTextView()
162 +private let pasteProvider = ImmediateImageProvider(image: image)
163 +private var pastedImages: [[String]] = []
164 +pasteEditor.text = "Keep this draft"
165 +pasteEditor.onPasteImages = { pastedImages.append($0) }
166 +pasteEditor.paste(itemProviders: [pasteProvider])
167 +
168 +for readOnly in [true, false] {
169 + let lockedEditor = ComposerTextView()
170 + let provider = ImmediateImageProvider(image: image)
171 + lockedEditor.isReadOnly = readOnly
172 + lockedEditor.isEditable = readOnly
173 + lockedEditor.paste(itemProviders: [provider])
174 + check(provider.loadCount == 0, "Locked inputs must not load pasted image providers")
175 +}
176 +
177 +// Inline provider completion places the attachment callback before this main-queue check.
178 +DispatchQueue.main.async {
179 + check(pastedImages.count == 1, "An accepted provider-based paste must emit exactly one attachment batch")
180 + check(pastedImages[0].count == 1, "One pasted image must produce one attachment")
181 + guard let url = URL(string: pastedImages[0][0]),
182 + let data = try? Data(contentsOf: url),
183 + let decoded = UIImage(data: data) else {
184 + check(false, "Provider-based paste must create a readable image file")
185 + return
186 + }
187 + try? FileManager.default.removeItem(at: url)
188 + check(decoded.cgImage?.width == image.cgImage?.width &&
189 + decoded.cgImage?.height == image.cgImage?.height && data == image.pngData(),
190 + "The attachment must contain the pasted image's pixels")
191 + check(pasteEditor.text == "Keep this draft", "Image paste must preserve the draft text")
192 + print("Composer provider-paste checks passed")
193 + exit(0)
194 +}
195 +dispatchMain()