@devries-cameron20 / t3code-1 / commits / a6d2bed55b
Fork 0

The best way to control Claude Code, Codex and more from any computer or phone

fix(provider-acp): a titleless tool_call_update keeps the tool's name (#38989)

Julius Marminge committed Nov 18, 2026 at 23:06 UTC a6d2bed55b8ea1b4be27c9c77fdd65e0e7d479d5
2 files changed +10 -2
packages/provider-acp/src/server/runtimeModel.test.ts
+1
@@ -1376,6 +1376,7 @@ describe("extractMcpToolCallIdentity", () => {
1376 });
1377 const merged = mergeToolCallState(created, completed);
1378
1379 + expect(merged.title).toBe(created.title);
1380 expect(extractMcpToolCallIdentity(merged)).toEqual({
1381 server: "t3-code",
1382 tool: "orchestrator_capabilities",
packages/provider-acp/src/server/runtimeModel.ts
+9 -2
@@ -820,6 +820,8 @@ function canonicalItemTypeFromAcpToolKind(kind: string | undefined): ToolLifecyc
820 }
821 }
822
823 +const TOOL_FALLBACK_SUMMARY = "Tool";
824 +
825 function makeToolCallState(
826 input: {
827 readonly toolCallId: string;
@@ -908,14 +910,19 @@ function makeToolCallState(
910 title,
911 detail: fallbackDetail,
912 data,
911 - fallbackSummary: title ?? "Tool",
913 + fallbackSummary: title ?? TOOL_FALLBACK_SUMMARY,
914 })
915 : undefined;
916 + // A titleless update omits an unchanged title; the generic fallback must not replace it.
917 + const presentationTitle =
918 + title === undefined && presentation?.summary === TOOL_FALLBACK_SUMMARY
919 + ? undefined
920 + : presentation?.summary;
921 const status = normalizeToolCallStatus(input.status, options?.fallbackStatus);
922 return {
923 toolCallId,
924 ...(kind ? { kind } : {}),
918 - ...(presentation?.summary ? { title: presentation.summary } : {}),
925 + ...(presentationTitle ? { title: presentationTitle } : {}),
926 ...(status ? { status } : {}),
927 ...(command ? { command } : {}),
928 ...(presentation?.detail ? { detail: presentation.detail } : {}),