The best way to control Claude Code, Codex and more from any computer or phone
fix(forgejo): dismissed reviews no longer read as requested changes or approvals (#29567)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Alex Southwell committed
Nov 3, 2026 at 01:39 UTC
c3cfb5e1e3d7a788711a0a92a8844dd94b9a35b4
2 files changed
+36
-6
packages/source-control-forgejo/src/server/forgejoPullRequestJson.test.ts
+28
-1
@@ -1,9 +1,15 @@
1
import { assert, describe, it } from "@effect/vitest";
2
import * as Schema from "effect/Schema";
3
4
-import { ForgejoComment, forgejoComment } from "./forgejoPullRequestJson.ts";
4
+import {
5
+ ForgejoComment,
6
+ ForgejoReview,
7
+ forgejoComment,
8
+ forgejoReview,
9
+} from "./forgejoPullRequestJson.ts";
10
11
const decodeForgejoComment = Schema.decodeSync(ForgejoComment);
12
+const decodeForgejoReview = Schema.decodeSync(ForgejoReview);
13
14
describe("forgejoComment", () => {
15
const createdAt = "2026-10-10T19:52:40Z";
@@ -34,3 +40,24 @@ describe("forgejoComment", () => {
40
assert.strictEqual(mapped.editedAt, "2026-10-10T20:04:50.000Z");
41
});
42
});
43
+
44
+describe("forgejoReview", () => {
45
+ it.each([
46
+ ["REQUEST_CHANGES", false, "CHANGES_REQUESTED"],
47
+ ["REQUEST_CHANGES", true, "DISMISSED"],
48
+ ["APPROVED", true, "DISMISSED"],
49
+ ])("reads %s with dismissed %s as %s", (state, dismissed, reviewState) => {
50
+ const mapped = forgejoReview(
51
+ decodeForgejoReview({
52
+ id: 8,
53
+ body: "",
54
+ user: { login: "maria" },
55
+ state,
56
+ dismissed,
57
+ submitted_at: "2026-10-10T19:52:40Z",
58
+ comments_count: 0,
59
+ }),
60
+ );
61
+ assert.strictEqual(mapped.reviewState, reviewState);
62
+ });
63
+});
packages/source-control-forgejo/src/server/forgejoPullRequestJson.ts
+8
-5
@@ -77,6 +77,7 @@ export const ForgejoReview = Schema.Struct({
77
body: Schema.String,
78
user: Schema.NullOr(ForgejoUser),
79
state: Schema.String,
80
+ dismissed: Schema.optional(Schema.Boolean),
81
submitted_at: Schema.String,
82
html_url: Schema.optional(Schema.String),
83
comments_count: Schema.Int,
@@ -173,11 +174,13 @@ export function forgejoReview(review: typeof ForgejoReview.Type): PullRequestCom
174
url: review.html_url || null,
175
path: null,
176
reviewState:
176
- review.state === "REQUEST_CHANGES"
177
- ? "CHANGES_REQUESTED"
178
- : review.state === "COMMENT"
179
- ? "COMMENTED"
180
- : review.state,
177
+ review.dismissed === true
178
+ ? "DISMISSED"
179
+ : review.state === "REQUEST_CHANGES"
180
+ ? "CHANGES_REQUESTED"
181
+ : review.state === "COMMENT"
182
+ ? "COMMENTED"
183
+ : review.state,
184
};
185
}
186