The best way to control Claude Code, Codex and more from any computer or phone
fix(server): empty MCP status filters no longer hide threads (#25306)
Co-authored-by: GPT-6.1 Sol <noreply@openai.com> Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>
Victor Vogel committed
Oct 30, 2026 at 16:28 UTC
c6ef3b46ebed34fbefa1706674fe5748254cee18
2 files changed
+58
-1
apps/server/src/mcp/OrchestratorMcpService.ts
+5
-1
@@ -2807,7 +2807,11 @@ const make = Effect.gen(function* () {
2807
),
2808
);
2809
const nowMs = yield* Clock.currentTimeMillis;
2810
- const statuses = input.statuses === undefined ? null : new Set(input.statuses);
2810
+ // An empty list is no filter: clients that fill every optional field send `[]`.
2811
+ const statuses =
2812
+ input.statuses === undefined || input.statuses.length === 0
2813
+ ? null
2814
+ : new Set(input.statuses);
2815
const titleContains = input.titleContains?.toLocaleLowerCase();
2816
const filtered = projectThreads
2817
.filter(
apps/server/src/mcp/toolkits/core.test.ts
+53
@@ -955,3 +955,56 @@ it.effect("only the caller that prepared a pending upload can discard it", () =>
955
),
956
),
957
);
958
+
959
+it.effect(
960
+ "t3_thread_list settled:false with an empty statuses list lists the unsettled threads",
961
+ () => {
962
+ const unsettled = McpToolAccessTestkit.liveThreadShell(ThreadId.make("unsettled-thread"));
963
+ const settled = {
964
+ ...McpToolAccessTestkit.liveThreadShell(ThreadId.make("settled-thread")),
965
+ settledOverride: "settled",
966
+ } as const;
967
+ return Effect.gen(function* () {
968
+ const server = yield* McpServer.McpServer;
969
+ const result = yield* server
970
+ .callTool({
971
+ name: "t3_thread_list",
972
+ arguments: { projectId: unsettled.projectId, settled: false, statuses: [] },
973
+ })
974
+ .pipe(
975
+ Effect.provideService(
976
+ McpInvocationContext.McpInvocationContext,
977
+ clientScope("full-access"),
978
+ ),
979
+ Effect.provideService(McpSchema.McpServerClient, client),
980
+ );
981
+ expect(result.isError).toBe(false);
982
+ expect(result.structuredContent).toMatchObject({
983
+ threads: [{ threadId: unsettled.id, settled: false }],
984
+ total: 1,
985
+ });
986
+ }).pipe(
987
+ Effect.provide(
988
+ layerOrchestratorToolkit.pipe(
989
+ Layer.provideMerge(McpServer.McpServer.layer),
990
+ Layer.provide(NodeCrypto.layer),
991
+ Layer.provide(
992
+ Layer.mock(ThreadManagement.ThreadManagementService)({
993
+ listProjectThreads: () => Effect.succeed([unsettled, settled]),
994
+ }),
995
+ ),
996
+ Layer.provide(ServerSettings.layerTest()),
997
+ Layer.provide(Layer.mock(ProviderRegistry.ProviderRegistry)({})),
998
+ Layer.provide(Layer.mock(ProviderAdapterRegistry.ProviderAdapterRegistryV2)({})),
999
+ Layer.provide(Layer.mock(ScheduledTaskService.ScheduledTaskService)({})),
1000
+ Layer.provide(Layer.mock(ProjectService.ProjectService)({})),
1001
+ Layer.provide(Layer.mock(SecretRequests.SecretRequests)({})),
1002
+ Layer.provide(Layer.mock(PeerForwarding.PeerForwarding)({})),
1003
+ Layer.provide(Layer.mock(PeerLinkRequests.PeerLinkRequests)({})),
1004
+ Layer.provide(Layer.mock(PeerLinks.PeerLinks)({})),
1005
+ Layer.provide(Layer.mock(RemoteDelegation.RemoteDelegation)({})),
1006
+ ),
1007
+ ),
1008
+ );
1009
+ },
1010
+);