The best way to control Claude Code, Codex and more from any computer or phone
fix(web): screen readers read the Update everything machine list as a table (#36445)
Julius Marminge committed
Nov 13, 2026 at 16:52 UTC
cbf0f0a83f2e107f0859c37b02cbbe32debe92d6
2 files changed
+48
-13
apps/web/src/components/sidebar/SidebarUpdatePill.browser.test.tsx
+29
-2
@@ -5,12 +5,14 @@ import { page, userEvent } from "vite-plus/test/browser";
5
import "~/index.css";
6
import { act, render } from "../../../test/render";
7
import { SidebarUpdatePill } from "./SidebarUpdatePill";
8
+import type { UpdateEverythingRow } from "./updateEverything.logic";
9
10
const mocks = vi.hoisted(() => {
11
const listeners = new Set<() => void>();
12
return {
13
update: null as DesktopUpdateState | null,
14
hasUpdates: false,
15
+ rows: [] as ReadonlyArray<UpdateEverythingRow>,
16
subscribe: (listener: () => void) => {
17
listeners.add(listener);
18
return () => listeners.delete(listener);
@@ -39,7 +41,7 @@ vi.mock("./useUpdateEverything", () => ({
41
summary: "Update everything",
42
version: null,
43
providerCount: 0,
42
- rows: [],
44
+ rows: mocks.rows,
45
restarts: [],
46
}),
47
}));
@@ -69,9 +71,16 @@ const RELEASE_NOTES: DesktopUpdateState["releaseNotes"] = [
71
{ version: "0.0.50-nightly.2", items: ["Faster sidebar."], totalItems: 1 },
72
];
73
72
-function setup(update: DesktopUpdateState | null, { hasUpdates = false } = {}) {
74
+function setup(
75
+ update: DesktopUpdateState | null,
76
+ {
77
+ hasUpdates = false,
78
+ rows = [],
79
+ }: { hasUpdates?: boolean; rows?: ReadonlyArray<UpdateEverythingRow> } = {},
80
+) {
81
mocks.update = update;
82
mocks.hasUpdates = hasUpdates;
83
+ mocks.rows = rows;
84
}
85
86
function publish(update: DesktopUpdateState | null) {
@@ -140,4 +149,22 @@ describe("SidebarUpdatePill update everything", () => {
149
await userEvent.keyboard("{Escape}");
150
await vi.waitFor(() => expect(document.activeElement).toBe(button.element()));
151
});
152
+
153
+ it("exposes the machines as a table with each value in its column", async () => {
154
+ const label = "DESKTOP-WORKSTATION-UPSTAIRS";
155
+ setup(null, {
156
+ hasUpdates: true,
157
+ rows: [{ environmentId: null, label, app: "this-app", skipped: null, providers: ["Claude"] }],
158
+ });
159
+ await using screen = await render(<SidebarUpdatePill />);
160
+ await userEvent.click(screen.getByRole("button", { name: "Update everything" }));
161
+
162
+ const table = page.getByRole("table");
163
+ await expect.element(table.getByRole("columnheader", { name: "Machine" })).toBeVisible();
164
+ await expect.element(table.getByRole("columnheader", { name: "T3 Code" })).toBeVisible();
165
+ await expect.element(table.getByRole("columnheader", { name: "Providers" })).toBeVisible();
166
+ const row = table.getByRole("row", { name: new RegExp(label) });
167
+ await expect.element(row.getByRole("cell", { name: label, exact: true })).toBeVisible();
168
+ await expect.element(row.getByRole("cell", { name: "Claude", exact: true })).toBeVisible();
169
+ });
170
});
apps/web/src/components/sidebar/UpdateEverythingDialog.tsx
+19
-11
@@ -157,22 +157,30 @@ function UpdateEverythingDialogContent({
157
</p>
158
))}
159
{/* Machine names truncate first. Provider lists wrap between names, never inside one. */}
160
- <div className="grid grid-cols-[minmax(4rem,max-content)_max-content_minmax(min-content,1fr)_max-content] gap-x-4 text-sm">
161
- <div className="col-span-full grid grid-cols-subgrid border-b pb-1.5 text-muted-foreground text-xs">
162
- <span>Machine</span>
163
- <span>T3 Code</span>
164
- <span>Providers</span>
165
- <span />
160
+ <div
161
+ role="table"
162
+ className="grid grid-cols-[minmax(4rem,max-content)_max-content_minmax(min-content,1fr)_max-content] gap-x-4 text-sm"
163
+ >
164
+ <div
165
+ role="row"
166
+ className="col-span-full grid grid-cols-subgrid border-b pb-1.5 text-muted-foreground text-xs"
167
+ >
168
+ <span role="columnheader">Machine</span>
169
+ <span role="columnheader">T3 Code</span>
170
+ <span role="columnheader">Providers</span>
171
+ <span role="columnheader" />
172
</div>
173
{updating.map((row) => (
174
<div
175
key={row.environmentId ?? "this-app"}
176
+ role="row"
177
className="col-span-full grid grid-cols-subgrid border-b border-border/50 py-1.5 last:border-b-0"
178
>
172
- <span className="max-w-32 min-w-0">
173
- <MiddleTruncate value={row.label} />
179
+ <span role="cell" className="max-w-32 min-w-0">
180
+ <span className="sr-only">{row.label}</span>
181
+ <MiddleTruncate value={row.label} aria-hidden />
182
</span>
175
- <span>
183
+ <span role="cell">
184
{row.app !== null ? APP_LABELS[row.app] : null}
185
{row.app === null && row.skipped !== null ? (
186
<span className="text-muted-foreground">Skipped</span>
@@ -181,7 +189,7 @@ function UpdateEverythingDialogContent({
189
<span className="block text-muted-foreground text-xs">restarts last</span>
190
) : null}
191
</span>
184
- <span>
192
+ <span role="cell">
193
{row.providers.map((provider, index) => (
194
<Fragment key={provider}>
195
<span className="whitespace-nowrap">{provider}</span>
@@ -189,7 +197,7 @@ function UpdateEverythingDialogContent({
197
</Fragment>
198
))}
199
</span>
192
- <span className="text-right">
200
+ <span role="cell" className="text-right">
201
{row.environmentId !== null && restarting.has(row.environmentId) ? (
202
<RunningThreads environmentId={row.environmentId} />
203
) : null}