The best way to control Claude Code, Codex and more from any computer or phone
fix(web): imported theme files keep their top-level canvas and accent (#37982)
Julius Marminge committed
Nov 16, 2026 at 23:38 UTC
cd9c39fe3c25ad71657cc0b8631b6de76775261e
2 files changed
+30
-1
apps/web/src/themePalette.test.ts
+15
@@ -106,6 +106,21 @@ describe("theme files", () => {
106
}
107
});
108
109
+ it("derives an imported palette from top-level canvas and accent like a published theme", () => {
110
+ const theme = parseThemeFile({
111
+ version: THEME_FILE_VERSION,
112
+ name: "Teal",
113
+ appearance: "dark",
114
+ canvas: "#0b1a1e",
115
+ accent: "#f08a2c",
116
+ colors: { sidebar: "#0f2126" },
117
+ });
118
+
119
+ expect(theme.colors.canvas).toBe(canonical("#0b1a1e"));
120
+ expect(theme.colors.accent).toBe(canonical("#f08a2c"));
121
+ expect(theme.colors.sidebar).toBe(canonical("#0f2126"));
122
+ });
123
+
124
it("round-trips custom search colours and fills them in for older theme files", () => {
125
const legacy = parseThemeFile({
126
version: THEME_FILE_VERSION,
apps/web/src/themePalette.ts
+15
-1
@@ -1501,6 +1501,13 @@ function parseThemeColorOverrides(value: unknown): ThemeColorOverrides {
1501
return overrides;
1502
}
1503
1504
+function parseThemeSeedColor(name: string, value: unknown): string {
1505
+ if (typeof value !== "string" || !toCanonicalThemeColor(value)) {
1506
+ throw new Error(`The theme's "${name}" must be a literal CSS color.`);
1507
+ }
1508
+ return value;
1509
+}
1510
+
1511
export function parseThemeFile(value: unknown): ThemeDefinition {
1512
if (!isRecord(value)) {
1513
throw new Error("Theme files must contain a JSON object.");
@@ -1536,7 +1543,14 @@ export function parseThemeFile(value: unknown): ThemeDefinition {
1543
throw new Error(`Theme CSS must be text of ${THEME_CSS_MAX_LENGTH} characters or fewer.`);
1544
}
1545
1539
- const fallback = getDefaultThemeColors(appearance);
1546
+ const fallback =
1547
+ value.canvas !== undefined && value.accent !== undefined
1548
+ ? createVividThemeColors(
1549
+ appearance,
1550
+ parseThemeSeedColor("canvas", value.canvas),
1551
+ parseThemeSeedColor("accent", value.accent),
1552
+ )
1553
+ : getDefaultThemeColors(appearance);
1554
const variants: Partial<Record<ThemeAppearance, ThemeColors>> = {};
1555
if (value.variants !== undefined) {
1556
if (!isRecord(value.variants)) throw new Error("Theme variants must be an object.");