The best way to control Claude Code, Codex and more from any computer or phone
fix(web): the provider update pill no longer recounts dismissed updates (#39636)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Tuomas Seppänen committed
Nov 20, 2026 at 12:50 UTC
d5a084c440ccf0e7c5901cff73b1f2e028f27913
3 files changed
+78
-31
apps/web/src/components/ProviderUpdateLaunchNotification.logic.test.ts
+53
@@ -274,6 +274,59 @@ describe("provider update launch notification logic", () => {
274
title: "Claude v1.1.0 update failed",
275
});
276
});
277
+
278
+ it("does not count an already dismissed success again when another provider updates", () => {
279
+ const claudeUpdated = provider({
280
+ driver: driver("claudeAgent"),
281
+ version: "1.1.0",
282
+ latestVersion: "1.1.0",
283
+ advisoryStatus: "current",
284
+ updateState: {
285
+ status: "succeeded",
286
+ startedAt: checkedAt,
287
+ finishedAt: checkedAt,
288
+ message: "Provider updated.",
289
+ output: null,
290
+ },
291
+ });
292
+ const claudeView = getProviderUpdateSidebarPillView([claudeUpdated], {
293
+ visibleAfterIso: sessionStartedAt,
294
+ });
295
+ expect(claudeView).toMatchObject({ title: "Claude updated: v1.1.0" });
296
+
297
+ const bothUpdated = [
298
+ claudeUpdated,
299
+ provider({
300
+ driver: driver("codex"),
301
+ version: "1.2.0",
302
+ latestVersion: "1.2.0",
303
+ advisoryStatus: "current",
304
+ updateState: {
305
+ status: "succeeded",
306
+ startedAt: laterCheckedAt,
307
+ finishedAt: laterCheckedAt,
308
+ message: "Provider updated.",
309
+ output: null,
310
+ },
311
+ }),
312
+ ];
313
+ const codexView = getProviderUpdateSidebarPillView(bothUpdated, {
314
+ visibleAfterIso: sessionStartedAt,
315
+ dismissedKeys: new Set(claudeView?.dismissKeys),
316
+ });
317
+ expect(codexView).toMatchObject({ tone: "success", title: "Codex updated: v1.2.0" });
318
+
319
+ const groupedView = getProviderUpdateSidebarPillView(bothUpdated, {
320
+ visibleAfterIso: sessionStartedAt,
321
+ });
322
+ expect(groupedView).toMatchObject({ title: "2 providers updated" });
323
+ expect(
324
+ getProviderUpdateSidebarPillView(bothUpdated, {
325
+ visibleAfterIso: sessionStartedAt,
326
+ dismissedKeys: new Set(groupedView?.dismissKeys),
327
+ }),
328
+ ).toBeNull();
329
+ });
330
});
331
332
it("does not offer incompatible latest versions and restores suggestions after policy relaxation", () => {
apps/web/src/components/ProviderUpdateLaunchNotification.logic.ts
+15
-23
@@ -39,6 +39,7 @@ export interface ProviderUpdateSidebarPillView {
39
readonly description: string;
40
readonly dismissible?: boolean;
41
readonly dismissAfterVisibleMs?: number;
42
+ readonly dismissKeys?: ReadonlyArray<string>;
43
}
44
45
interface ProviderUpdateSidebarPillOptions {
@@ -355,6 +356,15 @@ function latestFinishedAtForProviders(providers: ReadonlyArray<ServerProvider>):
356
}, null);
357
}
358
359
+function terminalUpdateKey(provider: ServerProvider): string {
360
+ return `${provider.updateState?.status}:${provider.driver}:${provider.updateState?.finishedAt ?? "pending"}:${provider.updateState?.message ?? ""}`;
361
+}
362
+
363
+function terminalPillIdentity(providers: ReadonlyArray<ServerProvider>) {
364
+ const dismissKeys = providers.map(terminalUpdateKey).toSorted();
365
+ return { key: dismissKeys.join("|"), dismissKeys };
366
+}
367
+
368
/** Use each driver's latest finished instance so an older default-instance result cannot hide it. */
369
function latestTerminalProvidersByDriver(providers: ReadonlyArray<ServerProvider>) {
370
const latestProviderByDriver = new Map<ProviderDriverKind, ServerProvider>();
@@ -412,7 +422,7 @@ export function getProviderUpdateSidebarPillView(
422
423
const recentTerminalProviders = latestTerminalProvidersByDriver(
424
providers.filter((provider) => isRecentTerminalProvider(provider, options?.visibleAfterIso)),
415
- );
425
+ ).filter((provider) => !options?.dismissedKeys?.has(terminalUpdateKey(provider)));
426
const terminalCandidates: ProviderUpdateSidebarPillView[] = [];
427
428
const failedProviders = recentTerminalProviders.filter(
@@ -421,13 +431,7 @@ export function getProviderUpdateSidebarPillView(
431
if (failedProviders.length > 0) {
432
const failedProvider = failedProviders[0]!;
433
terminalCandidates.push({
424
- key: `failed:${failedProviders
425
- .map(
426
- (provider) =>
427
- `${provider.driver}:${provider.updateState?.finishedAt ?? "pending"}:${provider.updateState?.message ?? ""}`,
428
- )
429
- .toSorted()
430
- .join("|")}`,
434
+ ...terminalPillIdentity(failedProviders),
435
tone: "error",
436
title:
437
failedProviders.length === 1
@@ -451,13 +455,7 @@ export function getProviderUpdateSidebarPillView(
455
const unchangedProviderName =
456
PROVIDER_DISPLAY_NAMES[unchangedProvider.driver] ?? unchangedProvider.driver;
457
terminalCandidates.push({
454
- key: `unchanged:${unchangedProviders
455
- .map(
456
- (provider) =>
457
- `${provider.driver}:${provider.updateState?.finishedAt ?? "pending"}:${provider.updateState?.message ?? ""}`,
458
- )
459
- .toSorted()
460
- .join("|")}`,
458
+ ...terminalPillIdentity(unchangedProviders),
459
tone: "warning",
460
title:
461
unchangedProviders.length === 1
@@ -490,13 +488,7 @@ export function getProviderUpdateSidebarPillView(
488
if (succeededProviders.length > 0) {
489
const succeededProvider = succeededProviders[0]!;
490
terminalCandidates.push({
493
- key: `succeeded:${succeededProviders
494
- .map(
495
- (provider) =>
496
- `${provider.driver}:${provider.updateState?.finishedAt ?? "pending"}:${provider.updateState?.message ?? ""}`,
497
- )
498
- .toSorted()
499
- .join("|")}`,
491
+ ...terminalPillIdentity(succeededProviders),
492
tone: "success",
493
title:
494
succeededProviders.length === 1
@@ -533,7 +525,7 @@ export function getProviderUpdateSidebarPillView(
525
const rightFinishedAt = latestFinishedAtForProviders(rightProviders) ?? "";
526
return rightFinishedAt.localeCompare(leftFinishedAt);
527
})
536
- .find((candidate) => !options?.dismissedKeys?.has(candidate.key)) ?? null
528
+ .at(0) ?? null
529
);
530
}
531
apps/web/src/components/sidebar/SidebarProviderUpdatePill.tsx
+10
-8
@@ -52,7 +52,7 @@ export function SidebarProviderUpdatePill() {
52
const [renderedView, setRenderedView] = useState<ProviderUpdateSidebarPillView | null>(null);
53
const [pendingView, setPendingView] = useState<ProviderUpdateSidebarPillView | null>(null);
54
const [exitingKey, setExitingKey] = useState<string | null>(null);
55
- const [dismissAfterExitKey, setDismissAfterExitKey] = useState<string | null>(null);
55
+ const [dismissAfterExitKeys, setDismissAfterExitKeys] = useState<ReadonlyArray<string>>([]);
56
const [visibleAfterIso, setVisibleAfterIso] = useState<string | undefined>();
57
const effectiveVisibleAfterIso = visibleAfterIso ?? latestProviderCheckedAt(providers);
58
const view = getProviderUpdateSidebarPillView(
@@ -84,14 +84,14 @@ export function SidebarProviderUpdatePill() {
84
const startExit = (
85
key: string,
86
nextView: ProviderUpdateSidebarPillView | null,
87
- dismissKey?: string,
87
+ dismissKeys: ReadonlyArray<string> = [],
88
) => {
89
if (exitingKey === key) {
90
return;
91
}
92
setPendingView(nextView);
93
setExitingKey(key);
94
- setDismissAfterExitKey(dismissKey ?? null);
94
+ setDismissAfterExitKeys(dismissKeys);
95
};
96
97
if (exitingKey === null) {
@@ -106,16 +106,18 @@ export function SidebarProviderUpdatePill() {
106
}
107
}
108
109
- const exitAfterVisible = useEffectEvent((key: string) => startExit(key, null, key));
109
+ const exitAfterVisible = useEffectEvent((key: string) =>
110
+ startExit(key, null, displayedView?.dismissKeys),
111
+ );
112
113
const finishExit = useEffectEvent(() => {
112
- if (dismissAfterExitKey !== null) {
113
- setDismissedKeys((previous) => new Set(previous).add(dismissAfterExitKey));
114
+ if (dismissAfterExitKeys.length > 0) {
115
+ setDismissedKeys((previous) => new Set([...previous, ...dismissAfterExitKeys]));
116
}
117
setRenderedView(pendingView);
118
setPendingView(null);
119
setExitingKey(null);
118
- setDismissAfterExitKey(null);
120
+ setDismissAfterExitKeys([]);
121
});
122
123
// oxlint-disable-next-line t3code/no-unreasoned-state-sync -- fallback timer that finishes the exit if the CSS transition never ends
@@ -203,7 +205,7 @@ export function SidebarProviderUpdatePill() {
205
type="button"
206
aria-label={gt("Dismiss provider update notice")}
207
className="relative z-[1] mr-1 flex size-5 shrink-0 cursor-pointer items-center justify-center rounded-md opacity-70 outline-none hover:opacity-100 focus-visible:opacity-100 focus-visible:ring-2 focus-visible:ring-inset focus-visible:ring-ring"
206
- onClick={() => startExit(displayedView.key, null, displayedView.key)}
208
+ onClick={() => startExit(displayedView.key, null, displayedView.dismissKeys)}
209
>
210
<XIcon className="size-3.5 shrink-0" />
211
</button>