@devries-cameron20 / t3code-1 / commits / e83021c921
Fork 0

The best way to control Claude Code, Codex and more from any computer or phone

fix(desktop): LAN pairing links follow the current network address (#24474)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

Victor Vogel committed Oct 30, 2026 at 16:06 UTC e83021c921ae76a53b327980ff6ebc4d6d14702d
2 files changed +64 -2
apps/desktop/src/backend/DesktopServerExposure.test.ts
+28
@@ -238,6 +238,34 @@ describe("DesktopServerExposure", () => {
238 ),
239 );
240
241 + it.effect("advertises the current LAN address after the network changes", () => {
242 + const networkInterfaces: Record<
243 + string,
244 + readonly DesktopNetworkInterfaces.DesktopNetworkInterfaceInfo[] | undefined
245 + > = { ...lanNetworkInterfaces };
246 +
247 + return withHarness(
248 + networkInterfaces,
249 + Effect.gen(function* () {
250 + const serverExposure = yield* DesktopServerExposure.DesktopServerExposure;
251 + yield* serverExposure.configureFromSettings({ port: 4173 });
252 + yield* serverExposure.setMode("network-accessible");
253 +
254 + networkInterfaces.en0 = [{ address: "10.0.0.5", family: "IPv4", internal: false }];
255 +
256 + const state = yield* serverExposure.getState;
257 + assert.equal(state.advertisedHost, "10.0.0.5");
258 + assert.equal(state.endpointUrl, "http://10.0.0.5:4173");
259 + const endpoints = yield* serverExposure.getAdvertisedEndpoints;
260 + assert.deepEqual(
261 + endpoints.map((endpoint) => endpoint.httpBaseUrl),
262 + ["http://127.0.0.1:4173/", "http://10.0.0.5:4173/"],
263 + );
264 + assert.equal((yield* serverExposure.backendConfig).bindHost, "0.0.0.0");
265 + }),
266 + );
267 + });
268 +
269 it.effect("persists tailscale serve preferences atomically and reports no-op updates", () =>
270 withHarness(
271 emptyNetworkInterfaces,
apps/desktop/src/backend/DesktopServerExposure.ts
+36 -2
@@ -409,6 +409,30 @@ function resolveRuntimeState(input: {
409 };
410 }
411
412 +// A network-accessible backend binds every interface, so a new Wi-Fi network
413 +// or DHCP lease changes only the address worth advertising, not the binding.
414 +const withCurrentAdvertisedHost = (
415 + state: RuntimeState,
416 + networkInterfaces: DesktopNetworkInterfaces.NetworkInterfaces,
417 + advertisedHostOverride: Option.Option<string>,
418 +): RuntimeState => {
419 + if (state.mode !== "network-accessible") {
420 + return state;
421 + }
422 + const override = Option.getOrUndefined(advertisedHostOverride);
423 + const exposure = resolveDesktopServerExposure({
424 + mode: state.mode,
425 + port: state.port,
426 + networkInterfaces,
427 + ...(override ? { advertisedHostOverride: override } : {}),
428 + });
429 + return {
430 + ...state,
431 + endpointUrl: Option.fromNullishOr(exposure.endpointUrl),
432 + advertisedHost: Option.fromNullishOr(exposure.advertisedHost),
433 + };
434 +};
435 +
436 const tailscaleIpv4AddressKey = (
437 networkInterfaces: DesktopNetworkInterfaces.NetworkInterfaces,
438 ): string =>
@@ -458,7 +482,17 @@ export const make = Effect.gen(function* () {
482
483 const readNetworkInterfaces = networkInterfaces.read;
484
461 - const getState = Ref.get(stateRef).pipe(Effect.map(toContractState));
485 + const readCurrentState = (currentNetworkInterfaces: DesktopNetworkInterfaces.NetworkInterfaces) =>
486 + Ref.get(stateRef).pipe(
487 + Effect.map((state) =>
488 + withCurrentAdvertisedHost(state, currentNetworkInterfaces, config.desktopLanHostOverride),
489 + ),
490 + );
491 +
492 + const getState = readNetworkInterfaces.pipe(
493 + Effect.flatMap(readCurrentState),
494 + Effect.map(toContractState),
495 + );
496 const backendConfig = Ref.get(stateRef).pipe(Effect.map(toBackendConfig));
497
498 const configureFromSettings = Effect.fn("desktop.serverExposure.configureFromSettings")(
@@ -555,8 +589,8 @@ export const make = Effect.gen(function* () {
589 );
590
591 const getAdvertisedEndpoints = Effect.gen(function* () {
558 - const state = yield* Ref.get(stateRef);
592 const currentNetworkInterfaces = yield* readNetworkInterfaces;
593 + const state = yield* readCurrentState(currentNetworkInterfaces);
594 const coreEndpoints = resolveDesktopCoreAdvertisedEndpoints({
595 port: state.port,
596 exposure: toResolvedExposure(state),