The best way to control Claude Code, Codex and more from any computer or phone
fix(web): keep newer titles when an untouched header rename ends (#23171)
Co-authored-by: GPT-6.1 Sol <noreply@openai.com>
Victor Vogel committed
Oct 31, 2026 at 21:26 UTC
f9dd7216c0f81904adde0ce6fc6d338ea0342fd8
2 files changed
+77
-1
apps/web/src/components/chat/ChatHeader.browser.test.tsx
new
+73
@@ -0,0 +1,73 @@
1
+import { EnvironmentId, ThreadId } from "@t3tools/contracts";
2
+import { expect, it, vi } from "vite-plus/test";
3
+import { userEvent } from "vite-plus/test/browser";
4
+
5
+const persisted = vi.hoisted(() => ({ title: "" }));
6
+vi.mock(import("../../state/session"), async (importOriginal) => ({
7
+ ...(await importOriginal()),
8
+ useEnvironmentScope: () => true,
9
+ readEnvironmentScope: () => true,
10
+}));
11
+vi.mock(import("../../state/use-orchestration-command"), async (importOriginal) => ({
12
+ ...(await importOriginal()),
13
+ useOrchestrationCommand: (() =>
14
+ async ({ input }: { input: { title: string } }) => {
15
+ persisted.title = input.title;
16
+ return { _tag: "Success" };
17
+ }) as never,
18
+}));
19
+vi.mock(import("~/hooks/useThreadActionMenu"), () => ({
20
+ useThreadActionMenu: () => ({ openMenu: () => {}, closeMenu: () => {} }),
21
+}));
22
+
23
+import { render } from "../../../test/render";
24
+import { ChatHeader } from "./ChatHeader";
25
+
26
+function header(title: string) {
27
+ return (
28
+ <>
29
+ <ChatHeader
30
+ activeThreadEnvironmentId={EnvironmentId.make("environment")}
31
+ activeThreadId={ThreadId.make("thread")}
32
+ activeThreadTitle={title}
33
+ isServerThread
34
+ activeProject={null}
35
+ parentThreadLink={null}
36
+ onOpenThread={() => {}}
37
+ rightPanelOpen={false}
38
+ onNewThreadInProject={() => {}}
39
+ />
40
+ <div tabIndex={0}>Outside rename</div>
41
+ </>
42
+ );
43
+}
44
+
45
+it.each(["blur", "Enter"] as const)(
46
+ "preserves a concurrent title update when an untouched rename ends with %s",
47
+ async (finish) => {
48
+ persisted.title = "New thread";
49
+ await using screen = await render(header(persisted.title));
50
+ await screen.getByRole("button", { name: "Thread actions for New thread" }).dblClick();
51
+ const input = screen.getByRole("textbox", { name: "Thread title" });
52
+ await expect.element(input).toHaveValue("New thread");
53
+
54
+ persisted.title = "Fix login redirect";
55
+ await screen.rerender(header(persisted.title));
56
+ if (finish === "Enter") await userEvent.keyboard("{Enter}");
57
+ else await screen.getByText("Outside rename").click();
58
+
59
+ await expect.element(input).not.toBeInTheDocument();
60
+ expect(persisted.title).toBe("Fix login redirect");
61
+
62
+ await screen.rerender(header(persisted.title));
63
+ await screen.getByRole("button", { name: "Thread actions for Fix login redirect" }).dblClick();
64
+ await screen.getByRole("textbox", { name: "Thread title" }).fill("My edited title");
65
+ persisted.title = "Another concurrent title";
66
+ await screen.rerender(header(persisted.title));
67
+ await userEvent.keyboard("{Enter}");
68
+ await expect
69
+ .element(screen.getByRole("textbox", { name: "Thread title" }))
70
+ .not.toBeInTheDocument();
71
+ expect(persisted.title).toBe("My edited title");
72
+ },
73
+);
apps/web/src/components/chat/ChatHeader.tsx
+4
-1
@@ -175,7 +175,10 @@ export const ChatHeader = memo(function ChatHeader({
175
const commitRename = (title: string) => {
176
setRenaming(null);
177
if (!readEnvironmentScope(activeThreadEnvironmentId, AuthOrchestrationOperateScope)) return;
178
- const resolution = resolveRenameCommit({ title, originalTitle: activeThreadTitle });
178
+ const resolution = resolveRenameCommit({
179
+ title,
180
+ originalTitle: renamingTitle ?? activeThreadTitle,
181
+ });
182
if (resolution.action === "reject-empty") {
183
toastManager.add({ type: "warning", title: "Thread title cannot be empty" });
184
return;