The best way to control Claude Code, Codex and more from any computer or phone
feat(web): mark PR files viewed with shift-click (#26349)
Yash Singh committed
Oct 28, 2026 at 02:56 UTC
ff424802edd1560fd99fe163e678b67ec09f69b3
3 files changed
+53
-5
apps/web/src/components/pullRequest/PullRequestCodeTab.tsx
+24
-5
@@ -106,6 +106,7 @@ import {
106
toViewerSide,
107
} from "./PullRequestReviewAnnotation";
108
import {
109
+ getFileViewedRange,
110
isFileDiffCollapsed,
111
isLineInFileDiff,
112
toggleFileDiffFoldForViewed,
@@ -175,7 +176,7 @@ interface FileViewedToggleState {
176
readonly enabled: boolean;
177
readonly isViewed: (path: string) => boolean;
178
readonly isStale: (path: string) => boolean;
178
- readonly setFileViewed: (fileKey: string, path: string, viewed: boolean) => void;
179
+ readonly setFileViewed: (fileKey: string, viewed: boolean, extendRange: boolean) => void;
180
}
181
182
// Context updates viewed toggles without invalidating memoized header portals.
@@ -205,7 +206,13 @@ function FileViewedToggle({
206
<Checkbox
207
aria-label={stale ? "Changed" : "Viewed"}
208
checked={viewed}
208
- onCheckedChange={(next) => viewedFiles.setFileViewed(fileKey, path, next === true)}
209
+ onCheckedChange={(next, details) =>
210
+ viewedFiles.setFileViewed(
211
+ fileKey,
212
+ next === true,
213
+ "shiftKey" in details.event && details.event.shiftKey === true,
214
+ )
215
+ }
216
/>
217
{stale ? (
218
<Tooltip>
@@ -287,6 +294,7 @@ function PullRequestCodeTab({
294
wordWrap: settings.wordWrap,
295
}));
296
const [toggledFiles, setToggledFiles] = useState<ReadonlySet<string>>(() => new Set());
297
+ const [lastViewedFileKey, setLastViewedFileKey] = useState<string | null>(null);
298
const [visibleCommitCount, setVisibleCommitCount] = useState(COMMIT_PAGE_SIZE);
299
const [foldOverride, setFoldOverride] = useState<DiffFoldOverride>(null);
300
const effectiveFoldOverride =
@@ -326,6 +334,7 @@ function PullRequestCodeTab({
334
const [stateScopeKey, setStateScopeKey] = useState(scopeKey);
335
if (stateScopeKey !== scopeKey) {
336
setStateScopeKey(scopeKey);
337
+ setLastViewedFileKey(null);
338
setDraft(null);
339
setSelectedLines(null);
340
setToggledFiles(new Set());
@@ -689,10 +698,20 @@ function PullRequestCodeTab({
698
return next;
699
});
700
692
- const setFileViewed = (fileKey: string, path: string, viewed: boolean) => {
693
- setViewed(path, viewed);
701
+ const setFileViewed = (fileKey: string, viewed: boolean, extendRange: boolean) => {
702
+ const range = getFileViewedRange(
703
+ annotatedFiles,
704
+ fileKey,
705
+ extendRange ? lastViewedFileKey : null,
706
+ );
707
+ setLastViewedFileKey(fileKey);
708
+ for (const file of range) setViewed(file.path, viewed);
709
setToggledFiles((current) =>
695
- toggleFileDiffFoldForViewed(fileKey, viewed, effectiveFoldOverride, current),
710
+ range.reduce(
711
+ (next, file) =>
712
+ toggleFileDiffFoldForViewed(file.fileKey, viewed, effectiveFoldOverride, next),
713
+ current,
714
+ ),
715
);
716
};
717
const fileViewedToggle = {
apps/web/src/components/pullRequest/pullRequestDiff.logic.test.ts
+17
@@ -2,6 +2,7 @@ import type { FileDiffMetadata } from "@pierre/diffs";
2
import { describe, expect, it } from "vite-plus/test";
3
4
import {
5
+ getFileViewedRange,
6
isFileDiffCollapsed,
7
isLineInFileDiff,
8
toggleFileDiffFoldForViewed,
@@ -54,3 +55,19 @@ describe("toggleFileDiffFoldForViewed", () => {
55
expect(toggleFileDiffFoldForViewed("a.ts", false, "expanded", new Set()).size).toBe(0);
56
});
57
});
58
+
59
+describe("getFileViewedRange", () => {
60
+ const files = ["c.ts", "a.ts", "b.ts", "d.ts"].map((fileKey) => ({ fileKey }));
61
+
62
+ it("includes both endpoints in displayed order in either direction", () => {
63
+ expect(getFileViewedRange(files, "b.ts", "c.ts")).toEqual(files.slice(0, 3));
64
+ expect(getFileViewedRange(files, "c.ts", "b.ts")).toEqual(files.slice(0, 3));
65
+ expect(getFileViewedRange(files, "a.ts", "a.ts")).toEqual([files[1]]);
66
+ });
67
+
68
+ it("changes only the clicked file without a current anchor", () => {
69
+ expect(getFileViewedRange(files, "a.ts", null)).toEqual([files[1]]);
70
+ expect(getFileViewedRange(files, "a.ts", "removed.ts")).toEqual([files[1]]);
71
+ expect(getFileViewedRange(files, "removed.ts", "a.ts")).toEqual([]);
72
+ });
73
+});
apps/web/src/components/pullRequest/pullRequestDiff.logic.ts
+12
@@ -39,3 +39,15 @@ export function toggleFileDiffFoldForViewed(
39
else next.add(fileKey);
40
return next;
41
}
42
+
43
+export function getFileViewedRange<T extends { readonly fileKey: string }>(
44
+ files: ReadonlyArray<T>,
45
+ fileKey: string,
46
+ anchorFileKey: string | null,
47
+): ReadonlyArray<T> {
48
+ const index = files.findIndex((file) => file.fileKey === fileKey);
49
+ if (index === -1) return [];
50
+ const anchorIndex = files.findIndex((file) => file.fileKey === anchorFileKey);
51
+ if (anchorIndex === -1) return files.slice(index, index + 1);
52
+ return files.slice(Math.min(index, anchorIndex), Math.max(index, anchorIndex) + 1);
53
+}