@devries-cameron20 / t3code Mirror · read-only
Fork 0

The best way to control Claude Code, Codex and more from any computer or phone

Mirrored from https://github.com/Camo67/t3code.git

Synced Nov 21, 07:15 UTC

main
md 50 lines 2.79 KB
Rendered Raw
1 ---
2 name: pull-requests
3 description: Pull request finalization. Use when a change works and is about to be opened as a pull request, or when updating or continuing an existing one.
4 ---
5
6 A pull request is ready when its tests, implementation, comments, and changeset
7 are each the simplest that cover the intended behavior. Draft PRs can be used
8 earlier; finishing means making the PR ready for review.
9
10 ## Workflow
11
12 Run each step in a fresh-context subagent when available; otherwise run it
13 yourself. Pass along the task context and prior results so each step can check its gate.
14
15 1. Keep tests focused. Read [test-development](../test-development/SKILL.md) for
16 test placement and type. Cover each intended behavior once, in the existing
17 test file for the module.
18 For changes needing no tests, record why.
19 Continue when removing any remaining case would leave intended behavior
20 uncovered, or no tests are needed.
21 2. Simplify the implementation. With the tests passing, look for a simpler or
22 more idiomatic version: reuse helpers and patterns from nearby source and
23 [effect-development](../effect-development/SKILL.md), and remove debugging
24 code, scaffolding, and changes unrelated to the task.
25 Continue when applicable targeted tests pass and every hunk in the diff
26 from the merge base is required by the task.
27 3. Review the full diff from the merge base as a maintainer would: correctness,
28 failure and interruption paths, resource cleanup, naming and API
29 consistency with neighboring modules, and documentation. Fix findings and
30 review again.
31 Continue when a review pass produces no findings.
32 4. Clean up. Remove comments that restate code or narrate the change; keep the
33 rest short and about why. Finalize the changeset with
34 [changesets](../changesets/SKILL.md).
35 Continue when comments explain only what code cannot, and the changeset
36 describes the final consumer impact or the no-changeset reason is recorded.
37 5. Run the validation in the [AGENTS.md validation table](../../AGENTS.md#validation)
38 for each change type in the diff. Fix failures caused by the change; if
39 fixes alter the diff, repeat the affected passes.
40 Continue when applicable checks pass or commands that cannot run and their
41 blockers are recorded.
42 6. Open or update the pull request. Title: a short imperative summary.
43 Description: the problem addressed, notable decisions, and `Closes #<issue>` for each
44 GitHub issue resolved. Do not narrate the diff. Mark the PR ready for review.
45 Continue when the final changes are pushed, the description matches the
46 final diff, and the PR is ready for review.
47
48 The task is complete when each step's gate holds, validation has passed or
49 been reported as not runnable with reasons, and the pull request is ready for
50 review with a description matching the final diff.