The best way to control Claude Code, Codex and more from any computer or phone
Mirrored from https://github.com/Camo67/t3code.git
Synced Nov 21, 22:15 UTC
fix(server): a desktop tab detached during setup no longer blocks later browser tabs (#34252)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
yaacovcorcos committed
Nov 12, 2026 at 00:22 UTC
02f89d85ab5eda82abe19fd0a0490e6aff9f7022
2 files changed
+51
-3
apps/server/src/preview/DesktopBrowserChannel.test.ts
+45
@@ -65,3 +65,48 @@ it.effect("protects unknown desktop visibility until an explicit hidden report a
65
),
66
),
67
);
68
+
69
+it.live("closes a tab's relay connection when the desktop detaches the tab", () =>
70
+ Effect.gen(function* () {
71
+ const input = yield* Queue.unbounded<Uint8Array>();
72
+ vi.mocked(NodeStream.fromReadable).mockReturnValue(Stream.fromQueue(input));
73
+ const config = yield* ServerConfig.ServerConfig;
74
+ yield* Effect.gen(function* () {
75
+ const channel = yield* DesktopBrowserChannel.DesktopBrowserChannel;
76
+ const key = { threadId: "thread-1", tabId: "tab-1" };
77
+ const send = (event: object) =>
78
+ Queue.offer(input, new TextEncoder().encode(`${JSON.stringify(event)}\n`));
79
+
80
+ yield* send({ type: "attached", ...key });
81
+ yield* channel.awaitAttached(key, "5 seconds");
82
+ const url = yield* channel.endpoint(key);
83
+ const socket = new WebSocket(url);
84
+ yield* Effect.addFinalizer(() => Effect.sync(() => socket.close()));
85
+ const closed = new Promise<void>((resolve) =>
86
+ socket.addEventListener("close", () => resolve()),
87
+ );
88
+ yield* Effect.promise(
89
+ () => new Promise<void>((resolve) => socket.addEventListener("open", () => resolve())),
90
+ );
91
+
92
+ // Playwright waits on this socket for CDP replies; it must learn the tab is gone.
93
+ yield* send({ type: "detached", ...key });
94
+ yield* Effect.promise(() => closed).pipe(Effect.timeout("2 seconds"));
95
+ }).pipe(
96
+ Effect.scoped,
97
+ Effect.provide(
98
+ DesktopBrowserChannel.layer.pipe(
99
+ Layer.provide(
100
+ ServerConfig.layer({ ...config, desktopBrowserFd: 41, desktopBrowserControlFd: 42 }),
101
+ ),
102
+ ),
103
+ ),
104
+ );
105
+ }).pipe(
106
+ Effect.provide(
107
+ ServerConfig.layerTest(process.cwd(), { prefix: "desktop-browser-channel-" }).pipe(
108
+ Layer.provide(NodeServices.layer),
109
+ ),
110
+ ),
111
+ ),
112
+);
apps/server/src/preview/DesktopBrowserChannel.ts
+6
-3
@@ -193,12 +193,14 @@ const make = Effect.gen(function* () {
193
connected = true;
194
const writer = yield* socket.writer;
195
const reader = yield* socket.reader;
196
- yield* Stream.fromQueue(queue).pipe(
196
+ // A detach shuts the queue down. Ending here closes the socket, so Playwright's
197
+ // pending commands fail instead of waiting forever for the tab to answer.
198
+ const toPlaywright = Stream.fromQueue(queue).pipe(
199
Stream.runForEach((message) => writer.write(message)),
198
- Effect.forkScoped,
200
+ Effect.exit,
201
);
202
const decoder = new TextDecoder();
201
- return yield* reader.pull.pipe(
203
+ const toDesktop = reader.pull.pipe(
204
Effect.flatMap((frames) =>
205
Effect.forEach(
206
frames,
@@ -213,6 +215,7 @@ const make = Effect.gen(function* () {
215
),
216
Effect.forever,
217
);
218
+ return yield* Effect.raceFirst(toPlaywright, toDesktop);
219
}).pipe(Effect.scoped, Effect.ignore),
220
)
221
.pipe(Effect.forkScoped);