@devries-cameron20 / t3code Mirror · read-only / commits / 0516493a91
Fork 0

The best way to control Claude Code, Codex and more from any computer or phone

Mirrored from https://github.com/Camo67/t3code.git

Synced Nov 21, 16:00 UTC

fix(web): align status text and tighten pull request menu spacing (#36528)

Yash Singh committed Nov 14, 2026 at 01:12 UTC 0516493a914c193f548b6201463ba6d5f5ad9f70
4 files changed +37 -23
apps/web/src/components/GitActionsControl.tsx
+30 -18
@@ -21,7 +21,7 @@ import type {
21 } from "@t3tools/contracts";
22 import { useNavigate } from "@tanstack/react-router";
23 import * as Option from "effect/Option";
24 -import { useEffect, useEffectEvent, useRef, useState } from "react";
24 +import { useEffect, useEffectEvent, useId, useRef, useState } from "react";
25 import { useDeadlinePassed } from "../hooks/useDeadline";
26 import { useNowSecond } from "../hooks/useNowSecond";
27 import { flushSync } from "react-dom";
@@ -354,26 +354,46 @@ function RunningGitActionElapsedTime({
354 return null;
355 }
356
357 - return <p className={className}>{elapsed}</p>;
357 + return (
358 + <p aria-live="off" className={className}>
359 + {elapsed}
360 + </p>
361 + );
362 }
363
360 -function GitActionProgressButtonContent({ progress }: { progress: GitActionProgressPresentation }) {
364 +function GitActionProgressButtonContent({
365 + progress,
366 + id,
367 +}: {
368 + progress: GitActionProgressPresentation;
369 + id: string;
370 +}) {
371 const hasOutput = progress.output !== null;
372
373 return (
374 <div
375 + id={id}
376 aria-atomic="false"
377 aria-live="polite"
378 className={cn(
379 "grid min-w-0 flex-1 items-center",
369 - "grid-cols-[auto_minmax(0,1fr)] grid-rows-[1.125rem] gap-x-3",
380 + "grid-cols-[auto_minmax(0,1fr)_auto] grid-rows-[1.125rem] gap-x-3",
381 )}
382 role="status"
383 >
384 <Spinner aria-hidden="true" className="row-start-1 -mx-0.5 shrink-0" />
374 - <p className={cn("row-start-1 min-w-0 truncate text-left", THREAD_DETAILS_PANEL_LABEL_CLASS)}>
385 + <p
386 + className={cn(
387 + "row-start-1 min-w-0 self-baseline truncate text-left",
388 + THREAD_DETAILS_PANEL_LABEL_CLASS,
389 + )}
390 + >
391 {progress.status}
392 </p>
393 + <GitActionElapsedTime
394 + startedAtMs={progress.startedAtMs}
395 + className="col-start-3 row-start-1 self-baseline text-2xs font-normal tabular-nums text-muted-foreground"
396 + />
397 <div
398 className={cn(
399 "col-start-2 grid min-w-0 transition-[grid-template-rows,opacity] duration-200 ease-out motion-reduce:transition-none",
@@ -960,6 +980,7 @@ export default function GitActionsControl({
980 onOpenChanges,
981 workspaceMutationId = null,
982 }: GitActionsControlProps) {
983 + const progressLabelId = useId();
984 const panelAnchorRef = useRef<HTMLDivElement | null>(null);
985 const updateThreadMetadata = useAtomCommand(
986 threadEnvironment.updateMetadata,
@@ -1618,11 +1639,7 @@ export default function GitActionsControl({
1639 >
1640 {gitActionProgress ? (
1641 <ThreadDetailsControl
1621 - aria-label={
1622 - gitActionProgress.output
1623 - ? `${gitActionProgress.status} ${gitActionProgress.output}`
1624 - : gitActionProgress.status
1625 - }
1642 + aria-labelledby={progressLabelId}
1643 part="primary"
1644 panel
1645 multiline
@@ -1630,7 +1647,7 @@ export default function GitActionsControl({
1647 size="xs"
1648 variant="ghost"
1649 >
1633 - <GitActionProgressButtonContent progress={gitActionProgress} />
1650 + <GitActionProgressButtonContent id={progressLabelId} progress={gitActionProgress} />
1651 </ThreadDetailsControl>
1652 ) : visibleInlineSuccess ? (
1653 <ThreadDetailsControl part="primary" multiline disabled size="xs" variant="ghost">
@@ -1700,12 +1717,7 @@ export default function GitActionsControl({
1717 <TooltipPopup side="top">{quickAction.label}</TooltipPopup>
1718 </Tooltip>
1719 )}
1703 - {gitActionProgress ? (
1704 - <GitActionElapsedTime
1705 - startedAtMs={gitActionProgress.startedAtMs}
1706 - className="flex h-8 shrink-0 items-center self-start pe-2.5 text-2xs font-normal tabular-nums text-muted-foreground"
1707 - />
1708 - ) : (
1720 + {!gitActionProgress ? (
1721 <>
1722 <span aria-hidden="true" className={THREAD_DETAILS_PANEL_SPLIT_SEPARATOR_CLASS} />
1723 <Menu
@@ -1745,7 +1757,7 @@ export default function GitActionsControl({
1757 </MenuPopup>
1758 </Menu>
1759 </>
1748 - )}
1760 + ) : null}
1761 </div>
1762 )}
1763
apps/web/src/components/chat/ComposerBannerStack.tsx
+1 -1
@@ -182,7 +182,7 @@ function NoticeCard({
182 <ComposerBanner.Icon className="h-(--composer-banner-icon-column) self-start">
183 {item.icon}
184 </ComposerBanner.Icon>
185 - <ComposerBanner.Content className="whitespace-nowrap">
185 + <ComposerBanner.Content className="items-baseline whitespace-nowrap">
186 <NoticeText
187 detailsLabel={
188 typeof item.title === "string"
apps/web/src/components/chat/ThreadDetailsControl.tsx
+4
@@ -19,6 +19,10 @@ import { ChevronDownIcon } from "lucide-react";
19
20 const parts = {
21 row: THREAD_DETAILS_PANEL_ROW_CLASS,
22 + title: cn(
23 + THREAD_DETAILS_PANEL_ROW_CLASS,
24 + "h-auto min-h-8 items-start pt-1.5 pb-0 disabled:opacity-100 sm:h-auto [&>svg]:mt-px",
25 + ),
26 select: THREAD_DETAILS_PANEL_SELECT_ROW_CLASS,
27 primary: THREAD_DETAILS_PANEL_SPLIT_PRIMARY_CLASS,
28 secondary: THREAD_DETAILS_PANEL_SPLIT_SECONDARY_CLASS,
apps/web/src/components/chat/ThreadDetailsPrRow.tsx
+2 -4
@@ -445,9 +445,7 @@ export function ThreadDetailsPrRow({
445 type="button"
446 variant="ghost"
447 size="sm"
448 - part={part}
449 - multiline={wrap}
450 - className={wrap ? "items-start [&>svg]:mt-px" : undefined}
448 + part={wrap ? "title" : part}
449 aria-label={openAriaLabel}
450 onClick={onOpen}
451 onAuxClick={onOpen}
@@ -477,7 +475,7 @@ export function ThreadDetailsPrRow({
475 {detail !== null && (showChecks || trailingAction !== null || watching) ? (
476 <div className="pb-1.5">
477 {openRow(detail.title, "row", true)}
480 - <div className="mt-1.5 flex h-5 min-w-0 items-center gap-0.5 ps-9 pe-2.5 text-xs text-muted-foreground">
478 + <div className="flex h-5 min-w-0 items-center gap-0.5 ps-9 pe-2.5 text-xs text-muted-foreground">
479 <span className="me-1 shrink-0 tabular-nums">#{number}</span>
480 {showChecks && checksRollup !== null ? (
481 <PullRequestChecksPopover