@devries-cameron20 / t3code Mirror · read-only / commits / 11611419f3
Fork 0

The best way to control Claude Code, Codex and more from any computer or phone

Mirrored from https://github.com/Camo67/t3code.git

Synced Nov 21, 23:30 UTC

fix(web): trackpad flicks over the right panel tabs no longer navigate back (#33396)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

Julius Marminge committed Nov 10, 2026 at 21:39 UTC 11611419f39eb2bdc222989e842f3da4033b99b5
2 files changed +139 -3
apps/web/src/components/RightPanelTabs.browser.test.tsx new
+135
@@ -0,0 +1,135 @@
1 +import "~/index.css";
2 +
3 +import { describe, expect, it, vi } from "vite-plus/test";
4 +
5 +import type { RightPanelSurface } from "~/rightPanelStore";
6 +import { render, stubGlobal } from "../../test/render";
7 +import { HistorySwipeNavigation } from "./HistorySwipeNavigation";
8 +import { RightPanelTabs } from "./RightPanelTabs";
9 +
10 +const navigateHistory = vi.hoisted(() => vi.fn());
11 +vi.mock("../navigationHistory", () => ({ canNavigateHistory: () => true, navigateHistory }));
12 +
13 +// Chromium starts a gesture scroll, and Electron reports its begin, only for a
14 +// wheel event the page did not preventDefault; it then scrolls the latched scroller.
15 +function trackpad() {
16 + const begin = new Set<() => void>();
17 + const end = new Set<() => void>();
18 + const subscribe = (listeners: Set<() => void>) => (listener: () => void) => {
19 + listeners.add(listener);
20 + return () => listeners.delete(listener);
21 + };
22 + let scrolling = false;
23 + return {
24 + bridge: { onTrackpadScrollBegin: subscribe(begin), onTrackpadScrollEnd: subscribe(end) },
25 + scroll(target: Element, deltas: readonly number[]) {
26 + let scroller: Element | null = target;
27 + while (
28 + scroller &&
29 + (scroller.scrollWidth <= scroller.clientWidth ||
30 + !/auto|scroll/.test(getComputedStyle(scroller).overflowX))
31 + ) {
32 + scroller = scroller.parentElement;
33 + }
34 + for (const deltaX of deltas) {
35 + const event = new WheelEvent("wheel", {
36 + deltaX,
37 + bubbles: true,
38 + cancelable: true,
39 + composed: true,
40 + });
41 + target.dispatchEvent(event);
42 + if (event.defaultPrevented) continue;
43 + if (scroller) scroller.scrollLeft += deltaX;
44 + if (scrolling) continue;
45 + scrolling = true;
46 + for (const listener of begin) listener();
47 + }
48 + if (scrolling) for (const listener of end) listener();
49 + scrolling = false;
50 + },
51 + };
52 +}
53 +
54 +const surfaces: RightPanelSurface[] = Array.from({ length: 16 }, (_, index) => ({
55 + id: `terminal:${index}`,
56 + kind: "terminal",
57 + resourceId: `${index}`,
58 + terminalIds: [`${index}`],
59 + activeTerminalId: `${index}`,
60 +}));
61 +
62 +describe("RightPanelTabs", () => {
63 + it("a flick that scrolls the tab strip to its left edge keeps the thread, a swipe from the edge goes back", async () => {
64 + navigateHistory.mockReset();
65 + const { bridge, scroll } = trackpad();
66 + using _bridge = stubGlobal("desktopBridge", bridge);
67 + const panel = document.createElement("div");
68 + panel.style.cssText = "width: 320px; height: 200px; display: flex";
69 + const noop = () => {};
70 + await using screen = await render(
71 + <>
72 + <HistorySwipeNavigation />
73 + <RightPanelTabs
74 + mode="embedded"
75 + keybindings={[]}
76 + getShortcutContext={() => ({
77 + terminalFocus: false,
78 + terminalOpen: false,
79 + previewFocus: false,
80 + previewOpen: false,
81 + isWeb: true,
82 + isDesktop: false,
83 + })}
84 + surfaces={surfaces}
85 + environmentId={null}
86 + activeSurfaceId={null}
87 + pendingSurfaceIds={new Set()}
88 + previewSessions={{}}
89 + desktopByTabId={{}}
90 + terminalLabelsById={new Map(surfaces.map((surface) => [surface.id, "Terminal"]))}
91 + onActivate={noop}
92 + onCloseSurface={noop}
93 + onCloseOtherSurfaces={noop}
94 + onCloseSurfacesToRight={noop}
95 + onCloseAllSurfaces={noop}
96 + onCopyFilePath={noop}
97 + onAddBrowser={noop}
98 + onAddBrowserInProfile={noop}
99 + onAddTerminal={noop}
100 + onAddDiff={noop}
101 + onAddFiles={noop}
102 + onAddPullRequest={noop}
103 + onAddPullRequests={noop}
104 + onAddDevice={noop}
105 + browserAvailable={false}
106 + terminalAvailable
107 + diffAvailable={false}
108 + filesAvailable={false}
109 + pullRequestAvailable={false}
110 + pullRequestsAvailable={false}
111 + deviceAvailable={false}
112 + >
113 + {null}
114 + </RightPanelTabs>
115 + </>,
116 + { container: panel },
117 + );
118 + const viewport = screen.container.querySelector<HTMLElement>(
119 + '[data-right-panel-tab-list] [data-slot="scroll-area-viewport"]',
120 + )!;
121 + expect(viewport.scrollWidth - viewport.clientWidth).toBeGreaterThan(120);
122 + viewport.scrollLeft = 120;
123 +
124 + const momentum = Array.from({ length: 24 }, (_, index) => -60 * 0.85 ** index);
125 + scroll(viewport.querySelector("[data-active-tab]")!, [-10, -20, -30, ...momentum]);
126 +
127 + expect(viewport.scrollLeft).toBe(0);
128 + expect(navigateHistory).not.toHaveBeenCalled();
129 +
130 + viewport.scrollLeft = 0;
131 + scroll(viewport.querySelector("[data-active-tab]")!, [-40, -40, -40, -40, -40]);
132 +
133 + expect(navigateHistory).toHaveBeenCalledExactlyOnceWith("back");
134 + });
135 +});
apps/web/src/components/RightPanelTabs.tsx
+4 -3
@@ -1291,12 +1291,13 @@ export function RightPanelTabs(props: RightPanelTabsProps) {
1291 if (!viewport) return;
1292
1293 const update = () => updateTabScrollState(viewport);
1294 + // Only a vertical mouse wheel is translated. Horizontal input scrolls natively, since
1295 + // consuming it keeps Chromium from starting the gesture scroll that swipe navigation tracks.
1296 const handleWheel = (event: WheelEvent) => {
1295 - if (event.ctrlKey) return;
1296 - let delta = Math.abs(event.deltaX) > Math.abs(event.deltaY) ? event.deltaX : event.deltaY;
1297 + if (event.ctrlKey || Math.abs(event.deltaX) >= Math.abs(event.deltaY)) return;
1298 + let delta = event.deltaY;
1299 if (event.deltaMode === WheelEvent.DOM_DELTA_LINE) delta *= 16;
1300 if (event.deltaMode === WheelEvent.DOM_DELTA_PAGE) delta *= viewport.clientWidth;
1299 - if (delta === 0) return;
1301
1302 const previousScrollLeft = viewport.scrollLeft;
1303 viewport.scrollLeft += delta;