@devries-cameron20 / t3code Mirror · read-only / commits / 13a6782a6c
Fork 0

The best way to control Claude Code, Codex and more from any computer or phone

Mirrored from https://github.com/Camo67/t3code.git

Synced Nov 21, 14:45 UTC

fix(web): ODS time cells without display text show their value (#36685)

Co-authored-by: Julius Marminge <julius0216@outlook.com>

Wout Stiens committed Nov 14, 2026 at 13:12 UTC 13a6782a6c4da6b54085cb7002e23e219cbd009b
3 files changed +40
apps/web/src/components/files/FilePreviewPanel.test.ts
+10
@@ -377,6 +377,16 @@ Third}`;
377 expect(result.sheets[0]!.rows[0]![0]).toBe("Research & design");
378 });
379
380 + it("reads an ODS time cell that has no display paragraph", async () => {
381 + const archive = new JSZip().file(
382 + "content.xml",
383 + `<office:document-content xmlns:office="urn:oasis:names:tc:opendocument:xmlns:office:1.0" xmlns:table="urn:oasis:names:tc:opendocument:xmlns:table:1.0"><office:body><office:spreadsheet><table:table table:name="Values"><table:table-row><table:table-cell office:value-type="time" office:time-value="PT03H30M00S"></table:table-cell></table:table-row></table:table></office:spreadsheet></office:body></office:document-content>`,
384 + );
385 + const result = await openDocument(archive, "ods");
386 + if (result.type !== "ods") throw new Error("Expected workbook");
387 + expect(result.sheets[0]!.rows).toEqual([["PT03H30M00S"]]);
388 + });
389 +
390 it.each([1, 500])("ignores styled ODS filler after %s populated rows", async (count) => {
391 const archive = new JSZip().file(
392 "content.xml",
apps/web/src/components/files/extendedDocumentPreview.ts
+1
@@ -339,6 +339,7 @@ export async function openDocument(
339 find(cell, "text:p", "office:annotation").map(text).join("\n") ||
340 cell.attrs["office:value"] ||
341 cell.attrs["office:date-value"] ||
342 + cell.attrs["office:time-value"] ||
343 cell.attrs["office:boolean-value"] ||
344 cell.attrs["office:string-value"] ||
345 "";
scripts/scenarios/ods-time-cell-shows-its-value.e2e.ts new
+29
@@ -0,0 +1,29 @@
1 +import { expect } from "e2e";
2 +
3 +import { test, WEB } from "./t3.ts";
4 +
5 +// A valid ODS whose only cell is typed time with no optional <text:p> display paragraph.
6 +const TIME_ONLY_ODS =
7 + "UEsDBAoAAAAAACdXbl2FbDmKLgAAAC4AAAAIAAAAbWltZXR5cGVhcHBsaWNhdGlvbi92bmQub2FzaXMub3BlbmRvY3VtZW50LnNwcmVhZHNoZWV0UEsDBAoAAAAAACdXbl0AAAAAAAAAAAAAAAAJAAAATUVUQS1JTkYvUEsDBAoAAAAIACdXbl3Rr5gOtgAAAHABAAAVAAAATUVUQS1JTkYvbWFuaWZlc3QueG1sjZDRCsIwDEV/ZeR9q+KLlFXf/AL9gNJmWmjTsmZj+3ur4JyI4FtCcu+5SXucgq9G7LOLpGDbbKBCMtE6uiq4nE/1Ho6HNmhyHWaWr6IqMspLq2DoSUadXZakA2bJRsaEZKMZAhLLz335BC3dir+DFa1zHuui7uf3bjd4XyfNNwViZRHQOl3znFCBTsk7o7lYipFs88zVrOM0OfWobb4hMoj/iSYSP+Tlmh9sxonFY1xcxdfbDndQSwMECgAAAAgAJ1duXZwajlHfAAAACgIAAAsAAABjb250ZW50LnhtbI2RwWrDMAyGXyXo7sUjl2Hi9DZ6GQzaPYDrKKvBkULsbO3bz423kLANerEt6f/0S7jeXXpffOAYHJOGxwcJBZLl1tG7hrfjs3iCXVNz1zmLqmU79UhRWKaY7iLBFFSuaphGUmyCC4pMj0FFq3hA+qHUWq1mq5yJ5uTvxmfxhsZLvBtO2sx+T7HavIJlzxO31yUIw4imDWfE2NTZfT6L/L7ZaTicXRcDbARi5M9twqL3i7PxE4p4HRIdXY/LSLdAzFUNr0dZ7Sv5IuUByqYuf3VfZ1L018jlZqnyn69svgBQSwECFAAKAAAAAAAnV25dhWw5ii4AAAAuAAAACAAAAAAAAAAAAAAAAAAAAAAAbWltZXR5cGVQSwECFAAKAAAAAAAnV25dAAAAAAAAAAAAAAAACQAAAAAAAAAAABAAAABUAAAATUVUQS1JTkYvUEsBAhQACgAAAAgAJ1duXdGvmA62AAAAcAEAABUAAAAAAAAAAAAAAAAAewAAAE1FVEEtSU5GL21hbmlmZXN0LnhtbFBLAQIUAAoAAAAIACdXbl2cGo5R3wAAAAoCAAALAAAAAAAAAAAAAAAAAGQBAABjb250ZW50LnhtbFBLBQYAAAAABAAEAOkAAABsAgAAAAA=";
8 +
9 +test(
10 + "An ODS time cell without a display paragraph shows its value",
11 + WEB,
12 + async ({ t3, app, screen }) => {
13 + const project = await t3.project("demo", {
14 + "shifts.ods": Buffer.from(TIME_ONLY_ODS, "base64"),
15 + });
16 + const thread = await t3.thread({ project, title: "Shifts", messages: ["Start"] });
17 + await t3.open(thread);
18 +
19 + await screen.getByRole("button", "Toggle right panel").tap();
20 + await screen.getByRole("button", "Files F").tap();
21 + await screen.getByRole("treeitem", "shifts.ods").tap();
22 + // A cold Vite cache reloads the page the first time the office preview loads.
23 + await expect(screen.getByText("Sheet 1 of 1", { exact: false })).toBeVisible({
24 + timeout: 60_000,
25 + });
26 + await app.screenshot("sheet");
27 + await expect(screen.getByText("PT03H30M00S")).toBeVisible();
28 + },
29 +);