@devries-cameron20 / t3code Mirror · read-only / commits / 14d57b451e
Fork 0

The best way to control Claude Code, Codex and more from any computer or phone

Mirrored from https://github.com/Camo67/t3code.git

Synced Nov 21, 07:15 UTC

fix(web): server browser pane reports when Chromium draws no frames (#38865)

Julius Marminge committed Nov 18, 2026 at 19:33 UTC 14d57b451e4eaa66ccc0b840de552826279484bd
13 files changed +83 -5
apps/web/src/browser/ServerBrowserSurface.browser.test.tsx
+36 -1
@@ -7,7 +7,7 @@ import type {
7 import { describe, expect, it, vi } from "vite-plus/test";
8 import { userEvent } from "vite-plus/test/browser";
9
10 -import { act, render } from "../../test/render";
10 +import { act, fakeTimers, render } from "../../test/render";
11
12 const mocks = vi.hoisted(() => ({
13 createClient: vi.fn<(target: unknown, handlers: PreviewStreamEvents) => unknown>(),
@@ -220,3 +220,38 @@ describe("ServerBrowserSurface history", () => {
220 expect(mouseInputs()).not.toEqual([]);
221 });
222 });
223 +
224 +describe("ServerBrowserSurface frames", () => {
225 + it("reports a connected stream that never delivers a frame until one arrives", async () => {
226 + setup();
227 + const onNoFrames = vi.fn();
228 + const container = document.createElement("div");
229 + container.style.cssText = "width: 400px; height: 300px; display: flex;";
230 + await using _screen = await render(
231 + <ServerBrowserSurface
232 + environmentId={EnvironmentId.make("environment-frames")}
233 + threadId="thread-frames"
234 + tabId="tab-frames"
235 + visible
236 + followSize={false}
237 + onNoFrames={onNoFrames}
238 + className="flex-1"
239 + />,
240 + { container },
241 + );
242 + await vi.waitFor(() => expect(mocks.createClient).toHaveBeenCalled());
243 + using _timers = fakeTimers();
244 + const handlers = mocks.createClient.mock.calls.at(-1)![1];
245 + await act(() => handlers.onConnectedChange(true));
246 + await act(() => vi.advanceTimersByTime(9_999));
247 + expect(onNoFrames).not.toHaveBeenCalled();
248 + expect(container.querySelector('[role="alert"]')).toBeNull();
249 +
250 + await act(() => vi.advanceTimersByTime(1));
251 + expect(onNoFrames).toHaveBeenCalledOnce();
252 + expect(container.querySelector('[role="alert"]')?.textContent).toContain("not drawing it");
253 +
254 + await act(() => mocks.painted?.());
255 + expect(container.querySelector('[role="alert"]')).toBeNull();
256 + });
257 +});
apps/web/src/browser/ServerBrowserSurface.tsx
+33 -1
@@ -70,6 +70,8 @@ const TAP_SLOP_PX = 8;
70 const MULTI_CLICK_MS = 500;
71 const MULTI_CLICK_SLOP_PX = 4;
72 const WHEEL_LINE_PX = 16;
73 +// The server answers a new viewer with a still within seconds, so silence means Chromium is not painting.
74 +const NO_FRAME_TIMEOUT_MS = 10_000;
75
76 type MouseInput = Extract<PreviewStreamInput, { type: "mouse" }>;
77 type WheelInput = Extract<PreviewStreamInput, { type: "wheel" }>;
@@ -151,6 +153,7 @@ export function ServerBrowserSurface(props: {
153 readonly followSize?: boolean;
154 readonly controlPosition?: "top" | "bottom";
155 readonly onFirstFrame?: () => void;
156 + readonly onNoFrames?: () => void;
157 readonly onViewport?: (viewport: PreviewStreamViewport) => void;
158 readonly onControl?: (control: PreviewStreamControl | null) => void;
159 readonly onPopup?: (tabId: string) => void;
@@ -166,6 +169,7 @@ export function ServerBrowserSurface(props: {
169 followSize = true,
170 controlPosition = "top",
171 onFirstFrame,
172 + onNoFrames,
173 onViewport,
174 onControl,
175 onPopup,
@@ -220,6 +224,8 @@ export function ServerBrowserSurface(props: {
224 const probeRef = useRef<TouchProbe | null>(null);
225 const lastProbeRef = useRef<{ x: number; y: number; editable: boolean; at: number } | null>(null);
226 const firstFrame = useEffectEvent(() => onFirstFrame?.());
227 + const noFrames = useEffectEvent(() => onNoFrames?.());
228 + const [framesStalled, setFramesStalled] = useState(false);
229 const viewportChanged = useEffectEvent((viewport: PreviewStreamViewport) =>
230 onViewport?.(viewport),
231 );
@@ -375,9 +381,16 @@ export function ServerBrowserSurface(props: {
381 const canvas = canvasRef.current;
382 if (!visible || accessDenied || hostSetup || !access || !cap || !canvas) return;
383 let refreshTimer: ReturnType<typeof setTimeout> | null = null;
384 + let noFrameTimer: ReturnType<typeof setTimeout> | null = null;
385 + const clearNoFrameTimer = () => {
386 + if (noFrameTimer !== null) clearTimeout(noFrameTimer);
387 + noFrameTimer = null;
388 + };
389 const painter = createPreviewFramePainter(canvas, () => {
390 if (hasFrameRef.current) return;
391 hasFrameRef.current = true;
392 + clearNoFrameTimer();
393 + setFramesStalled(false);
394 firstFrame();
395 });
396 const client = createPreviewStreamClient(
@@ -429,7 +442,15 @@ export function ServerBrowserSurface(props: {
442 }
443 },
444 onConnectedChange: (connected) => {
432 - if (connected) return;
445 + clearNoFrameTimer();
446 + if (connected) {
447 + if (!hasFrameRef.current)
448 + noFrameTimer = setTimeout(() => {
449 + setFramesStalled(true);
450 + noFrames();
451 + }, NO_FRAME_TIMEOUT_MS);
452 + return;
453 + }
454 setFileChooser(null);
455 controlRef.current = null;
456 setControl(null);
@@ -454,6 +475,7 @@ export function ServerBrowserSurface(props: {
475 clientRef.current = client;
476 return () => {
477 painter.stop();
478 + clearNoFrameTimer();
479 if (refreshTimer !== null) clearTimeout(refreshTimer);
480 client.stop();
481 if (clientRef.current === client) clientRef.current = null;
@@ -829,6 +851,16 @@ export function ServerBrowserSurface(props: {
851 if (text) send({ type: "text", text });
852 }}
853 />
854 + {visible && framesStalled && !pdfUrl ? (
855 + <div className="absolute inset-0 flex items-center justify-center bg-background p-4 text-center">
856 + <p role="alert" className="max-w-sm text-sm text-muted-foreground">
857 + <T>
858 + The server's browser loaded this page but is not drawing it. Try reloading, or open
859 + the page in a browser on this computer.
860 + </T>
861 + </p>
862 + </div>
863 + ) : null}
864 {fileChooser && control?.controller === "you" ? (
865 <div
866 className="absolute inset-x-2 top-2 z-10 flex flex-col gap-2 rounded-lg border border-border bg-background p-3 shadow-lg"
apps/web/src/components/preview/PreviewView.tsx
+4 -3
@@ -241,7 +241,7 @@ export function PreviewView({
241 }, [serverToolbarShown]);
242 const [serverControlledTabId, setServerControlledTabId] = useState<string | null>(null);
243 const serverInputDisabled = isServerTab && serverControlledTabId !== runtimeTabId;
244 - const [serverFrameTabId, setServerFrameTabId] = useState<string | null>(null);
244 + const [serverStreamSettledTabId, setServerStreamSettledTabId] = useState<string | null>(null);
245 // A desktop page that mounted before its tab went headless leaves its stale state here.
246 const desktopOverlay =
247 tabId && !isServerTab ? (previewState.desktopByTabId[tabId] ?? null) : null;
@@ -260,7 +260,7 @@ export function PreviewView({
260 const isUnreachable = navStatus._tag === "LoadFailed";
261 const showEmptyState = navStatus._tag === "Idle";
262 const serverStreamPending =
263 - isServerTab && !showEmptyState && !isUnreachable && serverFrameTabId !== runtimeTabId;
263 + isServerTab && !showEmptyState && !isUnreachable && serverStreamSettledTabId !== runtimeTabId;
264 const controller = desktopOverlay?.controller ?? "none";
265 const viewport = snapshot?.viewport ?? FILL_PREVIEW_VIEWPORT;
266 const browserDefaults = useBrowserDefaults();
@@ -1110,7 +1110,8 @@ export function PreviewView({
1110 : null
1111 }
1112 visible={visible}
1113 - onFirstFrame={() => setServerFrameTabId(runtimeTabId)}
1113 + onFirstFrame={() => setServerStreamSettledTabId(runtimeTabId)}
1114 + onNoFrames={() => setServerStreamSettledTabId(runtimeTabId)}
1115 onControl={(control) =>
1116 setServerControlledTabId(control?.controller === "you" ? runtimeTabId : null)
1117 }
apps/web/src/i18n/translations/de.json
+1
@@ -1421,6 +1421,7 @@
1421 "61a552a67e9e3eac": "Antwort auf Dialog",
1422 "3d000b56e95f3150": "Steuerung abgeben",
1423 "0633c3bcdcb95b2f": "Steuerung übernehmen",
1424 + "b8ba763621bcdd70": "Der Browser des Servers hat diese Seite geladen, zeichnet sie aber nicht. Lade sie neu oder öffne die Seite in einem Browser auf diesem Computer.",
1425 "db4deed9433e0482": "Die Seite fordert Dateien an.",
1426 "730765790c9965e2": "Die Seite fordert eine Datei an.",
1427 "d15d4ce9981708e9": "Abbrechen",
apps/web/src/i18n/translations/en.json
+1
@@ -1421,6 +1421,7 @@
1421 "61a552a67e9e3eac": "Dialog response",
1422 "3d000b56e95f3150": "Release control",
1423 "0633c3bcdcb95b2f": "Take control",
1424 + "b8ba763621bcdd70": "The server's browser loaded this page but is not drawing it. Try reloading, or open the page in a browser on this computer.",
1425 "db4deed9433e0482": "The page asks for files.",
1426 "730765790c9965e2": "The page asks for a file.",
1427 "d15d4ce9981708e9": "Cancel",
apps/web/src/i18n/translations/es.json
+1
@@ -1421,6 +1421,7 @@
1421 "61a552a67e9e3eac": "Respuesta al cuadro de diálogo",
1422 "3d000b56e95f3150": "Ceder el control",
1423 "0633c3bcdcb95b2f": "Tomar el control",
1424 + "b8ba763621bcdd70": "El navegador del servidor cargó esta página, pero no la está dibujando. Prueba a recargarla o abre la página en un navegador de este ordenador.",
1425 "db4deed9433e0482": "La página pide archivos.",
1426 "730765790c9965e2": "La página pide un archivo.",
1427 "d15d4ce9981708e9": "Cancelar",
apps/web/src/i18n/translations/fr.json
+1
@@ -1421,6 +1421,7 @@
1421 "61a552a67e9e3eac": "Réponse à la boîte de dialogue",
1422 "3d000b56e95f3150": "Rendre le contrôle",
1423 "0633c3bcdcb95b2f": "Prendre le contrôle",
1424 + "b8ba763621bcdd70": "Le navigateur du serveur a chargé cette page mais ne l'affiche pas. Essayez de la recharger ou ouvrez la page dans un navigateur sur cet ordinateur.",
1425 "db4deed9433e0482": "La page demande des fichiers.",
1426 "730765790c9965e2": "La page demande un fichier.",
1427 "d15d4ce9981708e9": "Annuler",
apps/web/src/i18n/translations/ja.json
+1
@@ -1421,6 +1421,7 @@
1421 "61a552a67e9e3eac": "ダイアログへの応答",
1422 "3d000b56e95f3150": "操作権を手放す",
1423 "0633c3bcdcb95b2f": "操作権を取得",
1424 + "b8ba763621bcdd70": "サーバーのブラウザーはこのページを読み込みましたが、描画していません。再読み込みするか、このコンピューターのブラウザーでページを開いてください。",
1425 "db4deed9433e0482": "ページがファイルを求めています。",
1426 "730765790c9965e2": "ページがファイルを求めています。",
1427 "d15d4ce9981708e9": "キャンセル",
apps/web/src/i18n/translations/ko.json
+1
@@ -1421,6 +1421,7 @@
1421 "61a552a67e9e3eac": "대화 상자 응답",
1422 "3d000b56e95f3150": "제어 해제",
1423 "0633c3bcdcb95b2f": "제어하기",
1424 + "b8ba763621bcdd70": "서버의 브라우저가 이 페이지를 불러왔지만 화면을 그리지 않고 있습니다. 새로고침하거나 이 컴퓨터의 브라우저에서 페이지를 여세요.",
1425 "db4deed9433e0482": "페이지에서 파일을 요청합니다.",
1426 "730765790c9965e2": "페이지에서 파일을 요청합니다.",
1427 "d15d4ce9981708e9": "취소",
apps/web/src/i18n/translations/pt-BR.json
+1
@@ -1421,6 +1421,7 @@
1421 "61a552a67e9e3eac": "Resposta da caixa de diálogo",
1422 "3d000b56e95f3150": "Liberar o controle",
1423 "0633c3bcdcb95b2f": "Assumir o controle",
1424 + "b8ba763621bcdd70": "O navegador do servidor carregou esta página, mas não a está desenhando. Tente recarregar ou abra a página em um navegador neste computador.",
1425 "db4deed9433e0482": "A página está pedindo arquivos.",
1426 "730765790c9965e2": "A página está pedindo um arquivo.",
1427 "d15d4ce9981708e9": "Cancelar",
apps/web/src/i18n/translations/ru.json
+1
@@ -1421,6 +1421,7 @@
1421 "61a552a67e9e3eac": "Ответ на диалог",
1422 "3d000b56e95f3150": "Отдать управление",
1423 "0633c3bcdcb95b2f": "Взять управление",
1424 + "b8ba763621bcdd70": "Браузер сервера загрузил эту страницу, но не отрисовывает её. Попробуйте перезагрузить её или откройте страницу в браузере на этом компьютере.",
1425 "db4deed9433e0482": "Страница запрашивает файлы.",
1426 "730765790c9965e2": "Страница запрашивает файл.",
1427 "d15d4ce9981708e9": "Отмена",
apps/web/src/i18n/translations/sv.json
+1
@@ -1421,6 +1421,7 @@
1421 "61a552a67e9e3eac": "Dialogsvar",
1422 "3d000b56e95f3150": "Släpp kontrollen",
1423 "0633c3bcdcb95b2f": "Ta kontrollen",
1424 + "b8ba763621bcdd70": "Serverns webbläsare har läst in sidan men ritar inte upp den. Försök läsa in den igen, eller öppna sidan i en webbläsare på den här datorn.",
1425 "db4deed9433e0482": "Sidan ber om filer.",
1426 "730765790c9965e2": "Sidan ber om en fil.",
1427 "d15d4ce9981708e9": "Avbryt",
apps/web/src/i18n/translations/zh.json
+1
@@ -1421,6 +1421,7 @@
1421 "61a552a67e9e3eac": "对话框输入",
1422 "3d000b56e95f3150": "释放控制",
1423 "0633c3bcdcb95b2f": "接管控制",
1424 + "b8ba763621bcdd70": "服务器的浏览器已加载此页面,但没有绘制出来。请尝试重新加载,或在这台电脑的浏览器中打开该页面。",
1425 "db4deed9433e0482": "页面请求选择文件。",
1426 "730765790c9965e2": "页面请求选择一个文件。",
1427 "d15d4ce9981708e9": "取消",