@devries-cameron20 / t3code Mirror · read-only / commits / 1c17285e58
Fork 0

The best way to control Claude Code, Codex and more from any computer or phone

Mirrored from https://github.com/Camo67/t3code.git

Synced Nov 21, 23:30 UTC

fix(shared): cite assistant messages with IDs over 512 characters (#28084)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

Julius Marminge committed Nov 10, 2026 at 22:14 UTC 1c17285e58350e6df91b0de805dc4030ced9c6c6
3 files changed +18 -8
packages/contracts/src/assistantCitations.ts
+5 -3
@@ -4,13 +4,15 @@ import { EnvironmentId, MessageId, NonNegativeInt, ThreadId } from "./baseSchema
4 export const ASSISTANT_CITATION_MAX_TEXT_LENGTH = 8_000;
5 export const ASSISTANT_CITATION_MAX_COMMENT_LENGTH = 8_000;
6 export const ASSISTANT_CITATION_CONTEXT_LENGTH = 32;
7 +// Provider message IDs nest and re-encode their thread and turn IDs, so they outgrow a few hundred characters.
8 +export const ASSISTANT_CITATION_MAX_ID_LENGTH = 4_096;
9
10 /** Positions are UTF-16 offsets, not Markdown offsets. */
11 export const AssistantCitation = Schema.Struct({
12 version: Schema.Literal(1),
11 - environmentId: EnvironmentId.check(Schema.isMaxLength(512)),
12 - threadId: ThreadId.check(Schema.isMaxLength(512)),
13 - messageId: MessageId.check(Schema.isMaxLength(512)),
13 + environmentId: EnvironmentId.check(Schema.isMaxLength(ASSISTANT_CITATION_MAX_ID_LENGTH)),
14 + threadId: ThreadId.check(Schema.isMaxLength(ASSISTANT_CITATION_MAX_ID_LENGTH)),
15 + messageId: MessageId.check(Schema.isMaxLength(ASSISTANT_CITATION_MAX_ID_LENGTH)),
16 text: Schema.String.check(
17 Schema.isNonEmpty(),
18 Schema.isMaxLength(ASSISTANT_CITATION_MAX_TEXT_LENGTH),
packages/shared/src/assistantCitations.test.ts
+4 -3
@@ -2,6 +2,7 @@ import { describe, expect, it } from "vite-plus/test";
2 import {
3 ASSISTANT_CITATION_CONTEXT_LENGTH,
4 ASSISTANT_CITATION_MAX_COMMENT_LENGTH,
5 + ASSISTANT_CITATION_MAX_ID_LENGTH,
6 ASSISTANT_CITATION_MAX_TEXT_LENGTH,
7 EnvironmentId,
8 MessageId,
@@ -126,9 +127,9 @@ describe("assistant citation references", () => {
127 it("accepts complete 8k CJK quotes and comments with maximum-sized source selectors", () => {
128 const largeCitation: AssistantCitation = {
129 ...citation,
129 - environmentId: EnvironmentId.make("環".repeat(512)),
130 - threadId: ThreadId.make("線".repeat(512)),
131 - messageId: MessageId.make("文".repeat(512)),
130 + environmentId: EnvironmentId.make("環".repeat(ASSISTANT_CITATION_MAX_ID_LENGTH)),
131 + threadId: ThreadId.make("線".repeat(ASSISTANT_CITATION_MAX_ID_LENGTH)),
132 + messageId: MessageId.make("文".repeat(ASSISTANT_CITATION_MAX_ID_LENGTH)),
133 text: "引".repeat(ASSISTANT_CITATION_MAX_TEXT_LENGTH),
134 comment: "注".repeat(ASSISTANT_CITATION_MAX_COMMENT_LENGTH),
135 start: Number.MAX_SAFE_INTEGER - ASSISTANT_CITATION_MAX_TEXT_LENGTH,
packages/shared/src/assistantCitations.ts
+9 -2
@@ -1,5 +1,7 @@
1 import {
2 + ASSISTANT_CITATION_CONTEXT_LENGTH,
3 ASSISTANT_CITATION_MAX_COMMENT_LENGTH,
4 + ASSISTANT_CITATION_MAX_ID_LENGTH,
5 ASSISTANT_CITATION_MAX_TEXT_LENGTH,
6 AssistantCitation,
7 } from "@t3tools/contracts";
@@ -8,9 +10,14 @@ import * as Schema from "effect/Schema";
10
11 const CITATION_PROTOCOL = "t3-citation:";
12 const CITATION_HREF_PREFIX = `${CITATION_PROTOCOL}//v1/`;
11 -// Percent encoding needs up to nine characters per UTF-16 code unit; 16k covers selectors.
13 +// Percent encoding needs up to nine characters per UTF-16 code unit; 1k covers keys and offsets.
14 const MAX_CITATION_HREF_LENGTH =
13 - 9 * (ASSISTANT_CITATION_MAX_TEXT_LENGTH + ASSISTANT_CITATION_MAX_COMMENT_LENGTH) + 16_000;
15 + 9 *
16 + (ASSISTANT_CITATION_MAX_TEXT_LENGTH +
17 + ASSISTANT_CITATION_MAX_COMMENT_LENGTH +
18 + 3 * ASSISTANT_CITATION_MAX_ID_LENGTH +
19 + 2 * ASSISTANT_CITATION_CONTEXT_LENGTH) +
20 + 1_000;
21 const CITATION_LINK = new RegExp(
22 String.raw`\[Assistant quote\]\((${CITATION_HREF_PREFIX}[^\s)]{1,${MAX_CITATION_HREF_LENGTH - CITATION_HREF_PREFIX.length}})\)`,
23 "g",