@devries-cameron20 / t3code Mirror · read-only / commits / 25868edf9a
Fork 0

The best way to control Claude Code, Codex and more from any computer or phone

Mirrored from https://github.com/Camo67/t3code.git

Synced Nov 22, 02:00 UTC

fix(github): hidden GitHub comments and reviews no longer show in T3 Code (#33134)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

Theo Browne committed Nov 8, 2026 at 16:39 UTC 25868edf9a382b156c5739f225589cf4c425da93
15 files changed +169 -35
apps/server/src/orchestration-v2/PullRequestWatchReactor.ts
+3 -1
@@ -350,6 +350,7 @@ export const make = Effect.gen(function* () {
350 if (tail === undefined) {
351 const comments = new Map<string, PullRequestComment>();
352 const cursors = new Set<string>();
353 + let hidden = 0;
354 while (cursor !== null) {
355 if (cursors.has(cursor)) return null;
356 cursors.add(cursor);
@@ -366,9 +367,10 @@ export const make = Effect.gen(function* () {
367 reviewState: null,
368 });
369 }
370 + hidden += page.hiddenCount ?? 0;
371 cursor = page.nextCursor;
372 }
371 - if (thread.comments.length + comments.size < count) return null;
373 + if (thread.comments.length + comments.size + hidden < count) return null;
374 tail = { count, comments: [...comments.values()] };
375 }
376 tails.set(thread.id, tail);
apps/server/src/orchestration-v2/runtimeLayer.test.ts
+8 -3
@@ -4162,6 +4162,7 @@ it.layer(layerTest)("OrchestrationV2LayerLive lifecycle", (it) => {
4162 "repeated cursor",
4163 "missing comments",
4164 "thread list truncated",
4165 + "hidden reply",
4166 ])("wakes a watched thread once: %s", (mode) =>
4167 Effect.gen(function* () {
4168 const orchestrator = yield* Orchestrator.OrchestratorV2;
@@ -4237,7 +4238,7 @@ it.layer(layerTest)("OrchestrationV2LayerLive lifecycle", (it) => {
4238 body: "Twelfth reply.",
4239 createdAt: "2999-01-01T00:00:02.000Z",
4240 };
4240 - const incomplete = mode !== "single page" && mode !== "paginated";
4241 + const incomplete = mode !== "single page" && mode !== "paginated" && mode !== "hidden reply";
4242 let recovering = false;
4243 let pagesRead = 0;
4244 const reactor = yield* PullRequestWatchReactor.make.pipe(
@@ -4268,7 +4269,7 @@ it.layer(layerTest)("OrchestrationV2LayerLive lifecycle", (it) => {
4269 isResolved: false,
4270 isOutdated: false,
4271 comments: firstTen,
4271 - commentCount: 12,
4272 + commentCount: mode === "hidden reply" ? 13 : 12,
4273 nextCommentsCursor: "after-10",
4274 },
4275 ],
@@ -4295,7 +4296,11 @@ it.layer(layerTest)("OrchestrationV2LayerLive lifecycle", (it) => {
4296 if (!recovering && mode === "missing comments") {
4297 return Effect.succeed({ comments: [], nextCursor: null });
4298 }
4298 - return Effect.succeed({ comments: [eleventh, twelfth], nextCursor: null });
4299 + return Effect.succeed({
4300 + comments: [eleventh, twelfth],
4301 + nextCursor: null,
4302 + ...(mode === "hidden reply" ? { hiddenCount: 1 } : {}),
4303 + });
4304 },
4305 }),
4306 ),
packages/contracts/src/pullRequest.ts
+2
@@ -857,6 +857,8 @@ export type PullRequestThreadCommentsInput = typeof PullRequestThreadCommentsInp
857 export const PullRequestThreadCommentsResult = Schema.Struct({
858 comments: Schema.Array(PullRequestThreadComment),
859 nextCursor: Schema.NullOr(TrimmedNonEmptyString),
860 + // Comments the host hid that this page left out; the thread's `commentCount` still counts them.
861 + hiddenCount: Schema.optional(NonNegativeInt),
862 });
863 export type PullRequestThreadCommentsResult = typeof PullRequestThreadCommentsResult.Type;
864
packages/source-control-github/src/server/GitHubPullRequestApi.test.ts
+8 -1
@@ -350,6 +350,7 @@ function threadComments(
350 createdAt: "2026-07-01T00:00:00Z",
351 lastEditedAt: null,
352 url: `https://github.com/acme/web/pull/7#discussion_${id}`,
353 + isMinimized: false,
354 reactionGroups: [],
355 })),
356 };
@@ -1045,7 +1046,13 @@ layer("GitHubPullRequestApi.layer", (it) => {
1046 mergeable: "MERGEABLE",
1047 reviewDecision: null,
1048 latestReviews: {
1048 - nodes: [{ state: "APPROVED", author: { __typename: "User", login: "reviewer" } }],
1049 + nodes: [
1050 + {
1051 + state: "APPROVED",
1052 + isMinimized: false,
1053 + author: { __typename: "User", login: "reviewer" },
1054 + },
1055 + ],
1056 },
1057 additions: 12,
1058 deletions: 3,
packages/source-control-github/src/server/GitHubPullRequestApi.ts
+2 -2
@@ -2198,9 +2198,9 @@ export const make = Effect.gen(function* () {
2198 .pipe(
2199 graphql({ ...input, operation: "getReviewThreadComments" }),
2200 Effect.map(toReviewThreadCommentsPage),
2201 - Effect.flatMap(({ belongsToPullRequest, comments, nextCursor }) =>
2201 + Effect.flatMap(({ belongsToPullRequest, ...page }) =>
2202 belongsToPullRequest
2203 - ? Effect.succeed({ comments, nextCursor })
2203 + ? Effect.succeed(page)
2204 : Effect.fail(
2205 new GitHubSubjectScopeError({
2206 cwd: input.cwd,
packages/source-control-github/src/server/gitHubPullRequestJson.test.ts
+82 -3
@@ -108,6 +108,7 @@ const reactionGroups = (groups: ReadonlyArray<Json> | undefined) =>
108 const remark = ({ author, reactionGroups: groups, ...raw }: Json) => ({
109 body: "",
110 lastEditedAt: null,
111 + isMinimized: false,
112 url: "https://github.com/acme/web/pull/1#discussion",
113 ...raw,
114 author: actor(author),
@@ -172,6 +173,7 @@ const withReviewDefaults = (raw: string): string => {
173 latestReviews: {
174 nodes: nodesIn(latestReviews).map((node) => ({
175 state: "COMMENTED",
176 + isMinimized: false,
177 ...node,
178 author: actor(node["author"]),
179 })),
@@ -233,7 +235,16 @@ function listJson(entries: ReadonlyArray<Record<string, unknown>>): string {
235 ),
236 },
237 }),
236 - ...(latestReviews === undefined ? {} : { latestReviews: { nodes: latestReviews } }),
238 + ...(latestReviews === undefined
239 + ? {}
240 + : {
241 + latestReviews: {
242 + nodes: (latestReviews as ReadonlyArray<Json>).map((review) => ({
243 + isMinimized: false,
244 + ...review,
245 + })),
246 + },
247 + }),
248 ...(checks === undefined
249 ? {}
250 : { commits: { nodes: [{ commit: { statusCheckRollup: { state: checks } } }] } }),
@@ -283,6 +294,13 @@ describe("pull request list decoding", () => {
294 reviewDecision: null,
295 latestReviews: [{ author: user("octocat"), state: "COMMENTED" }],
296 },
297 + {
298 + reviewDecision: null,
299 + latestReviews: [
300 + { author: user("octocat"), state: "APPROVED" },
301 + { author: user("drive-by"), state: "CHANGES_REQUESTED", isMinimized: true },
302 + ],
303 + },
304 ]),
305 ),
306 );
@@ -291,6 +309,7 @@ describe("pull request list decoding", () => {
309 "changes-requested",
310 "approved",
311 null,
312 + "approved",
313 ]);
314 });
315
@@ -469,6 +488,7 @@ describe("pull request detail decoding", () => {
488 (comment) => ({
489 lastEditedAt: null,
490 url: "https://github.com/c",
491 + isMinimized: false,
492 author: null,
493 ...comment,
494 }),
@@ -480,6 +500,7 @@ describe("pull request detail decoding", () => {
500 (review) => ({
501 lastEditedAt: null,
502 url: "https://github.com/r",
503 + isMinimized: false,
504 author: null,
505 submittedAt: null,
506 ...review,
@@ -621,6 +642,29 @@ describe("pull request detail decoding", () => {
642 expect(detail.comments.map((comment) => comment.id)).toEqual(["c1", "r5"]);
643 });
644
645 + it("leaves out the comments and reviews a maintainer hid", () => {
646 + const detail = expectSuccess(
647 + activity({
648 + comments: [
649 + { id: "c1", body: "kept", createdAt: "2026-07-04T00:00:00Z" },
650 + { id: "c2", body: "spam", createdAt: "2026-07-05T00:00:00Z", isMinimized: true },
651 + ],
652 + reviews: [
653 + {
654 + id: "r1",
655 + body: "spam",
656 + state: "CHANGES_REQUESTED",
657 + submittedAt: "2026-07-03T00:00:00Z",
658 + isMinimized: true,
659 + },
660 + { id: "r2", body: "", state: "APPROVED", submittedAt: "2026-07-06T00:00:00Z" },
661 + ],
662 + }),
663 + );
664 +
665 + expect(detail.comments.map((comment) => comment.id)).toEqual(["c1", "r2"]);
666 + });
667 +
668 it.each(["APPROVED", "CHANGES_REQUESTED", "DISMISSED"])(
669 "keeps a bodyless %s review, which is the event itself",
670 (state) => {
@@ -860,6 +904,37 @@ describe("review thread decoding", () => {
904 expect(comments.map((comment) => comment.id)).toEqual(["t1", "t2"]);
905 });
906
907 + it("leaves out hidden thread comments, and a thread with none left", () => {
908 + const result = expectSuccess(
909 + decodeReviewThreadsJson(
910 + threadsJson([
911 + {
912 + id: "PRRT_hidden_root",
913 + path: "apps/server/src/ws.ts",
914 + comments: {
915 + nodes: [
916 + { id: "t1", createdAt: "2026-07-01T00:00:00Z", isMinimized: true },
917 + { id: "t2", createdAt: "2026-07-01T01:00:00Z" },
918 + ],
919 + },
920 + },
921 + {
922 + id: "PRRT_all_hidden",
923 + path: "apps/web/src/main.tsx",
924 + comments: {
925 + nodes: [{ id: "t3", createdAt: "2026-07-01T00:00:00Z", isMinimized: true }],
926 + },
927 + },
928 + ]),
929 + ),
930 + );
931 +
932 + expect(result.threads.map((entry) => [entry.thread.id, entry.commentCount])).toEqual([
933 + ["PRRT_hidden_root", 1],
934 + ]);
935 + expect(result.threads[0]?.thread.comments.map((comment) => comment.id)).toEqual(["t2"]);
936 + });
937 +
938 it("keeps GitHub's own count of a thread whose comments were not all read", () => {
939 const result = expectSuccess(
940 decodeReviewThreadsJson(
@@ -883,7 +958,7 @@ describe("review thread decoding", () => {
958 });
959 });
960
886 - it("ends a thread's walk on the last page, which still names a cursor", () => {
961 + it("ends a thread's walk on the last page, which still names a cursor, counting what it hid", () => {
962 const decoded = expectSuccess(
963 decodeReviewThreadCommentsJson(
964 JSON.stringify({
@@ -893,7 +968,10 @@ describe("review thread decoding", () => {
968 pullRequest: { id: "PR_1" },
969 comments: {
970 pageInfo: { hasNextPage: false, endCursor: "Y3Vyc29yOjk" },
896 - nodes: [{ id: "t9", body: "last", createdAt: "2026-07-01T00:00:00Z" }],
971 + nodes: [
972 + { id: "t8", body: "spam", createdAt: "2026-07-01T00:00:00Z", isMinimized: true },
973 + { id: "t9", body: "last", createdAt: "2026-07-01T00:00:00Z" },
974 + ],
975 },
976 },
977 },
@@ -901,6 +979,7 @@ describe("review thread decoding", () => {
979 ),
980 );
981 expect(decoded.comments.map((comment) => comment.id)).toEqual(["t9"]);
982 + expect(decoded.hiddenCount).toBe(1);
983 expect(decoded.nextCursor).toBeNull();
984 });
985 });
packages/source-control-github/src/server/gitHubPullRequestJson.ts
+38 -17
@@ -123,6 +123,7 @@ interface ReviewRequestFields {
123
124 interface LatestReviewFields {
125 readonly state?: string | null | undefined;
126 + readonly isMinimized?: boolean | undefined;
127 }
128
129 /** Check runs use status/conclusion; commit statuses use a single state. */
@@ -509,14 +510,21 @@ export function toPullRequestActionSummary(
510 };
511 }
512
512 -/** Prefer GitHub's reviewDecision; only use latest reviews when it is absent (e.g. bot approvals). */
513 +/**
514 + * Prefer GitHub's reviewDecision; only use latest reviews when it is absent (e.g. bot approvals).
515 + * A review a maintainer hid casts no verdict.
516 + */
517 function toReviewDecisionWithReviews(
518 value: string | null | undefined,
519 reviews: ReadonlyArray<LatestReviewFields> | undefined,
520 ): PullRequestReviewDecision | null {
521 const summarized = toReviewDecision(value);
522 if (summarized === "approved" || summarized === "changes-requested") return summarized;
519 - const states = new Set((reviews ?? []).map((review) => review.state?.trim().toUpperCase() ?? ""));
523 + const states = new Set(
524 + (reviews ?? [])
525 + .filter((review) => !review.isMinimized)
526 + .map((review) => review.state?.trim().toUpperCase() ?? ""),
527 + );
528 if (states.has("CHANGES_REQUESTED")) return "changes-requested";
529 if (summarized === null && states.has("APPROVED")) return "approved";
530 return summarized;
@@ -665,30 +673,36 @@ interface RemarkFields {
673 readonly author: ActorFields | null;
674 readonly body: string;
675 readonly url: string | null;
676 + readonly isMinimized: boolean;
677 }
678
679 +// Hidden (minimized) remarks are left out, as github.com collapses them: a maintainer marked them
680 +// spam, off-topic, or outdated, and they should not reach readers or agents.
681 function toComments(raw: {
682 readonly comments: ReadonlyArray<RemarkFields & { readonly createdAt: string }>;
683 readonly reviews: ReadonlyArray<
684 RemarkFields & { readonly state: string; readonly submittedAt: string | null }
685 >;
686 }): ReadonlyArray<PullRequestComment> {
676 - const issueComments = raw.comments.map((comment): PullRequestComment => ({
677 - id: comment.id,
678 - kind: "issue-comment",
679 - author: toActor(comment.author),
680 - body: comment.body ?? "",
681 - createdAt: comment.createdAt,
682 - editedAt: comment.lastEditedAt ?? null,
683 - url: trimmed(comment.url),
684 - path: null,
685 - reviewState: null,
686 - }));
687 + const issueComments = raw.comments
688 + .filter((comment) => !comment.isMinimized)
689 + .map((comment): PullRequestComment => ({
690 + id: comment.id,
691 + kind: "issue-comment",
692 + author: toActor(comment.author),
693 + body: comment.body ?? "",
694 + createdAt: comment.createdAt,
695 + editedAt: comment.lastEditedAt ?? null,
696 + url: trimmed(comment.url),
697 + path: null,
698 + reviewState: null,
699 + }));
700 // Bodiless COMMENTED reviews only hold line comments read separately.
701 const reviews = raw.reviews.flatMap((review): ReadonlyArray<PullRequestComment> => {
702 const submittedAt = trimmed(review.submittedAt);
703 const reviewState = trimmed(review.state);
704 if (
705 + review.isMinimized ||
706 submittedAt === null ||
707 ((review.body ?? "").trim().length === 0 && !isReviewVerdict(reviewState))
708 ) {
@@ -1321,7 +1335,9 @@ function toReviewThreadEntries(threads: ReviewThreadPage, viewer: string | null)
1335 const entries = threadNodes.flatMap((thread): ReadonlyArray<GitHubReviewThreadEntry> => {
1336 const path = trimmed(thread.path);
1337 const id = trimmed(thread.id);
1324 - const comments = nodesOf(thread.comments);
1338 + const loaded = nodesOf(thread.comments);
1339 + // Hidden comments are left out, as in `toComments`; a thread with none left is dropped.
1340 + const comments = loaded.filter((comment) => !comment.isMinimized);
1341 if (path === null || id === null || comments.length === 0) return [];
1342 return [
1343 {
@@ -1335,7 +1351,7 @@ function toReviewThreadEntries(threads: ReviewThreadPage, viewer: string | null)
1351 isOutdated: thread.isOutdated,
1352 comments: comments.map((comment) => toThreadComment(comment, viewer)),
1353 },
1338 - commentCount: thread.comments.totalCount,
1354 + commentCount: thread.comments.totalCount - (loaded.length - comments.length),
1355 nextCommentCursor: nextCursorOf(thread.comments.pageInfo),
1356 },
1357 ];
@@ -1381,7 +1397,8 @@ export function toReviewThreadPage(result: ReviewThreads.Result): GitHubReviewTh
1397 const requestedReviewers = nodesOf(pullRequest.reviewRequests).map(
1398 (node): ActorFields | null => node.requestedReviewer,
1399 );
1384 - const latestReviews = nodesOf(pullRequest.latestReviews);
1400 + // Someone whose review was hidden is not listed as a reviewer.
1401 + const latestReviews = nodesOf(pullRequest.latestReviews).filter((node) => !node.isMinimized);
1402 const comments = nodesOf(pullRequest.comments);
1403 const reviews = nodesOf(pullRequest.reviews);
1404 const { avatarsByLogin, botLogins } = collectActors([
@@ -1439,14 +1456,18 @@ export function toReviewThreadPage(result: ReviewThreads.Result): GitHubReviewTh
1456 export function toReviewThreadCommentsPage(result: ReviewThreadComments.Result): {
1457 readonly belongsToPullRequest: boolean;
1458 readonly comments: ReadonlyArray<PullRequestThreadComment>;
1459 + readonly hiddenCount: number;
1460 readonly nextCursor: string | null;
1461 } {
1462 const viewer = trimmed(result.viewer.login);
1463 const thread = result.node?.__typename === "PullRequestReviewThread" ? result.node : null;
1464 const pullRequestId = result.repository?.pullRequest?.id;
1465 + const loaded = nodesOf(thread?.comments);
1466 + const comments = loaded.filter((comment) => !comment.isMinimized);
1467 return {
1468 belongsToPullRequest: pullRequestId !== undefined && pullRequestId === thread?.pullRequest.id,
1449 - comments: nodesOf(thread?.comments).map((comment) => toThreadComment(comment, viewer)),
1469 + comments: comments.map((comment) => toThreadComment(comment, viewer)),
1470 + hiddenCount: loaded.length - comments.length,
1471 nextCursor: nextCursorOf(thread?.comments.pageInfo),
1472 };
1473 }
packages/source-control-github/src/server/pullRequestBatches.graphql
+1
@@ -30,6 +30,7 @@ query PullRequestSummary($owner: String!, $name: String!, $number: Int!, $stacks
30 latestReviews(first: 20) {
31 nodes {
32 state
33 + isMinimized
34 author {
35 login
36 }
packages/source-control-github/src/server/pullRequestBatches.graphql.ts
+3 -1
@@ -37,6 +37,8 @@ export interface Actor extends Schema.Struct.Type<typeof Actor.fields> {}
37 export const LatestReviewsNodesPullRequestReview = Schema.Struct({
38 /** Identifies the current state of the pull request review. */
39 state: GraphQL.enumLiterals(Shared.PullRequestReviewState.literals),
40 + /** Returns whether or not a comment has been minimized. */
41 + isMinimized: Schema.Boolean,
42 /** The actor who authored the comment. */
43 author: Schema.NullOr(Actor)
44 })
@@ -160,7 +162,7 @@ export const PullRequestSummary = GraphQL.query("PullRequestSummary", {
162 { name: "stacks", body: "Boolean!" }
163 ],
164 selections: [
163 - { name: "repository", body: ["(owner:$", "owner", " name:$", "name", "){pullRequest(number:$", "number", "){number title url state isDraft mergeable reviewDecision additions deletions changedFiles updatedAt mergedAt closedAt headRefName baseRefName author{__typename login avatarUrl...on User{name}}latestReviews(first:20){nodes{state author{__typename login}}}commits(last:1){nodes{commit{statusCheckRollup{state}}}}stack@include(if:$", "stacks", "){number size baseRefName}stackEntry@include(if:$", "stacks", "){position}}}"] }
165 + { name: "repository", body: ["(owner:$", "owner", " name:$", "name", "){pullRequest(number:$", "number", "){number title url state isDraft mergeable reviewDecision additions deletions changedFiles updatedAt mergedAt closedAt headRefName baseRefName author{__typename login avatarUrl...on User{name}}latestReviews(first:20){nodes{state isMinimized author{__typename login}}}commits(last:1){nodes{commit{statusCheckRollup{state}}}}stack@include(if:$", "stacks", "){number size baseRefName}stackEntry@include(if:$", "stacks", "){position}}}"] }
166 ],
167 fragments: []
168 },
packages/source-control-github/src/server/pullRequestListings.graphql
+1
@@ -37,6 +37,7 @@ fragment PullRequestRow on PullRequest {
37 latestReviews(first: 20) {
38 nodes {
39 state
40 + isMinimized
41 author {
42 login
43 }
packages/source-control-github/src/server/pullRequestListings.graphql.ts
+4 -2
@@ -55,6 +55,8 @@ export interface Actor extends Schema.Struct.Type<typeof Actor.fields> {}
55 export const PullRequestReview = Schema.Struct({
56 /** Identifies the current state of the pull request review. */
57 state: GraphQL.enumLiterals(Shared.PullRequestReviewState.literals),
58 + /** Returns whether or not a comment has been minimized. */
59 + isMinimized: Schema.Boolean,
60 /** The actor who authored the comment. */
61 author: Schema.NullOr(Actor)
62 })
@@ -266,7 +268,7 @@ export const PullRequestSearch = GraphQL.query("PullRequestSearch", {
268 { name: "search", body: ["(query:$", "q", " type:ISSUE first:$", "first", " after:$", "after", "){pageInfo{hasNextPage endCursor}nodes{__typename...", "PullRequestRow", "}}"] }
269 ],
270 fragments: [
269 - { name: "PullRequestRow", body: ["on PullRequest{stack@include(if:$", "stacks", "){number size baseRefName}stackEntry@include(if:$", "stacks", "){position}number title url author{__typename login avatarUrl...on User{name}}headRefName baseRefName state isDraft mergeable reviewDecision latestReviews(first:20){nodes{state author{__typename login}}}additions@include(if:$", "stats", ")deletions@include(if:$", "stats", ")createdAt updatedAt mergedAt repository{nameWithOwner}reviewRequests(first:20){nodes{requestedReviewer{__typename...on User{login}...on Team{slug}}}}labels(first:20){nodes{name color}}commits(last:1){nodes{commit{statusCheckRollup{state}}}}}"] }
271 + { name: "PullRequestRow", body: ["on PullRequest{stack@include(if:$", "stacks", "){number size baseRefName}stackEntry@include(if:$", "stacks", "){position}number title url author{__typename login avatarUrl...on User{name}}headRefName baseRefName state isDraft mergeable reviewDecision latestReviews(first:20){nodes{state isMinimized author{__typename login}}}additions@include(if:$", "stats", ")deletions@include(if:$", "stats", ")createdAt updatedAt mergedAt repository{nameWithOwner}reviewRequests(first:20){nodes{requestedReviewer{__typename...on User{login}...on Team{slug}}}}labels(first:20){nodes{name color}}commits(last:1){nodes{commit{statusCheckRollup{state}}}}}"] }
272 ]
273 },
274 variables: {
@@ -318,7 +320,7 @@ export const PullRequestList = GraphQL.query("PullRequestList", {
320 { name: "repository", body: ["(owner:$", "owner", " name:$", "name", "){pullRequests(first:$", "first", " after:$", "after", " states:$", "states", " orderBy:{field:CREATED_AT direction:DESC}){pageInfo{hasNextPage endCursor}nodes{...", "PullRequestRow", "}}}"] }
321 ],
322 fragments: [
321 - { name: "PullRequestRow", body: ["on PullRequest{stack@include(if:$", "stacks", "){number size baseRefName}stackEntry@include(if:$", "stacks", "){position}number title url author{__typename login avatarUrl...on User{name}}headRefName baseRefName state isDraft mergeable reviewDecision latestReviews(first:20){nodes{state author{__typename login}}}additions@include(if:$", "stats", ")deletions@include(if:$", "stats", ")createdAt updatedAt mergedAt repository{nameWithOwner}reviewRequests(first:20){nodes{requestedReviewer{__typename...on User{login}...on Team{slug}}}}labels(first:20){nodes{name color}}commits(last:1){nodes{commit{statusCheckRollup{state}}}}}"] }
323 + { name: "PullRequestRow", body: ["on PullRequest{stack@include(if:$", "stacks", "){number size baseRefName}stackEntry@include(if:$", "stacks", "){position}number title url author{__typename login avatarUrl...on User{name}}headRefName baseRefName state isDraft mergeable reviewDecision latestReviews(first:20){nodes{state isMinimized author{__typename login}}}additions@include(if:$", "stats", ")deletions@include(if:$", "stats", ")createdAt updatedAt mergedAt repository{nameWithOwner}reviewRequests(first:20){nodes{requestedReviewer{__typename...on User{login}...on Team{slug}}}}labels(first:20){nodes{name color}}commits(last:1){nodes{commit{statusCheckRollup{state}}}}}"] }
324 ]
325 },
326 variables: {
packages/source-control-github/src/server/pullRequestReads.graphql
+2
@@ -274,6 +274,7 @@ query PullRequestActivity(
274 createdAt
275 lastEditedAt
276 url
277 + isMinimized
278 author {
279 login
280 avatarUrl
@@ -295,6 +296,7 @@ query PullRequestActivity(
296 submittedAt
297 lastEditedAt
298 url
299 + isMinimized
300 author {
301 login
302 avatarUrl
packages/source-control-github/src/server/pullRequestReads.graphql.ts
+5 -1
@@ -724,6 +724,8 @@ export const NodesIssueComment = Schema.Struct({
724 lastEditedAt: Schema.NullOr(Shared.DateTime),
725 /** The HTTP URL for this issue comment */
726 url: Shared.URI,
727 + /** Returns whether or not a comment has been minimized. */
728 + isMinimized: Schema.Boolean,
729 /** The actor who authored the comment. */
730 author: Schema.NullOr(Schema.Union([
731 PullRequestPreviewRepositoryPullRequestAuthorUser,
@@ -755,6 +757,8 @@ export const NodesPullRequestReview = Schema.Struct({
757 lastEditedAt: Schema.NullOr(Shared.DateTime),
758 /** The HTTP URL permalink for this PullRequestReview. */
759 url: Shared.URI,
760 + /** Returns whether or not a comment has been minimized. */
761 + isMinimized: Schema.Boolean,
762 /** The actor who authored the comment. */
763 author: Schema.NullOr(Schema.Union([
764 PullRequestPreviewRepositoryPullRequestAuthorUser,
@@ -809,7 +813,7 @@ export const PullRequestActivity = GraphQL.query("PullRequestActivity", {
813 { name: "reviewsAfter", body: "String" }
814 ],
815 selections: [
812 - { name: "repository", body: ["(owner:$", "owner", " name:$", "name", "){pullRequest(number:$", "number", "){author@include(if:$", "head", "){__typename login avatarUrl...on User{name}}commits(last:100)@include(if:$", "head", "){nodes{commit{id oid messageHeadline committedDate parents(first:1){totalCount}authors(first:10){nodes{name email user{login}}}}}}comments(first:100 after:$", "commentsAfter", ")@include(if:$", "withComments", "){pageInfo{hasNextPage endCursor}nodes{id body createdAt lastEditedAt url author{__typename login avatarUrl...on User{name}}}}reviews(first:100 after:$", "reviewsAfter", ")@include(if:$", "withReviews", "){pageInfo{hasNextPage endCursor}nodes{id body state submittedAt lastEditedAt url author{__typename login avatarUrl...on User{name}}}}}}"] }
816 + { name: "repository", body: ["(owner:$", "owner", " name:$", "name", "){pullRequest(number:$", "number", "){author@include(if:$", "head", "){__typename login avatarUrl...on User{name}}commits(last:100)@include(if:$", "head", "){nodes{commit{id oid messageHeadline committedDate parents(first:1){totalCount}authors(first:10){nodes{name email user{login}}}}}}comments(first:100 after:$", "commentsAfter", ")@include(if:$", "withComments", "){pageInfo{hasNextPage endCursor}nodes{id body createdAt lastEditedAt url isMinimized author{__typename login avatarUrl...on User{name}}}}reviews(first:100 after:$", "reviewsAfter", ")@include(if:$", "withReviews", "){pageInfo{hasNextPage endCursor}nodes{id body state submittedAt lastEditedAt url isMinimized author{__typename login avatarUrl...on User{name}}}}}}"] }
817 ],
818 fragments: []
819 },
packages/source-control-github/src/server/pullRequestReviews.graphql
+2
@@ -37,6 +37,7 @@ fragment ThreadComment on PullRequestReviewComment {
37 createdAt
38 lastEditedAt
39 url
40 + isMinimized
41 ...Reactions
42 }
43
@@ -151,6 +152,7 @@ query ReviewThreads($owner: String!, $name: String!, $number: Int!, $requestedRe
152 latestReviews(first: 50) {
153 nodes {
154 state
155 + isMinimized
156 author {
157 __typename
158 login
packages/source-control-github/src/server/pullRequestReviews.graphql.ts
+8 -4
@@ -107,6 +107,8 @@ export const ThreadComment = Schema.Struct({
107 lastEditedAt: Schema.NullOr(Shared.DateTime),
108 /** The HTTP URL permalink for this review comment. */
109 url: Shared.URI,
110 + /** Returns whether or not a comment has been minimized. */
111 + isMinimized: Schema.Boolean,
112 /** A list of reactions grouped by content left on the subject. */
113 reactionGroups: Schema.NullOr(Schema.Array(ReactionGroup))
114 })
@@ -276,6 +278,8 @@ export interface ReviewRequestConnection extends Schema.Struct.Type<typeof Revie
278 export const LatestReviewsNodesPullRequestReview = Schema.Struct({
279 /** Identifies the current state of the pull request review. */
280 state: GraphQL.enumLiterals(Shared.PullRequestReviewState.literals),
281 + /** Returns whether or not a comment has been minimized. */
282 + isMinimized: Schema.Boolean,
283 /** The actor who authored the comment. */
284 author: Schema.NullOr(Actor)
285 })
@@ -416,12 +420,12 @@ export const ReviewThreads = GraphQL.query("ReviewThreads", {
420 ],
421 selections: [
422 { name: "viewer", body: ["{login}"] },
419 - { name: "repository", body: ["(owner:$", "owner", " name:$", "name", "){pullRequest(number:$", "number", "){reviewThreads(first:100){...ReviewThreadPage}viewerCanUpdate viewerDidAuthor author{__typename login avatarUrl}...Reactions comments(first:100){nodes{id lastEditedAt author{__typename login avatarUrl}...Reactions}}reviews(first:100){nodes{id lastEditedAt author{__typename login avatarUrl}...Reactions}}reviewRequests(first:$", "requestedReviewers", "){nodes{requestedReviewer{__typename...on User{login name avatarUrl}...on Bot{login avatarUrl}...on Team{combinedSlug teamName:name teamAvatarUrl:avatarUrl}}}}latestReviews(first:50){nodes{state author{__typename login avatarUrl}}}reviewDismissals:timelineItems(itemTypes:[REVIEW_DISMISSED_EVENT]first:100){pageInfo{hasNextPage endCursor}nodes{__typename...on ReviewDismissedEvent{dismissalMessage review{id}}}}commits(last:100){nodes{commit{oid messageHeadline committedDate authors(first:3){nodes{name avatarUrl user{login}}}}}}}}"] }
423 + { name: "repository", body: ["(owner:$", "owner", " name:$", "name", "){pullRequest(number:$", "number", "){reviewThreads(first:100){...ReviewThreadPage}viewerCanUpdate viewerDidAuthor author{__typename login avatarUrl}...Reactions comments(first:100){nodes{id lastEditedAt author{__typename login avatarUrl}...Reactions}}reviews(first:100){nodes{id lastEditedAt author{__typename login avatarUrl}...Reactions}}reviewRequests(first:$", "requestedReviewers", "){nodes{requestedReviewer{__typename...on User{login name avatarUrl}...on Bot{login avatarUrl}...on Team{combinedSlug teamName:name teamAvatarUrl:avatarUrl}}}}latestReviews(first:50){nodes{state isMinimized author{__typename login avatarUrl}}}reviewDismissals:timelineItems(itemTypes:[REVIEW_DISMISSED_EVENT]first:100){pageInfo{hasNextPage endCursor}nodes{__typename...on ReviewDismissedEvent{dismissalMessage review{id}}}}commits(last:100){nodes{commit{oid messageHeadline committedDate authors(first:3){nodes{name avatarUrl user{login}}}}}}}}"] }
424 ],
425 fragments: [
426 { name: "ReviewThreadPage", body: ["on PullRequestReviewThreadConnection{totalCount pageInfo{hasNextPage endCursor}nodes{id isResolved isOutdated path line diffSide comments(first:10){totalCount pageInfo{hasNextPage endCursor}nodes{...ThreadComment}}}}"] },
427 { name: "Reactions", body: ["on Reactable{__typename reactionGroups{content viewerHasReacted reactors(first:10){totalCount nodes{__typename...on User{login}...on Bot{login}...on Organization{login}...on Mannequin{login}}}}}"] },
424 - { name: "ThreadComment", body: ["on PullRequestReviewComment{id author{__typename login avatarUrl}body createdAt lastEditedAt url...Reactions}"] }
428 + { name: "ThreadComment", body: ["on PullRequestReviewComment{id author{__typename login avatarUrl}body createdAt lastEditedAt url isMinimized...Reactions}"] }
429 ]
430 },
431 variables: {
@@ -471,7 +475,7 @@ export const ReviewThreadPages = GraphQL.query("ReviewThreadPages", {
475 ],
476 fragments: [
477 { name: "ReviewThreadPage", body: ["on PullRequestReviewThreadConnection{totalCount pageInfo{hasNextPage endCursor}nodes{id isResolved isOutdated path line diffSide comments(first:10){totalCount pageInfo{hasNextPage endCursor}nodes{...ThreadComment}}}}"] },
474 - { name: "ThreadComment", body: ["on PullRequestReviewComment{id author{__typename login avatarUrl}body createdAt lastEditedAt url...Reactions}"] },
478 + { name: "ThreadComment", body: ["on PullRequestReviewComment{id author{__typename login avatarUrl}body createdAt lastEditedAt url isMinimized...Reactions}"] },
479 { name: "Reactions", body: ["on Reactable{__typename reactionGroups{content viewerHasReacted reactors(first:10){totalCount nodes{__typename...on User{login}...on Bot{login}...on Organization{login}...on Mannequin{login}}}}}"] }
480 ]
481 },
@@ -548,7 +552,7 @@ export const ReviewThreadComments = GraphQL.query("ReviewThreadComments", {
552 { name: "node", body: ["(id:$", "threadId", "){__typename...on PullRequestReviewThread{pullRequest{id}comments(first:100 after:$", "after", "){pageInfo{hasNextPage endCursor}nodes{...ThreadComment}}}}"] }
553 ],
554 fragments: [
551 - { name: "ThreadComment", body: ["on PullRequestReviewComment{id author{__typename login avatarUrl}body createdAt lastEditedAt url...Reactions}"] },
555 + { name: "ThreadComment", body: ["on PullRequestReviewComment{id author{__typename login avatarUrl}body createdAt lastEditedAt url isMinimized...Reactions}"] },
556 { name: "Reactions", body: ["on Reactable{__typename reactionGroups{content viewerHasReacted reactors(first:10){totalCount nodes{__typename...on User{login}...on Bot{login}...on Organization{login}...on Mannequin{login}}}}}"] }
557 ]
558 },