The best way to control Claude Code, Codex and more from any computer or phone
Mirrored from https://github.com/Camo67/t3code.git
Synced Nov 21, 08:30 UTC
fix(server): process group metrics no longer warn at every startup (#38026)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Martin Bergo committed
Nov 17, 2026 at 10:29 UTC
25da86c29b8df671ec85aa3523aa581a1a1e3e72
2 files changed
+48
-26
apps/server/src/resourceTelemetry/ProcessGroupMetrics.test.ts
+44
-24
@@ -1,5 +1,6 @@
1
import { assert, describe, it } from "@effect/vitest";
2
import type { ResourceTelemetryProcess, ResourceTelemetrySnapshot } from "@t3tools/contracts";
3
+import * as Clock from "effect/Clock";
4
import * as Effect from "effect/Effect";
5
import * as Layer from "effect/Layer";
6
import * as Logger from "effect/Logger";
@@ -69,27 +70,20 @@ describe("groupProcesses", () => {
70
});
71
72
describe("ProcessGroupMetrics.layer", () => {
72
- it.effect("logs the first failed sample and the recovery, not every repeat", () => {
73
+ const notRunning = new ResourceTelemetry.ResourceTelemetryRefreshFailed({
74
+ operation: "refresh",
75
+ cause: new Error("Resource monitor is unavailable: sidecar is not running"),
76
+ });
77
+ const logsAfter = (
78
+ refresh: ResourceTelemetry.ResourceTelemetry["Service"]["refresh"],
79
+ afterStart: Effect.Effect<void>,
80
+ ) => {
81
const logs: Array<string> = [];
82
const logger = Logger.make(({ logLevel, message }) => {
83
logs.push(`${logLevel.toUpperCase()} ${String([message].flat()[0])}`);
84
});
85
+ const telemetry = { refresh } as unknown as ResourceTelemetry.ResourceTelemetry["Service"];
86
return Effect.gen(function* () {
78
- const outcomes = yield* Ref.make<ReadonlyArray<"fail" | "ok">>(["fail", "fail", "ok"]);
79
- const refresh = Ref.modify(outcomes, ([next = "ok", ...rest]) => [next, rest] as const).pipe(
80
- Effect.flatMap((next) =>
81
- next === "fail"
82
- ? Effect.fail(
83
- new ResourceTelemetry.ResourceTelemetryRefreshFailed({
84
- operation: "refresh",
85
- cause: new Error("Resource monitor binary was not found for darwin/arm64."),
86
- }),
87
- )
88
- : Effect.succeed({ processes: [] } as unknown as ResourceTelemetrySnapshot),
89
- ),
90
- );
91
- const telemetry = { refresh } as unknown as ResourceTelemetry.ResourceTelemetry["Service"];
92
-
87
yield* Layer.build(
88
ProcessGroupMetrics.layer.pipe(
89
Layer.provide(Layer.succeed(ResourceTelemetry.ResourceTelemetry, telemetry)),
@@ -100,13 +94,8 @@ describe("ProcessGroupMetrics.layer", () => {
94
),
95
),
96
);
103
- yield* TestClock.adjust("3 minutes");
104
-
105
- assert.deepStrictEqual(logs, [
106
- "WARN process group metrics are not exported: sample failed",
107
- "DEBUG process group metrics sample failed",
108
- "INFO process group metrics sample recovered",
109
- ]);
97
+ yield* afterStart;
98
+ return logs;
99
}).pipe(
100
Effect.scoped,
101
Effect.provide(
@@ -116,5 +105,36 @@ describe("ProcessGroupMetrics.layer", () => {
105
),
106
),
107
);
119
- });
108
+ };
109
+ const emptySnapshot = { processes: [] } as unknown as ResourceTelemetrySnapshot;
110
+
111
+ it.effect("logs the first failed sample and the recovery, not every repeat", () =>
112
+ Effect.gen(function* () {
113
+ const outcomes = yield* Ref.make<ReadonlyArray<"fail" | "ok">>(["fail", "fail", "ok"]);
114
+ const refresh = Ref.modify(outcomes, ([next = "ok", ...rest]) => [next, rest] as const).pipe(
115
+ Effect.flatMap((next) =>
116
+ next === "fail" ? Effect.fail(notRunning) : Effect.succeed(emptySnapshot),
117
+ ),
118
+ );
119
+ const logs = yield* logsAfter(refresh, TestClock.adjust("3 minutes"));
120
+ assert.deepStrictEqual(logs, [
121
+ "WARN process group metrics are not exported: sample failed",
122
+ "DEBUG process group metrics sample failed",
123
+ "INFO process group metrics sample recovered",
124
+ ]);
125
+ }),
126
+ );
127
+
128
+ it.effect("does not report the sidecar as failed while it is still starting", () =>
129
+ Effect.gen(function* () {
130
+ // The sidecar answers once its handshake completes, a few seconds after the server starts.
131
+ const refresh = Clock.currentTimeMillis.pipe(
132
+ Effect.flatMap((now) =>
133
+ now >= 5_000 ? Effect.succeed(emptySnapshot) : Effect.fail(notRunning),
134
+ ),
135
+ );
136
+ const logs = yield* logsAfter(refresh, TestClock.adjust("1 minute"));
137
+ assert.deepStrictEqual(logs, []);
138
+ }),
139
+ );
140
});
apps/server/src/resourceTelemetry/ProcessGroupMetrics.ts
+4
-2
@@ -134,10 +134,12 @@ export const layer = Layer.effectDiscard(
134
Effect.annotateLogs({ operation: error.operation }),
135
);
136
};
137
- yield* sample().pipe(
137
+ // The first sample waits one interval: the resource monitor sidecar starts with the server
138
+ // and cannot answer until its handshake completes.
139
+ yield* Effect.sleep(SAMPLE_INTERVAL).pipe(
140
+ Effect.andThen(sample()),
141
Effect.andThen(recordSuccess),
142
Effect.catch(recordFailure),
140
- Effect.andThen(Effect.sleep(SAMPLE_INTERVAL)),
143
Effect.forever,
144
Effect.forkScoped,
145
);