@devries-cameron20 / t3code Mirror · read-only / commits / 2d558c4dad
Fork 0

The best way to control Claude Code, Codex and more from any computer or phone

Mirrored from https://github.com/Camo67/t3code.git

Synced Nov 21, 07:15 UTC

fix(web): the issue viewer shows why a refresh failed (#38537)

Co-authored-by: Julius Marminge <julius0216@outlook.com>

Wout Stiens committed Nov 18, 2026 at 11:35 UTC 2d558c4dad93f59cd03b5c3c9b3372555a503c84
12 files changed +145
apps/web/src/components/issue/IssueDetailPanel.tsx
+10
@@ -50,6 +50,7 @@ import { threadEnvironment } from "~/state/threads";
50 import { useAtomCommand } from "~/state/use-atom-command";
51 import { formatRelativeTimeLabel } from "~/timestampFormat";
52
53 +import { Alert, AlertDescription, AlertTitle } from "../ui/alert";
54 import { Button, InlineButton } from "../ui/button";
55 import { Input } from "../ui/input";
56 import { Menu, MenuItem, MenuPopup, MenuTrigger } from "../ui/menu";
@@ -667,6 +668,15 @@ export function IssueDetailPanel({
668 </Button>
669 </PullRequestDetailTitleRow>
670
671 + {detailQuery.error !== null && !detailQuery.isPending ? (
672 + <div className="mt-2">
673 + <Alert variant="error">
674 + <AlertTitle>{gt("Could not refresh this issue")}</AlertTitle>
675 + <AlertDescription>{detailQuery.error}</AlertDescription>
676 + </Alert>
677 + </div>
678 + ) : null}
679 +
680 {editing === "title" ? (
681 <form
682 className="mt-1 flex items-center gap-2"
apps/web/src/i18n/translations/de.json
+1
@@ -5681,6 +5681,7 @@
5681 "217e1e7b60469736": "Issue-Status, {state}",
5682 "a98a269e3061a069": "{issue} auf {provider} öffnen",
5683 "c1ff5afd83b1e027": "Issue aktualisieren",
5684 + "8ab83a75cae667a2": "Dieses Issue konnte nicht aktualisiert werden",
5685 "78398e2d7d040498": "Issue-Titel",
5686 "7b4fa0f856528bb0": "Titel bearbeiten",
5687 "c78c0974dbdb66c2": "Labels",
apps/web/src/i18n/translations/en.json
+1
@@ -5682,6 +5682,7 @@
5682 "217e1e7b60469736": "Issue state, {state}",
5683 "a98a269e3061a069": "Open {issue} on {provider}",
5684 "c1ff5afd83b1e027": "Refresh issue",
5685 + "8ab83a75cae667a2": "Could not refresh this issue",
5686 "78398e2d7d040498": "Issue title",
5687 "7b4fa0f856528bb0": "Edit title",
5688 "c78c0974dbdb66c2": "Labels",
apps/web/src/i18n/translations/es.json
+1
@@ -5680,6 +5680,7 @@
5680 "217e1e7b60469736": "Estado de la issue, {state}",
5681 "a98a269e3061a069": "Abrir {issue} en {provider}",
5682 "c1ff5afd83b1e027": "Actualizar issue",
5683 + "8ab83a75cae667a2": "No se pudo actualizar esta issue",
5684 "78398e2d7d040498": "Título de la issue",
5685 "7b4fa0f856528bb0": "Editar título",
5686 "c78c0974dbdb66c2": "Etiquetas",
apps/web/src/i18n/translations/fr.json
+1
@@ -5681,6 +5681,7 @@
5681 "217e1e7b60469736": "État du ticket, {state}",
5682 "a98a269e3061a069": "Ouvrir {issue} sur {provider}",
5683 "c1ff5afd83b1e027": "Actualiser le ticket",
5684 + "8ab83a75cae667a2": "Impossible d’actualiser ce ticket",
5685 "78398e2d7d040498": "Titre du ticket",
5686 "7b4fa0f856528bb0": "Modifier le titre",
5687 "c78c0974dbdb66c2": "Libellés",
apps/web/src/i18n/translations/ja.json
+1
@@ -5663,6 +5663,7 @@
5663 "217e1e7b60469736": "Issue の状態、{state}",
5664 "a98a269e3061a069": "{provider} で {issue} を開く",
5665 "c1ff5afd83b1e027": "Issue を更新",
5666 + "8ab83a75cae667a2": "この Issue を更新できませんでした",
5667 "78398e2d7d040498": "Issue のタイトル",
5668 "7b4fa0f856528bb0": "タイトルを編集",
5669 "c78c0974dbdb66c2": "ラベル",
apps/web/src/i18n/translations/ko.json
+1
@@ -5661,6 +5661,7 @@
5661 "217e1e7b60469736": "이슈 상태, {state}",
5662 "a98a269e3061a069": "{provider}에서 {issue} 열기",
5663 "c1ff5afd83b1e027": "이슈 새로 고침",
5664 + "8ab83a75cae667a2": "이 이슈를 새로고침할 수 없습니다",
5665 "78398e2d7d040498": "이슈 제목",
5666 "7b4fa0f856528bb0": "제목 편집",
5667 "c78c0974dbdb66c2": "레이블",
apps/web/src/i18n/translations/pt-BR.json
+1
@@ -5680,6 +5680,7 @@
5680 "217e1e7b60469736": "Estado da issue, {state}",
5681 "a98a269e3061a069": "Abrir {issue} no {provider}",
5682 "c1ff5afd83b1e027": "Atualizar issue",
5683 + "8ab83a75cae667a2": "Não foi possível atualizar esta issue",
5684 "78398e2d7d040498": "Título da issue",
5685 "7b4fa0f856528bb0": "Editar título",
5686 "c78c0974dbdb66c2": "Rótulos",
apps/web/src/i18n/translations/ru.json
+1
@@ -5680,6 +5680,7 @@
5680 "217e1e7b60469736": "Состояние issue: {state}",
5681 "a98a269e3061a069": "Открыть {issue} в {provider}",
5682 "c1ff5afd83b1e027": "Обновить issue",
5683 + "8ab83a75cae667a2": "Не удалось обновить этот issue",
5684 "78398e2d7d040498": "Заголовок issue",
5685 "7b4fa0f856528bb0": "Изменить название",
5686 "c78c0974dbdb66c2": "Метки",
apps/web/src/i18n/translations/sv.json
+1
@@ -5681,6 +5681,7 @@
5681 "217e1e7b60469736": "Ärendestatus, {state}",
5682 "a98a269e3061a069": "Öppna {issue} på {provider}",
5683 "c1ff5afd83b1e027": "Uppdatera ärende",
5684 + "8ab83a75cae667a2": "Det gick inte att uppdatera det här ärendet",
5685 "78398e2d7d040498": "Ärendets titel",
5686 "7b4fa0f856528bb0": "Redigera titel",
5687 "c78c0974dbdb66c2": "Etiketter",
apps/web/src/i18n/translations/zh.json
+1
@@ -5687,6 +5687,7 @@
5687 "217e1e7b60469736": "issue 状态,{state}",
5688 "a98a269e3061a069": "在 {provider} 上打开 {issue}",
5689 "c1ff5afd83b1e027": "刷新 issue",
5690 + "8ab83a75cae667a2": "无法刷新此 issue",
5691 "78398e2d7d040498": "issue 标题",
5692 "7b4fa0f856528bb0": "编辑标题",
5693 "c78c0974dbdb66c2": "标签",
scripts/scenarios/issues-shows-failed-refresh.e2e.ts new
+125
@@ -0,0 +1,125 @@
1 +/// <reference lib="dom" />
2 +import type { IssueDetail, IssueRef } from "@t3tools/contracts";
3 +import { expect } from "e2e";
4 +
5 +import { test, WEB } from "./t3.ts";
6 +
7 +test(
8 + "A failed issue refresh tells the reader what went wrong",
9 + WEB,
10 + async ({ t3, app, browser, screen }) => {
11 + await t3.project("demo");
12 + await browser.addInitScript(() => {
13 + let rateLimited = false;
14 + Object.assign(window, {
15 + armIssueRefreshFailure: () => {
16 + rateLimited = true;
17 + },
18 + });
19 + const refresh = new Promise<void>((resolve) => {
20 + Object.assign(window, { releaseIssueRefresh: () => resolve() });
21 + });
22 + // The first issue read succeeds; the refresh then hits GitHub's rate limit.
23 + const send = WebSocket.prototype.send;
24 + WebSocket.prototype.send = function (data) {
25 + const request: { _tag: string; id: string; tag: string; payload: IssueRef } | null =
26 + typeof data === "string" ? JSON.parse(data) : null;
27 + if (request?._tag !== "Request" || request.tag !== "issues.detail")
28 + return send.call(this, data);
29 + const reply = (exit: unknown) =>
30 + this.dispatchEvent(
31 + new MessageEvent("message", {
32 + data: JSON.stringify({ _tag: "Exit", requestId: request.id, exit }),
33 + }),
34 + );
35 + if (rateLimited) {
36 + void refresh.then(() =>
37 + reply({
38 + _tag: "Failure",
39 + cause: [
40 + {
41 + _tag: "Fail",
42 + error: {
43 + _tag: "IssueOperationError",
44 + operation: "detail",
45 + detail: "GitHub API rate limit exceeded.",
46 + reason: "rate-limited",
47 + },
48 + },
49 + ],
50 + }),
51 + );
52 + return;
53 + }
54 + const { projectId, tracker, scope, key } = request.payload;
55 + const detail: IssueDetail = {
56 + projectId,
57 + tracker,
58 + scope,
59 + key,
60 + host: "github.com",
61 + displayKey: "#42",
62 + projectTitle: "demo",
63 + title: "Issue before the rate limit",
64 + body: "The details from the last successful read.",
65 + url: "https://github.com/example/demo/issues/42",
66 + author: null,
67 + state: { category: "open", name: "Open" },
68 + createdAt: "2026-10-01T00:00:00.000Z",
69 + updatedAt: "2026-10-01T00:00:00.000Z",
70 + closedAt: null,
71 + assignees: [],
72 + labels: [],
73 + commentCount: 0,
74 + writable: false,
75 + capabilities: {
76 + create: false,
77 + edit: false,
78 + comment: false,
79 + labels: false,
80 + assignees: false,
81 + reactions: false,
82 + templates: false,
83 + linkedPullRequests: false,
84 + events: false,
85 + search: true,
86 + },
87 + viewerPermissions: {
88 + setState: false,
89 + comment: false,
90 + edit: false,
91 + labels: false,
92 + assignees: false,
93 + },
94 + states: [],
95 + viewer: null,
96 + comments: [],
97 + commentsCursor: null,
98 + events: [],
99 + linkedPullRequests: [],
100 + };
101 + queueMicrotask(() => reply({ _tag: "Success", value: detail }));
102 + };
103 + });
104 +
105 + await t3.open("/issues?selectedProjectId=demo&tracker=github&scope=example/demo&key=42");
106 + await screen.getByText("Issue before the rate limit", { exact: true }).waitFor();
107 + await browser.evaluate(() => {
108 + (window as unknown as { armIssueRefreshFailure: () => void }).armIssueRefreshFailure();
109 + return null;
110 + });
111 + await screen.getByRole("button", "Refresh issue", { exact: true }).tap();
112 + const refreshing = browser.locator('button[aria-label="Refresh issue"]:disabled');
113 + await refreshing.waitFor();
114 + await browser.evaluate(() => {
115 + (window as unknown as { releaseIssueRefresh: () => void }).releaseIssueRefresh();
116 + return null;
117 + });
118 + await refreshing.waitFor({ state: "hidden" });
119 + await app.screenshot("after-failed-refresh");
120 + await expect(
121 + screen.getByText("GitHub API rate limit exceeded.", { exact: false }),
122 + ).toBeVisible();
123 + await expect(screen.getByText("Issue before the rate limit", { exact: true })).toBeVisible();
124 + },
125 +);