@devries-cameron20 / t3code Mirror · read-only / commits / 2de4762e4b
Fork 0

The best way to control Claude Code, Codex and more from any computer or phone

Mirrored from https://github.com/Camo67/t3code.git

Synced Nov 22, 14:30 UTC

fix(mobile): tab bar hides with the push, logo fits the iPad sidebar, Android rail holds still (#26241)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

Julius Marminge committed Oct 27, 2026 at 19:49 UTC 2de4762e4b59a6ce5bde5efe0ca081ed600bb760
5 files changed +26 -4
apps/mobile/modules/t3-native-controls/android/src/main/java/expo/modules/t3nativecontrols/T3WorkspaceNavigationModule.kt
+3
@@ -320,11 +320,14 @@ class T3WorkspaceNavigationView(
320 )
321 }
322 }
323 + // Other tabs keep the button's slot so the destinations below never move between tabs.
324 if (selectedTab == "threads") {
325 newThreadButton(fraction) {
326 expanded = false
327 onNewThread(emptyMap<String, Any>())
328 }
329 + } else {
330 + Spacer(Modifier.padding(top = 12.dp).height(FAB_SIZE))
331 }
332 Spacer(Modifier.weight(1f))
333 tabs.forEach { tab ->
apps/mobile/src/components/CompactBrandTitle.tsx
+5
@@ -10,6 +10,8 @@ import { IPAD_HOME_TITLE_OFFSET } from "../lib/layoutMetrics";
10 import { resolveMobileStageLabel } from "../lib/mobileBranding";
11 import { useAndroidControlSizing } from "./ui/useAndroidControlSizing";
12
13 +const BRAND_MAX_FONT_SCALE = 1.4;
14 +
15 export function brandTitleOffset(): number {
16 if (Platform.OS !== "ios") return 0;
17 return Platform.isPad && !NATIVE_WORKSPACE_COLUMNS_SUPPORTED ? IPAD_HOME_TITLE_OFFSET : 0;
@@ -49,8 +51,10 @@ export function CompactBrandTitle(
51 ]}
52 >
53 <T3Wordmark colorClassName="accent-icon" height={Math.round(15 * scale)} />
54 + {/* A logo beside a fixed-size wordmark: it may grow with Dynamic Type, not crowd the bar. */}
55 <Text
56 allowFontScaling={props.allowFontScaling}
57 + maxFontSizeMultiplier={BRAND_MAX_FONT_SCALE}
58 className="font-t3-medium text-foreground-muted"
59 style={{ fontSize: 21 * scale, letterSpacing: -0.5 * scale }}
60 >
@@ -67,6 +71,7 @@ export function CompactBrandTitle(
71 >
72 <Text
73 allowFontScaling={props.allowFontScaling}
74 + maxFontSizeMultiplier={BRAND_MAX_FONT_SCALE}
75 className="font-t3-bold text-foreground-muted uppercase"
76 style={{ fontSize: 9 * scale, letterSpacing: 0.9 * scale }}
77 >
apps/mobile/src/features/layout/createWorkspaceStackNavigator.ios.tsx
+8
@@ -490,6 +490,14 @@ function WorkspaceStackView(props: ViewProps & { readonly nativeColumns: boolean
490 const presentation = props.descriptors[route.key]?.options.presentation;
491 return presentation !== undefined && presentation !== "card";
492 });
493 + // The root's willDisappear reaches JS frames into the push, so hide the dock in the commit that
494 + // pushes; the native events still own every later change, including back gestures.
495 + const topDetailKey = projection.detail.at(-1)?.key;
496 + const [pushedDetailKey, setPushedDetailKey] = useState(topDetailKey);
497 + if (pushedDetailKey !== topDetailKey) {
498 + setPushedDetailKey(topDetailKey);
499 + if (topDetailKey !== undefined && primaryVisible) setPrimaryVisible(false);
500 + }
501 // Detail-only histories must stay single-stack: placeholder descriptors cannot own sidebar actions or setOptions.
502 const primaryRoute = projection.primary;
503 if (!primaryRoute) return <V5StackView {...props} />;
apps/mobile/src/features/sharing/IncomingShareProvider.tsx
+5
@@ -229,6 +229,11 @@ function getIncomingShareSnapshot() {
229 }
230
231 function reportRefreshFailure(cause: unknown) {
232 + console.warn(
233 + "[incoming-share] refresh failed",
234 + cause,
235 + cause instanceof Error ? cause.cause : null,
236 + );
237 const error = cause instanceof Error ? cause : new Error("Could not import shared content.");
238 Dialog.alert("Could not import shared content", error.message, [
239 { text: "Dismiss", style: "cancel" },
apps/mobile/src/features/workspace/WorkspaceRootScreen.tsx
+5 -4
@@ -62,7 +62,7 @@ function WorkspaceRootTitle(props: {
62 return (
63 <View style={{ width: props.maxWidth, minHeight: 32, justifyContent: "center" }}>
64 <WorkspaceConnectionTitle
65 - brand={<CompactBrandTitle accessibilityLabel={`T3 Code, ${tabTitle}`} />}
65 + brand={<CompactBrandTitle accessibilityLabel={`T3 Code, ${tabTitle}`} fit />}
66 maxWidth={props.maxWidth}
67 onPress={props.onOpenEnvironments}
68 />
@@ -95,14 +95,15 @@ function WorkspaceRootContent() {
95 const keyboardHeight = useKeyboardState((keyboard) => keyboard.height);
96 const workspace = useWorkspaceTabs()!;
97 const { state } = workspace;
98 + // Settings is a workspace tab too; its list takes the place of the selected tab's.
99 + const settingsOpen = workspace.settingsOpen;
100 const renderHeaderTitle = () => (
101 <WorkspaceRootTitle
100 - maxWidth={Math.max(0, width - 160)}
102 + // Settings adds its scope filter beside search.
103 + maxWidth={Math.max(0, width - 160 - (settingsOpen ? 44 : 0))}
104 onOpenEnvironments={() => openSettings(navigation, "SettingsEnvironments")}
105 />
106 );
104 - // Settings is a workspace tab too; its list takes the place of the selected tab's.
105 - const settingsOpen = workspace.settingsOpen;
107 const tab = state.tabs[settingsOpen ? "settings" : state.selectedTab];
108 const bottomClearance =
109 layout.primarySidebarOverlaysContent && state.selectedTab === "usage"