@devries-cameron20 / t3code Mirror · read-only / commits / 306914f016
Fork 0

The best way to control Claude Code, Codex and more from any computer or phone

Mirrored from https://github.com/Camo67/t3code.git

Synced Nov 21, 16:00 UTC

fix(client-runtime): grouped projects no longer take one folder's name as their label (#35614)

Co-authored-by: Julius Marminge <julius0216@outlook.com>

Thomas Nguyen committed Nov 14, 2026 at 03:52 UTC 306914f016001cc57c0fc00232d47bdea873d3d7
4 files changed +66 -2
apps/mobile/src/features/settings/SettingsProjectOverviewRouteScreen.tsx
+5 -1
@@ -138,7 +138,11 @@ function ProjectOverviewContent(props: {
138 }) {
139 const { isRemoving, setIsRemoving, startRemoval, finishRemoval } = props;
140 const representative = props.members[0]!;
141 - const displayName = deriveProjectGroupLabel({ representative, members: props.members });
141 + const displayName = deriveProjectGroupLabel({
142 + groupKey: props.group.key,
143 + representative,
144 + members: props.members,
145 + });
146 const [draftName, setDraftName] = useState<string | null>(null);
147 const [isSaving, setIsSaving] = useState(false);
148 const threads = useThreadShells();
apps/mobile/src/features/settings/SettingsRouteScreen.tsx
+2 -1
@@ -252,8 +252,9 @@ function useSettingsIndexSections(): SettingsListSection[] {
252 selectedTargets.some((target) => target.environmentId === project.environmentId),
253 ) ?? [];
254 const projectLabel =
255 - scopedProjectMembers.length > 0
255 + selectedProject && scopedProjectMembers.length > 0
256 ? deriveProjectGroupLabel({
257 + groupKey: selectedProject.key,
258 representative: scopedProjectMembers[0]!,
259 members: scopedProjectMembers,
260 })
packages/client-runtime/src/state/projectGrouping.test.ts
+44
@@ -303,6 +303,50 @@ describe("buildProjectGroups", () => {
303 expect(label(renamed)).toBe("t3code");
304 });
305
306 + it("labels a group by its repository when clones disagree on its casing", () => {
307 + // A subfolder project, its repository root, and a clone whose remote URL is
308 + // lowercased: no shared title or display name, but one repository.
309 + const subfolder = makeProject("design-study", "/work/NewCo/reference/design-study");
310 + const root = makeProject("NewCo", "/work/NewCo");
311 + const lowercasedClone = makeProject("NewCo", "/remote/NewCo", {
312 + environmentId: EnvironmentId.make("remote"),
313 + repositoryIdentity: { ...repositoryIdentity, name: "T3CODE", displayName: "t3 code" },
314 + });
315 +
316 + const groups = buildProjectGroups({
317 + projects: [subfolder, root, lowercasedClone],
318 + settings: settings("repository"),
319 + preferredEnvironmentId: environmentId,
320 + });
321 + expect(groups).toHaveLength(1);
322 + expect(groups[0]?.label).toBe("T3 Code");
323 +
324 + // A subfolder group in repository_path mode keeps its own title.
325 + const localIdentity = { ...repositoryIdentity, rootPath: "/work/t3code" };
326 + const pathGroups = buildProjectGroups({
327 + projects: [
328 + makeProject("design", "/work/t3code/design", {
329 + title: "Design docs",
330 + hasCustomTitle: true,
331 + repositoryIdentity: localIdentity,
332 + }),
333 + makeProject("design", "/remote/t3code/design", {
334 + environmentId: EnvironmentId.make("remote"),
335 + repositoryIdentity: {
336 + ...repositoryIdentity,
337 + rootPath: "/remote/t3code",
338 + name: "T3CODE",
339 + displayName: "t3 code",
340 + },
341 + }),
342 + makeProject("t3code", "/work/t3code", { repositoryIdentity: localIdentity }),
343 + ],
344 + settings: settings("repository_path"),
345 + preferredEnvironmentId: environmentId,
346 + });
347 + expect(pathGroups.map((group) => group.label)).toEqual(["Design docs", "t3code"]);
348 + });
349 +
350 it("applies a physical-project override without dropping its siblings", () => {
351 const first = makeProject("t3code", "/work/t3code");
352 const second = makeProject("t3code-2", "/work/t3code-2");
packages/client-runtime/src/state/projectGrouping.ts
+15
@@ -199,6 +199,7 @@ export function resolveScratchProjectScopeKey(
199 }
200
201 export function deriveProjectGroupLabel(input: {
202 + readonly groupKey: string;
203 readonly representative: Pick<EnvironmentProject, "title" | "repositoryIdentity">;
204 readonly members: ReadonlyArray<
205 Pick<EnvironmentProject, "title" | "hasCustomTitle" | "repositoryIdentity">
@@ -230,6 +231,19 @@ export function deriveProjectGroupLabel(input: {
231 return sharedRepositoryNames[0]!;
232 }
233
234 + // A whole-repository group is named for the repository, not one member's folder:
235 + // clones can disagree on its casing. A subfolder group keeps its own title.
236 + const representativeIdentity = input.representative.repositoryIdentity;
237 + if (
238 + representativeIdentity &&
239 + input.groupKey === repositoryGroupingKeyOf(representativeIdentity)
240 + ) {
241 + return (
242 + repositoryGroupingDisplayNameOf(representativeIdentity) ??
243 + representativeIdentity.name ??
244 + input.representative.title
245 + );
246 + }
247 return input.representative.title;
248 }
249
@@ -369,6 +383,7 @@ export function buildProjectGroups<TProject extends EnvironmentProject>(input: {
383 ? "No project"
384 : members.length > 1
385 ? deriveProjectGroupLabel({
386 + groupKey: key,
387 representative,
388 members: members.map((member) => member.project),
389 })