@devries-cameron20 / t3code Mirror · read-only / commits / 312a12d726
Fork 0

The best way to control Claude Code, Codex and more from any computer or phone

Mirrored from https://github.com/Camo67/t3code.git

Synced Nov 22, 17:00 UTC

chore(lint): enforce unnecessaryFailYieldableError (#25083)

Julius Marminge committed Oct 25, 2026 at 18:18 UTC 312a12d726cad18faef0be545b14d4428c4405b1
10 files changed +36 -49
apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.test.ts
+4 -6
@@ -1511,12 +1511,10 @@ describe("ClaudeAdapterV2 attachments", () => {
1511 Effect.gen(function* () {
1512 if (failOpen) {
1513 failOpen = false;
1514 - return yield* Effect.fail(
1515 - new ClaudeAdapterV2.ClaudeAgentSdkQueryRunnerError({
1516 - method: "open",
1517 - cause: "rejected open",
1518 - }),
1519 - );
1514 + return yield* new ClaudeAdapterV2.ClaudeAgentSdkQueryRunnerError({
1515 + method: "open",
1516 + cause: "rejected open",
1517 + });
1518 }
1519 const messages = yield* Queue.unbounded<SDKMessage>();
1520 return {
apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.ts
+1 -1
@@ -7175,7 +7175,7 @@ export const makeCodexAdapterV2 = Effect.fn("makeCodexAdapterV2")(function* (
7175 const terminationResults = yield* terminateTrackedTerminals(interruptTargets);
7176 const failedTermination = terminationResults.find((result) => !result.success);
7177 if (failedTermination !== undefined && !failedTermination.success) {
7178 - return yield* Effect.fail(failedTermination.error);
7178 + return yield* failedTermination.error;
7179 }
7180 yield* turnTerminalizationPermit.withPermits(1)(
7181 Effect.gen(function* () {
apps/server/src/orchestration-v2/ThreadManagementService.ts
+1 -1
@@ -1195,7 +1195,7 @@ const make = Effect.gen(function* () {
1195 ),
1196 );
1197 }
1198 - if (failures[0] !== undefined) return yield* Effect.fail(failures[0]);
1198 + if (failures[0] !== undefined) return yield* failures[0];
1199 });
1200
1201 return ThreadManagementService.of({
apps/server/src/provider/ProviderAuthService.test.ts
+5 -7
@@ -281,13 +281,11 @@ const makeHarness = Effect.fn("ProviderAuthService.test.makeHarness")(function*
281 actions.push(`stop:${providerSessionId}`);
282 yield* input.beforeStop ?? Effect.void;
283 if (input.stopError) {
284 - return yield* Effect.fail(
285 - new ProviderSessionManager.ProviderSessionReleaseError({
286 - providerSessionId,
287 - reason,
288 - cause: new Error("private process diagnostics"),
289 - }),
290 - );
284 + return yield* new ProviderSessionManager.ProviderSessionReleaseError({
285 + providerSessionId,
286 + reason,
287 + cause: new Error("private process diagnostics"),
288 + });
289 }
290 released.push(providerSessionId);
291 for (const [threadId, list] of sessions) {
apps/server/src/storageCleanup.ts
+6 -8
@@ -692,14 +692,12 @@ const make = Effect.gen(function* () {
692 timeoutMs: 300_000,
693 });
694 if (result.exitCode !== 0)
695 - return yield* Effect.fail(
696 - new GitCommandError({
697 - operation: "StorageCleanup.cleanupGit",
698 - command,
699 - cwd,
700 - detail: result.stderr.trim().split(/\r?\n/)[0]?.slice(0, 1000) || "command failed",
701 - }),
702 - );
695 + return yield* new GitCommandError({
696 + operation: "StorageCleanup.cleanupGit",
697 + command,
698 + cwd,
699 + detail: result.stderr.trim().split(/\r?\n/)[0]?.slice(0, 1000) || "command failed",
700 + });
701 });
702
703 const cleanWorktrees = Effect.fn("StorageCleanup.cleanWorktrees")(function* (
apps/server/src/ws.ts
+12 -18
@@ -2430,29 +2430,23 @@ export const layerWsRpc = (
2430 ) ?? projection.providerThreads.at(-1);
2431 const providerSessionId = providerThread?.providerSessionId ?? null;
2432 if (providerThread === undefined || providerSessionId === null) {
2433 - return yield* Effect.fail(
2434 - new ProviderUploadFeedbackError({
2435 - threadId: input.threadId,
2436 - cause: "No provider session has run in this thread yet.",
2437 - }),
2438 - );
2433 + return yield* new ProviderUploadFeedbackError({
2434 + threadId: input.threadId,
2435 + cause: "No provider session has run in this thread yet.",
2436 + });
2437 }
2438 const runtime = Option.getOrNull(yield* providerSessionsV2.get(providerSessionId));
2439 if (runtime === null) {
2442 - return yield* Effect.fail(
2443 - new ProviderUploadFeedbackError({
2444 - threadId: input.threadId,
2445 - cause: "The provider session is no longer running. Send a message first.",
2446 - }),
2447 - );
2440 + return yield* new ProviderUploadFeedbackError({
2441 + threadId: input.threadId,
2442 + cause: "The provider session is no longer running. Send a message first.",
2443 + });
2444 }
2445 if (runtime.uploadFeedback === undefined) {
2450 - return yield* Effect.fail(
2451 - new ProviderUploadFeedbackError({
2452 - threadId: input.threadId,
2453 - cause: `Provider '${runtime.driver}' does not support feedback uploads.`,
2454 - }),
2455 - );
2446 + return yield* new ProviderUploadFeedbackError({
2447 + threadId: input.threadId,
2448 + cause: `Provider '${runtime.driver}' does not support feedback uploads.`,
2449 + });
2450 }
2451 return yield* runtime.uploadFeedback({
2452 providerThread,
packages/client-runtime/src/state/commandPermissions.ts
+4 -6
@@ -59,12 +59,10 @@ function makeCommandPermissions<R, E>(
59 (scope) => Option.isNone(session) || !sessionGrantsScope(session.value, scope),
60 );
61 if (missing !== undefined)
62 - return yield* Effect.fail(
63 - new EnvironmentAuthorizationError({
64 - ...authScopeRequiredResponse(missing),
65 - message: `This connection requires ${missing}.`,
66 - }),
67 - );
62 + return yield* new EnvironmentAuthorizationError({
63 + ...authScopeRequiredResponse(missing),
64 + message: `This connection requires ${missing}.`,
65 + });
66 }),
67 );
68 });
packages/provider-opencode/src/server/adapter.ts
+1 -1
@@ -1061,7 +1061,7 @@ export const makeOpenCodeAdapterV2 = Effect.fn("makeOpenCodeAdapterV2")(function
1061 return firstFailure ?? failures.find((failure) => failure !== undefined);
1062 });
1063 const failure = yield* visit(rootId, false);
1064 - if (failure) return yield* Effect.fail(failure);
1064 + if (failure) return yield* failure;
1065 }, Effect.timeout("15 seconds"));
1066
1067 const updateProviderSession =
packages/source-control-github/src/server/gitHubGraphQlClient.ts
+1 -1
@@ -103,7 +103,7 @@ const refused = Effect.fn("gitHubGraphQlClient.refused")(function* (
103 ) {
104 const reason = error.reason;
105 if (reason._tag !== "TransportError" && reason._tag !== "ResponseError") {
106 - return yield* Effect.fail(error);
106 + return yield* error;
107 }
108 const status = reason.status;
109 if (reason._tag === "TransportError" && status === undefined) {
tsconfig.base.json
+1
@@ -24,6 +24,7 @@
24 "namespaceImportPackages": ["@effect/platform-node", "effect"],
25 "effectFn": ["span", "inferred-span", "suggested-span"],
26 "diagnosticSeverity": {
27 + "unnecessaryFailYieldableError": "error",
28 "preferSucceedSomeOrNone": "error",
29 "effectSucceedWithVoid": "error",
30 "provideLayerSucceedToProvideService": "error",