The best way to control Claude Code, Codex and more from any computer or phone
Mirrored from https://github.com/Camo67/t3code.git
Synced Nov 21, 09:45 UTC
fix(web): Update everything no longer offers a Nightly build to a Stable desktop app (#37490)
Julius Marminge committed
Nov 15, 2026 at 21:19 UTC
399ea10f4ed41aab0a6f24b6f8424c846beeb9a6
2 files changed
+22
-5
apps/web/src/components/sidebar/updateEverything.logic.test.ts
+16
-1
@@ -85,6 +85,18 @@ describe("collectServerUpdateTargets", () => {
85
]);
86
});
87
88
+ it("does not offer a Nightly build to a Stable desktop app, whose own feed has nothing newer", () => {
89
+ const { targets, skipped } = collectServerUpdateTargets(
90
+ [machine("stable-desktop", "0.1.9", "desktop-managed")],
91
+ "0.1.10-nightly.20261116.4761",
92
+ );
93
+
94
+ expect(targets.map((target) => target.serverLabel)).toEqual([]);
95
+ expect(skipped.map((entry) => [entry.label, entry.reason])).toEqual([
96
+ ["stable-desktop", "on the stable channel"],
97
+ ]);
98
+ });
99
+
100
it("skips servers whose policy refuses the update, with the policy's message", () => {
101
const managed = (
102
id: string,
@@ -119,7 +131,10 @@ describe("collectServerUpdateTargets", () => {
131
...entry,
132
serverConfig: {
133
...entry.serverConfig,
122
- environment: { ...entry.serverConfig.environment, serverVersion: "0.0.49-nightly.1" },
134
+ environment: {
135
+ ...entry.serverConfig.environment,
136
+ serverVersion: "0.0.49-nightly.20261027.1",
137
+ },
138
},
139
})),
140
"0.0.50-nightly.20261028.1",
apps/web/src/components/sidebar/updateEverything.logic.ts
+6
-4
@@ -112,12 +112,14 @@ export function collectServerUpdateTargets(
112
skip("needs a newer desktop app");
113
continue;
114
}
115
- const serverVersion = config.environment.serverVersion;
115
+ const serverChannel = cliReleaseChannelOf(config.environment.serverVersion);
116
+ // A desktop app installs its own track's newest release. Nightly builds run ahead of Stable, so a
117
+ // Nightly host behind a Stable target has something newer; a Stable host may not.
118
if (
117
- selfUpdate !== "desktop-managed" &&
118
- cliReleaseChannelOf(serverVersion) !== cliReleaseChannelOf(targetVersion)
119
+ serverChannel !== cliReleaseChannelOf(targetVersion) &&
120
+ (selfUpdate !== "desktop-managed" || serverChannel === "stable")
121
) {
120
- skip(`on the ${cliReleaseChannelOf(serverVersion)} channel`);
122
+ skip(`on the ${serverChannel} channel`);
123
continue;
124
}
125
const target: ServerUpdateTarget = {