@devries-cameron20 / t3code Mirror · read-only / commits / 40ec16a9b6
Fork 0

The best way to control Claude Code, Codex and more from any computer or phone

Mirrored from https://github.com/Camo67/t3code.git

Synced Nov 22, 17:00 UTC

fix(mobile): the Duo sidebar changes with the rotation, not after it (#24951)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

Julius Marminge committed Oct 25, 2026 at 11:35 UTC 40ec16a9b6557d97b2eb33fea3784cb0c577be62
8 files changed +60 -20
apps/mobile/deps/react-native-screens-5.0.0-t3.43.tgz
Binary files a/apps/mobile/deps/react-native-screens-5.0.0-t3.43.tgz and /dev/null differ
apps/mobile/deps/react-native-screens-5.0.0-t3.44.tgz
Binary files /dev/null and b/apps/mobile/deps/react-native-screens-5.0.0-t3.44.tgz differ
apps/mobile/package.json
+1 -1
@@ -134,7 +134,7 @@
134 "react-native-pdf-jsi": "5.0.0",
135 "react-native-reanimated": "4.7.1",
136 "react-native-safe-area-context": "~5.10.1",
137 - "react-native-screens": "file:deps/react-native-screens-5.0.0-t3.43.tgz",
137 + "react-native-screens": "file:deps/react-native-screens-5.0.0-t3.44.tgz",
138 "react-native-svg": "15.16.0",
139 "react-native-webview": "14.0.1",
140 "react-native-worklets": "0.13.0",
apps/mobile/src/features/layout/AdaptiveWorkspaceLayout.tsx
+19
@@ -743,6 +743,24 @@ function AdaptiveWorkspaceLayoutContent(
743 });
744 };
745
746 + // Rotating flips the overlay; until the new size reaches JS, predict the reset above.
747 + const sidebarOverRotates =
748 + nativeWorkspace && nativeMetrics?.hasHinge === true && layout.usesSplitView;
749 + // The current orientation's panes already account for an inspector that needs the sidebar's room.
750 + const sidebarInLandscape = baseLayout.primarySidebarOverlaysContent
751 + ? primarySidebarPinned || primarySidebarPreferredVisible
752 + : panes.primarySidebarVisible;
753 + const sidebarInPortrait =
754 + primarySidebarPinned ||
755 + (baseLayout.primarySidebarOverlaysContent
756 + ? overlaySidebar.visible
757 + : isWorkspaceListPath(pathname));
758 + const sidebarByOrientation = useMemo(
759 + () =>
760 + sidebarOverRotates ? { landscape: sidebarInLandscape, portrait: sidebarInPortrait } : null,
761 + [sidebarInLandscape, sidebarInPortrait, sidebarOverRotates],
762 + );
763 +
764 const contextValue = {
765 layout,
766 panes,
@@ -762,6 +780,7 @@ function AdaptiveWorkspaceLayoutContent(
780 setAuxiliaryPaneWidth,
781 composerKeyboardActive,
782 setComposerEditing,
783 + sidebarByOrientation,
784 };
785
786 if (nativeWorkspace) {
apps/mobile/src/features/layout/adaptive-workspace-context.ts
+6
@@ -41,6 +41,11 @@ interface AdaptiveWorkspaceContextValue {
41 * sidebar and rail step aside and the thread header drops to one line.
42 */
43 readonly composerKeyboardActive: boolean;
44 + /**
45 + * Whether the sidebar shows in each orientation, where it floats over the content in portrait
46 + * (the unfolded Duo). The native split switches between them as a rotation starts.
47 + */
48 + readonly sidebarByOrientation: { readonly landscape: boolean; readonly portrait: boolean } | null;
49 /** The thread composer reports its focus so the layout can make room for typing. */
50 readonly setComposerEditing: (editing: boolean) => void;
51 }
@@ -73,6 +78,7 @@ export const AdaptiveWorkspaceContext = createContext<AdaptiveWorkspaceContextVa
78 openWorkspaceTab: () => undefined,
79 setAuxiliaryPaneWidth: () => undefined,
80 composerKeyboardActive: false,
81 + sidebarByOrientation: null,
82 setComposerEditing: () => undefined,
83 });
84
apps/mobile/src/features/layout/createWorkspaceStackNavigator.ios.tsx
+24 -9
@@ -182,6 +182,7 @@ function WorkspaceColumns(
182 toggleAuxiliaryPane,
183 startNewTask,
184 openWorkspaceTab,
185 + sidebarByOrientation,
186 } = useAdaptiveWorkspaceLayout();
187 const deviceType = useDeviceType();
188 const settingsDetailIn = (detail: readonly Route[]) =>
@@ -302,7 +303,13 @@ function WorkspaceColumns(
303 <Split.Host
304 ref={hostRef}
305 testID="adaptive-workspace-layout"
305 - preferredSplitBehavior={layout.primarySidebarOverlaysContent ? "overlay" : "tile"}
306 + preferredSplitBehavior={
307 + !sidebarByOrientation && layout.primarySidebarOverlaysContent ? "overlay" : "tile"
308 + }
309 + portraitPreferredSplitBehavior={sidebarByOrientation ? "overlay" : undefined}
310 + portraitPreferredDisplayMode={
311 + sidebarByOrientation ? sidebarDisplayMode(sidebarByOrientation.portrait, true) : undefined
312 + }
313 primaryBackgroundStyle={deviceType === "pad" ? "none" : "default"}
314 topColumnForCollapsing={compactColumn}
315 onCollapse={() => {
@@ -326,14 +333,17 @@ function WorkspaceColumns(
333 openWorkspaceTab(tab ?? "threads", { columns: true });
334 }}
335 preferredDisplayMode={
329 - // UIKit applies the mode as a collapsed split expands, before the new width reaches JS, so a
330 - // collapsed split already carries the sidebar the expanded one will show.
331 - (layout.usesSplitView ? panes.primarySidebarVisible : panes.primarySidebarWhenExpanded) ||
332 - (!layout.usesSplitView && !activeDetailKey)
333 - ? layout.primarySidebarOverlaysContent
334 - ? "oneOverSecondary"
335 - : "oneBesideSecondary"
336 - : "secondaryOnly"
336 + sidebarByOrientation
337 + ? sidebarDisplayMode(sidebarByOrientation.landscape, false)
338 + : sidebarDisplayMode(
339 + // UIKit applies the mode as a collapsed split expands, before the new width reaches
340 + // JS, so a collapsed split already carries the sidebar the expanded one will show.
341 + (layout.usesSplitView
342 + ? panes.primarySidebarVisible
343 + : panes.primarySidebarWhenExpanded) ||
344 + (!layout.usesSplitView && !activeDetailKey),
345 + layout.primarySidebarOverlaysContent,
346 + )
347 }
348 onDisplayModeWillChange={({ nativeEvent }) => {
349 if (!layout.primarySidebarOverlaysContent) return;
@@ -604,3 +614,8 @@ export function createWorkspaceStackNavigator<
614 >(config?: Config): TypedNavigator<TypeBag, Config> {
615 return createNavigatorFactory(WorkspaceStackNavigator)(config);
616 }
617 +
618 +function sidebarDisplayMode(visible: boolean, overlay: boolean) {
619 + if (!visible) return "secondaryOnly";
620 + return overlay ? "oneOverSecondary" : "oneBesideSecondary";
621 +}
docs/operations/mobile-screens-fork.md
+1 -1
@@ -1,7 +1,7 @@
1 # Building the mobile Screens dependency
2
3 The mobile v5 stack uses a committed tarball from the
4 -[T3 Screens fork](https://github.com/PixPMusic/react-native-screens/tree/t3-v5.0.0-t3.43).
4 +[T3 Screens fork](https://github.com/pingdotgg/react-native-screens/tree/t3-v5.0.0-t3.44).
5 The fork owns the integration changes; the app does not patch this package.
6 Each archive includes compiled JavaScript, declarations, native source and
7 `t3-fork.json` recording its version, source commit and upstream base.
pnpm-lock.yaml
+9 -9
@@ -559,7 +559,7 @@ importers:
559 version: 7.5.1(react-native@0.88.0(@babel/core@7.29.7(supports-color@8.1.1))(@react-native/metro-config@0.88.0(@babel/core@7.29.7(supports-color@8.1.1))(bufferutil@4.1.0)(supports-color@8.1.1)(utf-8-validate@6.0.6))(@types/react@19.3.0)(bufferutil@4.1.0)(react@19.3.0)(supports-color@8.1.1)(utf-8-validate@6.0.6))(react@19.3.0)
560 '@react-navigation/native-stack':
561 specifier: 7.21.0
562 - version: 7.21.0(patch_hash=990d575444c4af2ce8218b3b7a8280fe244c03abbdb32b822a2e862f791dbf42)(52d9b4ccdf06285c715244e02709d347)
562 + version: 7.21.0(patch_hash=990d575444c4af2ce8218b3b7a8280fe244c03abbdb32b822a2e862f791dbf42)(90b832078186123c182216792ec43c25)
563 '@t3tools/client-runtime':
564 specifier: workspace:*
565 version: link:../../packages/client-runtime
@@ -762,8 +762,8 @@ importers:
762 specifier: ~5.10.1
763 version: 5.10.1(react-native@0.88.0(@babel/core@7.29.7(supports-color@8.1.1))(@react-native/metro-config@0.88.0(@babel/core@7.29.7(supports-color@8.1.1))(bufferutil@4.1.0)(supports-color@8.1.1)(utf-8-validate@6.0.6))(@types/react@19.3.0)(bufferutil@4.1.0)(react@19.3.0)(supports-color@8.1.1)(utf-8-validate@6.0.6))(react@19.3.0)
764 react-native-screens:
765 - specifier: file:deps/react-native-screens-5.0.0-t3.43.tgz
766 - version: file:apps/mobile/deps/react-native-screens-5.0.0-t3.43.tgz(react-native@0.88.0(@babel/core@7.29.7(supports-color@8.1.1))(@react-native/metro-config@0.88.0(@babel/core@7.29.7(supports-color@8.1.1))(bufferutil@4.1.0)(supports-color@8.1.1)(utf-8-validate@6.0.6))(@types/react@19.3.0)(bufferutil@4.1.0)(react@19.3.0)(supports-color@8.1.1)(utf-8-validate@6.0.6))(react@19.3.0)
765 + specifier: file:deps/react-native-screens-5.0.0-t3.44.tgz
766 + version: file:apps/mobile/deps/react-native-screens-5.0.0-t3.44.tgz(react-native@0.88.0(@babel/core@7.29.7(supports-color@8.1.1))(@react-native/metro-config@0.88.0(@babel/core@7.29.7(supports-color@8.1.1))(bufferutil@4.1.0)(supports-color@8.1.1)(utf-8-validate@6.0.6))(@types/react@19.3.0)(bufferutil@4.1.0)(react@19.3.0)(supports-color@8.1.1)(utf-8-validate@6.0.6))(react@19.3.0)
767 react-native-svg:
768 specifier: 15.16.0
769 version: 15.16.0(react-native@0.88.0(@babel/core@7.29.7(supports-color@8.1.1))(@react-native/metro-config@0.88.0(@babel/core@7.29.7(supports-color@8.1.1))(bufferutil@4.1.0)(supports-color@8.1.1)(utf-8-validate@6.0.6))(@types/react@19.3.0)(bufferutil@4.1.0)(react@19.3.0)(supports-color@8.1.1)(utf-8-validate@6.0.6))(react@19.3.0)
@@ -10719,9 +10719,9 @@ packages:
10719 react: '*'
10720 react-native: '*'
10721
10722 - react-native-screens@file:apps/mobile/deps/react-native-screens-5.0.0-t3.43.tgz:
10723 - resolution: {integrity: sha512-kknkDmA26Vygu00QP5bThYHiSdbjJNxLncFSLEKC22lCZ7LAzuQJkC44ra53b1VEcP9TPKsQHKK8ateJNvNE2Q==, tarball: file:apps/mobile/deps/react-native-screens-5.0.0-t3.43.tgz}
10724 - version: 5.0.0-t3.43
10722 + react-native-screens@file:apps/mobile/deps/react-native-screens-5.0.0-t3.44.tgz:
10723 + resolution: {integrity: sha512-hs8Q9FodRg8JWPk7QeohJwaNrndgxHajgXdTfVH1RpwFhmyWSJV0/mMzqYKh3qX/jTD7TBnRWKyKuvMFwHGF6w==, tarball: file:apps/mobile/deps/react-native-screens-5.0.0-t3.44.tgz}
10724 + version: 5.0.0-t3.44
10725 peerDependencies:
10726 react: '*'
10727 react-native: '*'
@@ -15658,7 +15658,7 @@ snapshots:
15658 optionalDependencies:
15659 '@react-native-masked-view/masked-view': 0.3.2(react-native@0.88.0(@babel/core@7.29.7(supports-color@8.1.1))(@react-native/metro-config@0.88.0(@babel/core@7.29.7(supports-color@8.1.1))(bufferutil@4.1.0)(supports-color@8.1.1)(utf-8-validate@6.0.6))(@types/react@19.3.0)(bufferutil@4.1.0)(react@19.3.0)(supports-color@8.1.1)(utf-8-validate@6.0.6))(react@19.3.0)
15660
15661 - '@react-navigation/native-stack@7.21.0(patch_hash=990d575444c4af2ce8218b3b7a8280fe244c03abbdb32b822a2e862f791dbf42)(52d9b4ccdf06285c715244e02709d347)':
15661 + '@react-navigation/native-stack@7.21.0(patch_hash=990d575444c4af2ce8218b3b7a8280fe244c03abbdb32b822a2e862f791dbf42)(90b832078186123c182216792ec43c25)':
15662 dependencies:
15663 '@react-navigation/elements': 2.9.45(d8845bac868f4d8a58c8a8f12ad0d4a5)
15664 '@react-navigation/native': 7.5.1(react-native@0.88.0(@babel/core@7.29.7(supports-color@8.1.1))(@react-native/metro-config@0.88.0(@babel/core@7.29.7(supports-color@8.1.1))(bufferutil@4.1.0)(supports-color@8.1.1)(utf-8-validate@6.0.6))(@types/react@19.3.0)(bufferutil@4.1.0)(react@19.3.0)(supports-color@8.1.1)(utf-8-validate@6.0.6))(react@19.3.0)
@@ -15666,7 +15666,7 @@ snapshots:
15666 react: 19.3.0
15667 react-native: 0.88.0(@babel/core@7.29.7(supports-color@8.1.1))(@react-native/metro-config@0.88.0(@babel/core@7.29.7(supports-color@8.1.1))(bufferutil@4.1.0)(supports-color@8.1.1)(utf-8-validate@6.0.6))(@types/react@19.3.0)(bufferutil@4.1.0)(react@19.3.0)(supports-color@8.1.1)(utf-8-validate@6.0.6)
15668 react-native-safe-area-context: 5.10.1(react-native@0.88.0(@babel/core@7.29.7(supports-color@8.1.1))(@react-native/metro-config@0.88.0(@babel/core@7.29.7(supports-color@8.1.1))(bufferutil@4.1.0)(supports-color@8.1.1)(utf-8-validate@6.0.6))(@types/react@19.3.0)(bufferutil@4.1.0)(react@19.3.0)(supports-color@8.1.1)(utf-8-validate@6.0.6))(react@19.3.0)
15669 - react-native-screens: file:apps/mobile/deps/react-native-screens-5.0.0-t3.43.tgz(react-native@0.88.0(@babel/core@7.29.7(supports-color@8.1.1))(@react-native/metro-config@0.88.0(@babel/core@7.29.7(supports-color@8.1.1))(bufferutil@4.1.0)(supports-color@8.1.1)(utf-8-validate@6.0.6))(@types/react@19.3.0)(bufferutil@4.1.0)(react@19.3.0)(supports-color@8.1.1)(utf-8-validate@6.0.6))(react@19.3.0)
15669 + react-native-screens: file:apps/mobile/deps/react-native-screens-5.0.0-t3.44.tgz(react-native@0.88.0(@babel/core@7.29.7(supports-color@8.1.1))(@react-native/metro-config@0.88.0(@babel/core@7.29.7(supports-color@8.1.1))(bufferutil@4.1.0)(supports-color@8.1.1)(utf-8-validate@6.0.6))(@types/react@19.3.0)(bufferutil@4.1.0)(react@19.3.0)(supports-color@8.1.1)(utf-8-validate@6.0.6))(react@19.3.0)
15670 sf-symbols-typescript: 2.2.0
15671 warn-once: 0.1.1
15672 transitivePeerDependencies:
@@ -21318,7 +21318,7 @@ snapshots:
21318 react: 19.3.0
21319 react-native: 0.88.0(@babel/core@7.29.7(supports-color@8.1.1))(@react-native/metro-config@0.88.0(@babel/core@7.29.7(supports-color@8.1.1))(bufferutil@4.1.0)(supports-color@8.1.1)(utf-8-validate@6.0.6))(@types/react@19.3.0)(bufferutil@4.1.0)(react@19.3.0)(supports-color@8.1.1)(utf-8-validate@6.0.6)
21320
21321 - react-native-screens@file:apps/mobile/deps/react-native-screens-5.0.0-t3.43.tgz(react-native@0.88.0(@babel/core@7.29.7(supports-color@8.1.1))(@react-native/metro-config@0.88.0(@babel/core@7.29.7(supports-color@8.1.1))(bufferutil@4.1.0)(supports-color@8.1.1)(utf-8-validate@6.0.6))(@types/react@19.3.0)(bufferutil@4.1.0)(react@19.3.0)(supports-color@8.1.1)(utf-8-validate@6.0.6))(react@19.3.0):
21321 + react-native-screens@file:apps/mobile/deps/react-native-screens-5.0.0-t3.44.tgz(react-native@0.88.0(@babel/core@7.29.7(supports-color@8.1.1))(@react-native/metro-config@0.88.0(@babel/core@7.29.7(supports-color@8.1.1))(bufferutil@4.1.0)(supports-color@8.1.1)(utf-8-validate@6.0.6))(@types/react@19.3.0)(bufferutil@4.1.0)(react@19.3.0)(supports-color@8.1.1)(utf-8-validate@6.0.6))(react@19.3.0):
21322 dependencies:
21323 react: 19.3.0
21324 react-freeze: 1.0.4(react@19.3.0)