The best way to control Claude Code, Codex and more from any computer or phone
Mirrored from https://github.com/Camo67/t3code.git
Synced Nov 21, 08:30 UTC
fix(web): screen readers read a pull request's number once in thread details (#38400)
Julius Marminge committed
Nov 17, 2026 at 17:59 UTC
42763ff8b12bfb534363df4dd5f8f5f759f54990
2 files changed
+10
-1
apps/web/src/components/chat/ThreadDetailsPrRow.browser.test.tsx
+7
@@ -361,6 +361,13 @@ it("names a linked pull request row by its kind, number and title, not its URL",
361
expect(name).toMatch(/pull request/i);
362
expect(name).toContain("#1");
363
expect(name).toContain("Test PR");
364
+ const exposedNumbers = [...screen.container.querySelectorAll("span")].filter(
365
+ (span) =>
366
+ span.textContent?.trim() === "#1" &&
367
+ span.closest("button") === null &&
368
+ span.closest('[aria-hidden="true"]') === null,
369
+ );
370
+ expect(exposedNumbers).toHaveLength(0);
371
});
372
373
it("names a linked issue row by its kind, number and title, not its URL", async () => {
apps/web/src/components/chat/ThreadDetailsPrRow.tsx
+3
-1
@@ -483,7 +483,9 @@ export function ThreadDetailsPrRow({
483
<div className="pb-1.5">
484
{openRow(detail.title, "row", true)}
485
<div className="flex h-5 min-w-0 items-center gap-0.5 ps-9 pe-2.5 text-xs text-muted-foreground">
486
- <span className="me-1 shrink-0 tabular-nums">#{number}</span>
486
+ <span aria-hidden className="me-1 shrink-0 tabular-nums">
487
+ #{number}
488
+ </span>
489
{showChecks && checksRollup !== null ? (
490
<PullRequestChecksPopover
491
checksState={checksRollup}