The best way to control Claude Code, Codex and more from any computer or phone
Mirrored from https://github.com/Camo67/t3code.git
Synced Nov 21, 08:30 UTC
fix(server): review diffs no longer stall on large reordered files (#38308)
Julius Marminge committed
Nov 17, 2026 at 12:11 UTC
439c96550c670281170b090e48ffd5ef32d16941
2 files changed
+5
-8
apps/server/src/vcs/GitVcsDriverCore.test.ts
+5
-7
@@ -4702,7 +4702,7 @@ it.layer(layerTest)("GitVcsDriver core integration", (it) => {
4702
}),
4703
);
4704
4705
- it.effect("reads Changes totals without minimizing and keeps review diffs minimal", () =>
4705
+ it.effect("reads Changes totals and review diffs without minimizing", () =>
4706
Effect.gen(function* () {
4707
const cwd = yield* makeTmpDir();
4708
const { initialBranch } = yield* initRepoWithCommit(cwd);
@@ -4734,10 +4734,8 @@ it.layer(layerTest)("GitVcsDriver core integration", (it) => {
4734
deletions: Number(deletions),
4735
});
4736
4737
- const [additions, removals] = minimalStat.split("\t");
4738
- const minimalPatch = yield* git(cwd, [
4737
+ const defaultPatch = yield* git(cwd, [
4738
"diff",
4740
- "--minimal",
4739
"--patch",
4740
"--no-color",
4741
"--no-ext-diff",
@@ -4754,11 +4752,11 @@ it.layer(layerTest)("GitVcsDriver core integration", (it) => {
4752
path: "repeated.txt",
4753
previousPath: null,
4754
changeType: "change",
4757
- additions: Number(additions),
4758
- deletions: Number(removals),
4755
+ additions: Number(insertions),
4756
+ deletions: Number(deletions),
4757
},
4758
]);
4761
- assert.strictEqual(source.diff.trim(), minimalPatch);
4759
+ assert.strictEqual(source.diff.trim(), defaultPatch);
4760
}
4761
}),
4762
);
apps/server/src/vcs/GitVcsDriverCore.ts
-1
@@ -4239,7 +4239,6 @@ export const makeGitVcsDriverCore = Effect.fn("makeGitVcsDriverCore")(function*
4239
4240
const diffArgs = [
4241
...REVIEW_DIFF_ARGS,
4242
- "--minimal",
4242
...(input.ignoreWhitespace ? ["--ignore-all-space"] : []),
4243
];
4244
const readStats = Effect.fn("GitVcsDriver.getReviewDiffPreview.stat")(function* (