@devries-cameron20 / t3code Mirror · read-only / commits / 48a292364a
Fork 0

The best way to control Claude Code, Codex and more from any computer or phone

Mirrored from https://github.com/Camo67/t3code.git

Synced Nov 22, 13:15 UTC

fix(web): file preview wrap buttons no longer turn off word wrap everywhere (#26432)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

Theo Browne committed Oct 28, 2026 at 04:21 UTC 48a292364ab37574c67fb377b5227e5d281d9203
5 files changed +46 -11
apps/web/src/components/files/AttachmentFilePreview.browser.test.tsx
+21 -1
@@ -18,7 +18,9 @@ vi.mock(import("~/assets/assetUrls"), async (original) => ({
18 // The real source view highlights through a worker pool; the text it receives is what matters here.
19 // Never load the original: its highlighter graph can outlast waitFor on a cold CI browser.
20 vi.mock(import("./ReadOnlySourcePreview"), () => ({
21 - default: ({ text }: { text: string }) => <pre>{text}</pre>,
21 + default: ({ text, wordWrap }: { text: string; wordWrap?: boolean }) => (
22 + <pre data-word-wrap={String(wordWrap)}>{text}</pre>
23 + ),
24 }));
25
26 // The Word engine compiles about 30 MB of WebAssembly in a fresh worker per document, which took
@@ -41,6 +43,7 @@ vi.mock(import("./office/WordDocument"), async () => {
43 };
44 });
45
46 +import { getClientSettings } from "~/hooks/useSettings";
47 import { AttachmentFilePreview } from "./AttachmentFilePreview";
48 import LargeTextViewer from "./LargeTextViewer";
49 import VirtualTablePreview from "./VirtualTablePreview";
@@ -492,6 +495,7 @@ describe("large text preview recovery", () => {
495 workspaceMutationId={mutation}
496 revealLine={null}
497 revealRequestId={0}
498 + wordWrap
499 />
500 </div>
501 );
@@ -2341,6 +2345,22 @@ it("toggles a Mermaid attachment between diagram and source through the lazy pre
2345 expect(screen.container.querySelector('[role="alert"]')).toBeNull();
2346 });
2347
2348 +it("unwraps one text attachment without turning off the word wrap setting", async () => {
2349 + const file = new Blob(["a long line"], { type: "text/plain" });
2350 + await using screen = await render(
2351 + <AttachmentFilePreview
2352 + name="notes.txt"
2353 + mimeType={file.type}
2354 + sizeBytes={file.size}
2355 + file={file}
2356 + />,
2357 + );
2358 + await screen.getByRole("button", { name: "Disable word wrap" }).click();
2359 + await expect.element(screen.getByRole("button", { name: "Enable word wrap" })).toBeVisible();
2360 + expect(getClientSettings().wordWrap).toBe(true);
2361 + expect(screen.container.querySelector("pre")?.dataset.wordWrap).toBe("false");
2362 +});
2363 +
2364 it("mounts a bounded set of saved notebook outputs as the reader scrolls", async () => {
2365 const notebook = {
2366 nbformat: 4,
apps/web/src/components/files/AttachmentFilePreview.tsx
+8 -5
@@ -21,7 +21,7 @@ import { MorphIcon } from "~/components/MorphIcon";
21 import { ScrollArea } from "~/components/ui/scroll-area";
22 import { toastManager } from "~/components/ui/toast";
23 import { useCopyToClipboard } from "~/hooks/useCopyToClipboard";
24 -import { useClientSettings, updateClientSettings } from "~/hooks/useSettings";
24 +import { useClientSettings } from "~/hooks/useSettings";
25 import { cn } from "~/lib/utils";
26
27 import { BinaryFilePreview } from "./BinaryFilePreview";
@@ -55,7 +55,7 @@ const SourcePreview = lazy(() => import("./ReadOnlySourcePreview"));
55
56 const STALE_URL_MS = 5 * 60_000;
57
58 -export function ReadOnlySourcePreview(props: { name: string; text: string }) {
58 +export function ReadOnlySourcePreview(props: { name: string; text: string; wordWrap?: boolean }) {
59 return (
60 <Suspense fallback={<FileSurfaceLoading className="p-4" />}>
61 <SourcePreview {...props} />
@@ -214,7 +214,9 @@ export function AttachmentFilePreview(props: {
214 return () => controller.abort();
215 }, [url, needsText, streamsText, revision, props.sizeBytes, props.file, refresh]);
216 const failure = error ?? (needsText ? contentError : null);
217 - const wordWrap = useClientSettings((settings) => settings.wordWrap);
217 + const defaultWordWrap = useClientSettings((settings) => settings.wordWrap);
218 + const [wordWrapOverride, setWordWrapOverride] = useState<boolean | null>(null);
219 + const wordWrap = wordWrapOverride ?? defaultWordWrap;
220 const showsRawText =
221 failure === null &&
222 needsText &&
@@ -272,6 +274,7 @@ export function AttachmentFilePreview(props: {
274 onRetry={() => setRevision((value) => value + 1)}
275 delimiter={rendered ? delimiter : null}
276 copyContents={copyContents}
277 + wordWrap={wordWrap}
278 />
279 </Suspense>
280 ) : !url || (needsText && !content) ? (
@@ -292,7 +295,7 @@ export function AttachmentFilePreview(props: {
295 />
296 </ScrollArea>
297 ) : (
295 - <ReadOnlySourcePreview name={props.name} text={content.text} />
298 + <ReadOnlySourcePreview name={props.name} text={content.text} wordWrap={wordWrap} />
299 )
300 ) : kind === "archive" || kind === "sqlite" ? (
301 <BinaryFilePreview
@@ -387,7 +390,7 @@ export function AttachmentFilePreview(props: {
390 <FileSurfaceAction
391 label={wordWrap ? "Disable word wrap" : "Enable word wrap"}
392 pressed={wordWrap}
390 - onPress={() => updateClientSettings({ wordWrap: !wordWrap })}
393 + onPress={() => setWordWrapOverride(!wordWrap)}
394 >
395 <WrapTextIcon className="size-3.5" />
396 </FileSurfaceAction>
apps/web/src/components/files/FilePreviewPanel.tsx
+9 -3
@@ -56,7 +56,7 @@ import { MediaVideoPlayer } from "~/components/media/MediaVideoPlayer";
56 import { MediaActions, type MediaActionSource } from "~/components/media/MediaActions";
57 import { MorphIcon } from "~/components/MorphIcon";
58 import { useRemoteOpenState } from "~/remoteOpen";
59 -import { useClientSettings, updateClientSettings } from "~/hooks/useSettings";
59 +import { useClientSettings } from "~/hooks/useSettings";
60 import { useTheme } from "~/hooks/useTheme";
61 import { getLocalStorageItem, setLocalStorageItem, useLocalStorage } from "~/hooks/useLocalStorage";
62 import { resolveDiffThemeName } from "~/lib/diffRendering";
@@ -996,7 +996,9 @@ export default function FilePreviewPanel({
996 attachment === undefined ? resolveFilePreviewPath(requestedPath, cwd) : requestedPath;
997 const draft = typeof composerDraftTarget === "string";
998 const { resolvedTheme } = useTheme();
999 - const wordWrap = useClientSettings((settings) => settings.wordWrap);
999 + const defaultWordWrap = useClientSettings((settings) => settings.wordWrap);
1000 + const [wordWrapOverride, setWordWrapOverride] = useState<boolean | null>(null);
1001 + const wordWrap = wordWrapOverride ?? defaultWordWrap;
1002 const canOperatePreview = useEnvironmentScope(environmentId, AuthPreviewOperateScope);
1003 const primaryEnvironmentId = usePrimaryEnvironmentId();
1004 const remoteOpenState = useRemoteOpenState(environmentId);
@@ -1291,7 +1293,7 @@ export default function FilePreviewPanel({
1293 <FileSurfaceAction
1294 label={wordWrap ? "Disable word wrap" : "Enable word wrap"}
1295 pressed={wordWrap}
1294 - onPress={() => updateClientSettings({ wordWrap: !wordWrap })}
1296 + onPress={() => setWordWrapOverride(!wordWrap)}
1297 >
1298 <WrapTextIcon className="size-3.5" />
1299 </FileSurfaceAction>
@@ -1403,6 +1405,7 @@ export default function FilePreviewPanel({
1405 workspaceMutationId={workspaceMutationId}
1406 revealLine={revealLine}
1407 revealRequestId={revealRequestId}
1408 + wordWrap={wordWrap}
1409 />
1410 ) : relativePath &&
1411 absolutePath &&
@@ -1488,6 +1491,7 @@ export default function FilePreviewPanel({
1491 text={file.data.contents}
1492 cacheKey={projectFileCacheKey(cwd, relativePath, file.data.contents)}
1493 onPostRender={onFilePostRender}
1494 + wordWrap={wordWrap}
1495 />
1496 ) : (
1497 <DiffWorkerPoolProvider>
@@ -1557,6 +1561,7 @@ export function WorkspaceLargeTextPreview(props: {
1561 workspaceMutationId: string | null;
1562 revealLine: number | null;
1563 revealRequestId: number;
1564 + wordWrap: boolean;
1565 }) {
1566 const resource = {
1567 _tag: "media-file",
@@ -1659,6 +1664,7 @@ export function WorkspaceLargeTextPreview(props: {
1664 delimiter={props.delimiter}
1665 revealLine={props.revealLine}
1666 revealRequestId={props.revealRequestId}
1667 + wordWrap={props.wordWrap}
1668 />
1669 </Suspense>
1670 </>
apps/web/src/components/files/LargeTextViewer.tsx
+4 -1
@@ -36,6 +36,8 @@ export default function LargeTextViewer(props: {
36 readonly delimiter: "," | "\t" | null;
37 readonly revealLine?: number | null;
38 readonly revealRequestId?: number;
39 + /** A preview's own wrap toggle; omitted follows the word wrap setting. */
40 + readonly wordWrap?: boolean;
41 }) {
42 const [meta, setMeta] = useState<Extract<TextPreviewResult, { type: "meta" }> | null>(null);
43 const [pages, setPages] = useState(new Map<number, string[][]>());
@@ -46,7 +48,8 @@ export default function LargeTextViewer(props: {
48 reject: (cause: Error) => void;
49 } | null>(null);
50 const pending = useRef(new Set<number>());
49 - const wordWrap = useClientSettings((settings) => settings.wordWrap);
51 + const defaultWordWrap = useClientSettings((settings) => settings.wordWrap);
52 + const wordWrap = props.wordWrap ?? defaultWordWrap;
53 // oxlint-disable-next-line t3code/no-unreasoned-state-sync -- Own the prefix fetch and indexing worker, cancelling requests and pending copies when the source changes or unmounts.
54 useEffect(() => {
55 // oxlint-disable-next-line react/set-state-in-effect -- A replacement source must discard the previous worker's error and pages.
apps/web/src/components/files/ReadOnlySourcePreview.tsx
+4 -1
@@ -13,9 +13,12 @@ export default function ReadOnlySourcePreview(props: {
13 readonly text: string;
14 readonly cacheKey?: string;
15 readonly onPostRender?: FileOptions<unknown, undefined>["onPostRender"];
16 + /** A preview's own wrap toggle; omitted follows the word wrap setting. */
17 + readonly wordWrap?: boolean;
18 }) {
19 const resolvedTheme = useRenderedAppearance();
18 - const wordWrap = useClientSettings((settings) => settings.wordWrap);
20 + const defaultWordWrap = useClientSettings((settings) => settings.wordWrap);
21 + const wordWrap = props.wordWrap ?? defaultWordWrap;
22 return (
23 <DiffWorkerPoolProvider>
24 <Virtualizer