The best way to control Claude Code, Codex and more from any computer or phone
Mirrored from https://github.com/Camo67/t3code.git
Synced Nov 21, 14:45 UTC
fix(web,mobile): pull request project filter lists pinned projects first (#29871)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Alex Southwell committed
Nov 15, 2026 at 03:13 UTC
49eb9c8adc7ee4d4789e5e65fda7cfa7fba87da7
3 files changed
+34
-5
apps/mobile/src/features/pull-requests/PullRequestListFilters.tsx
+12
-2
@@ -41,12 +41,18 @@ function choices(field: string, options: Readonly<Record<string, string>>, selec
41
}));
42
}
43
44
-type ProjectOrder = readonly { readonly memberProjectRefs: readonly ScopedProjectRef[] }[];
44
+type ProjectOrder = readonly {
45
+ readonly memberProjectRefs: readonly ScopedProjectRef[];
46
+ readonly pinned: boolean;
47
+ readonly archived: boolean;
48
+}[];
49
const sameProjectOrder = (previous: ProjectOrder, next: ProjectOrder) =>
50
previous.length === next.length &&
51
previous.every((group, index) => {
52
const members = next[index]!.memberProjectRefs;
53
return (
54
+ group.pinned === next[index]!.pinned &&
55
+ group.archived === next[index]!.archived &&
56
group.memberProjectRefs.length === members.length &&
57
group.memberProjectRefs.every(
58
(ref, member) =>
@@ -69,7 +75,11 @@ const sidebarProjectOrderFamily = Atom.family((mode: SidebarProjectGroupingMode)
75
threads: get(environmentThreadShells.threadShellsAtom),
76
pendingTasks: [],
77
projectSortOrder: "updated_at",
72
- }).map((scope) => ({ memberProjectRefs: scope.projectRefs })),
78
+ }).map((scope) => ({
79
+ memberProjectRefs: scope.projectRefs,
80
+ pinned: scope.pinned,
81
+ archived: scope.archived,
82
+ })),
83
).pipe(Atom.withEquality(sameProjectOrder)),
84
);
85
packages/client-runtime/src/state/projectGrouping.test.ts
+16
-1
@@ -474,8 +474,23 @@ describe("sortProjectsByGroupOrder", () => {
474
it("tells the same project id on two environments apart", () => {
475
const sorted = sortProjectsByGroupOrder(
476
[project("shared"), project("shared", remote)],
477
- [{ memberProjectRefs: [ref("shared", remote)] }, { memberProjectRefs: [ref("shared")] }],
477
+ [
478
+ { memberProjectRefs: [ref("shared", remote)], pinned: false, archived: false },
479
+ { memberProjectRefs: [ref("shared")], pinned: false, archived: false },
480
+ ],
481
);
482
expect(sorted.map((entry) => entry.environmentId)).toEqual([remote, environmentId]);
483
});
484
+
485
+ it("lists pinned projects first and archived ones last, like the sidebar's project menu", () => {
486
+ const sorted = sortProjectsByGroupOrder(
487
+ [project("archived"), project("recent"), project("pinned"), project("unlisted")],
488
+ [
489
+ { memberProjectRefs: [ref("archived")], pinned: false, archived: true },
490
+ { memberProjectRefs: [ref("recent")], pinned: false, archived: false },
491
+ { memberProjectRefs: [ref("pinned")], pinned: true, archived: false },
492
+ ],
493
+ );
494
+ expect(sorted.map((entry) => entry.id)).toEqual(["pinned", "recent", "archived", "unlisted"]);
495
+ });
496
});
packages/client-runtime/src/state/projectGrouping.ts
+6
-2
@@ -401,10 +401,14 @@ export function sortProjectsByGroupOrder<
401
TProject extends { readonly id: string; readonly environmentId: string },
402
>(
403
projects: ReadonlyArray<TProject>,
404
- groups: ReadonlyArray<{ readonly memberProjectRefs: ReadonlyArray<ScopedProjectRef> }>,
404
+ groups: ReadonlyArray<{
405
+ readonly memberProjectRefs: ReadonlyArray<ScopedProjectRef>;
406
+ readonly pinned: boolean;
407
+ readonly archived: boolean;
408
+ }>,
409
): TProject[] {
410
const rankByProject = new Map<string, number>();
407
- groups.forEach((group, rank) => {
411
+ pickableProjectGroups(groups).forEach((group, rank) => {
412
for (const ref of group.memberProjectRefs) {
413
const key = `${ref.environmentId}\0${ref.projectId}`;
414
if (!rankByProject.has(key)) rankByProject.set(key, rank);