@devries-cameron20 / t3code Mirror · read-only / commits / 4ce9205d1f
Fork 0

The best way to control Claude Code, Codex and more from any computer or phone

Mirrored from https://github.com/Camo67/t3code.git

Synced Nov 22, 12:00 UTC

fix(web): support Home and End on hue sliders (#23465)

Co-authored-by: GPT-6.1 Sol <noreply@openai.com>

Victor Vogel committed Oct 30, 2026 at 15:51 UTC 4ce9205d1fe86c7b977a9e12960614bfe797777c
2 files changed +28 -1
apps/web/src/components/settings/colorPickers.browser.test.tsx
+23 -1
@@ -1,7 +1,7 @@
1 import { describe, expect, it, vi } from "vite-plus/test";
2 import { userEvent } from "vite-plus/test/browser";
3
4 -import type { ReactNode } from "react";
4 +import { useState, type ReactNode } from "react";
5
6 import { act, render } from "../../../test/render";
7 import { ProviderAccentColorPicker } from "./ProviderAccentColorPicker";
@@ -69,7 +69,29 @@ async function renderThemeField(value: string) {
69 });
70 }
71
72 +function ControlledThemeField() {
73 + const [value, setValue] = useState("#408080");
74 + return <ThemeColorField role="accent" value={value} onChange={(_, next) => setValue(next)} />;
75 +}
76 +
77 describe("theme color field", () => {
78 + it("jumps hue to both endpoints without changing saturation or brightness", async () => {
79 + await using _screen = await render(<ControlledThemeField />);
80 + await open("Choose Accent color color");
81 +
82 + await press(HUE, "Home");
83 + expect(slider(HUE).getAttribute("aria-valuenow")).toBe("0");
84 + expect(byLabel<HTMLInputElement>("Accent color picker hex value").value).toBe("#804040");
85 +
86 + await press(HUE, "End");
87 + expect(slider(HUE).getAttribute("aria-valuenow")).toBe("360");
88 + expect(byLabel<HTMLInputElement>("Accent color picker hex value").value).toBe("#804040");
89 +
90 + await press(HUE, "ArrowRight", true);
91 + expect(slider(HUE).getAttribute("aria-valuenow")).toBe("10");
92 + expect(byLabel<HTMLInputElement>("Accent color picker hex value").value).toBe("#804b40");
93 + });
94 +
95 it("keeps the selected hue when a grey color is echoed back from theme settings", async () => {
96 await using screen = await renderThemeField("#ff0000");
97 const { onChange, echo } = screen;
apps/web/src/components/ui/color-picker.tsx
+5
@@ -182,6 +182,11 @@ export function ColorHueSlider({
182 }, onInteractionEnd);
183
184 const handleKeyDown = (event: KeyboardEvent<HTMLDivElement>) => {
185 + if (event.key === "Home" || event.key === "End") {
186 + event.preventDefault();
187 + onChange(event.key === "Home" ? 0 : 360);
188 + return;
189 + }
190 if (!["ArrowDown", "ArrowLeft", "ArrowRight", "ArrowUp"].includes(event.key)) return;
191 event.preventDefault();
192 const step = event.shiftKey ? 10 : 1;