@devries-cameron20 / t3code Mirror · read-only / commits / 571d3bc45e
Fork 0

The best way to control Claude Code, Codex and more from any computer or phone

Mirrored from https://github.com/Camo67/t3code.git

Synced Nov 22, 22:00 UTC

fix(server): viewport capture test waits for the requested size, not any resize (#22154)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

Julius Marminge committed Oct 19, 2026 at 22:57 UTC 571d3bc45ebb744a0ffc10ba783d91da9f091073
2 files changed +44 -6
apps/server/src/preview/ServerBrowserPage.test.ts
+12 -5
@@ -370,9 +370,7 @@ describe("server browser drag", () => {
370 });
371 });
372
373 -// TODO(#19913 follow-up): flaky in CI since 2e8b5b9d; the capture can return the pre-resize frame.
374 -// Skipped to unblock main; a proper fix makes the capture wait for the resized frame.
375 -it.skip("captures the native display viewport after page script reassigns the globals", async () => {
373 +it("captures the native display viewport after page script reassigns the globals", async () => {
374 // Context deviceScaleFactor changes DPR but does not scale raw CDP captures.
375 const browser = await chromium.launch({
376 headless: true,
@@ -411,9 +409,13 @@ it.skip("captures the native display viewport after page script reassigns the gl
409 offset: { x: 0, y: 0 },
410 });
411 const { windowId } = await cdp.send("Browser.getWindowForTarget");
414 - // CDP acknowledges the bounds change before the renderer applies the resize.
412 + // CDP acknowledges the bounds change before the renderer applies it, and a resize event can
413 + // fire for a size on the way there. Page script replaced innerWidth, so read the layout.
414 const resize = await page.evaluateHandle(`({
416 - done: new Promise(resolve => window.addEventListener("resize", () => resolve(), { once: true })),
415 + done: new Promise(resolve => window.addEventListener("resize", () => {
416 + const { clientWidth, clientHeight } = document.documentElement;
417 + if (clientWidth === 390 && clientHeight === 844) resolve();
418 + })),
419 })`);
420 await cdp.send("Browser.setWindowBounds", {
421 windowId,
@@ -421,6 +423,11 @@ it.skip("captures the native display viewport after page script reassigns the gl
423 });
424 await resize.evaluate("resize => resize.done");
425 await resize.dispose();
426 + expect(await ServerBrowserPage.readPageMetrics(cdp)).toMatchObject({
427 + ratio: 1.5,
428 + width: 390,
429 + height: 844,
430 + });
431 expect(await snapshotSize()).toEqual({ width: 585, height: 1266 });
432 } finally {
433 await browser.close();
apps/server/src/preview/ServerBrowserPage.ts
+32 -1
@@ -26,6 +26,7 @@ const MAX_EVALUATION_BYTES = 64_000;
26 const MAX_VISIBLE_TEXT_LENGTH = 20_000;
27 const MAX_SCREENSHOT_WIDTH = 1280;
28 const WAIT_POLL_MS = 100;
29 +const RESIZED_FRAME_MS = 2_000;
30 export const DIAGNOSTIC_BUFFER_LIMIT = 200;
31
32 export class ServerBrowserOperationError extends Error {
@@ -484,6 +485,36 @@ const renderingOf = async (input: SnapshotInput) => {
485 };
486 };
487
488 +// A desktop window reports a resize before its compositor draws a frame at the new size, so an
489 +// unclipped capture can still return the old frame. Bounded: a frame that never matches is kept.
490 +// Headless pages are sized by the server, which awaits each resize.
491 +const captureResized = async (
492 + input: SnapshotInput,
493 + options: {
494 + readonly scale: number;
495 + readonly viewport: Viewport;
496 + readonly offset: { readonly x: number; readonly y: number } | undefined;
497 + readonly renderScale: number;
498 + },
499 + deadline: number,
500 +) => {
501 + if (input.renderScale !== "display")
502 + return captureViewport(input.page, input.cdp, { format: "png", ...options });
503 + const expected = {
504 + width: options.viewport.width * options.renderScale * options.scale,
505 + height: options.viewport.height * options.renderScale * options.scale,
506 + };
507 + const giveUpAt = Math.min(Date.now() + RESIZED_FRAME_MS, deadline - 2_000);
508 + for (;;) {
509 + const data = await captureViewport(input.page, input.cdp, { format: "png", ...options });
510 + const size = pngSize(data);
511 + const matches =
512 + Math.abs(size.width - expected.width) <= 1 && Math.abs(size.height - expected.height) <= 1;
513 + if (matches || Date.now() + WAIT_POLL_MS >= giveUpAt) return data;
514 + await new Promise((resolve) => setTimeout(resolve, WAIT_POLL_MS));
515 + }
516 +};
517 +
518 const capture = async (
519 input: SnapshotInput,
520 deadline: number,
@@ -506,7 +537,7 @@ const capture = async (
537 "url" | "title" | "loading" | "visibleText" | "interactiveElements"
538 >
539 >,
509 - captureViewport(input.page, input.cdp, { format: "png", scale, viewport, offset }),
540 + captureResized(input, { scale, viewport, offset, renderScale }, deadline),
541 ]);
542 void pageAndScreenshot.catch(constVoid);
543 // Leaves time for the second read; a frame that never loads holds the tree until then.