The best way to control Claude Code, Codex and more from any computer or phone
Mirrored from https://github.com/Camo67/t3code.git
Synced Nov 21, 22:15 UTC
fix(server): detach errored provider sessions when deleting threads (#34199)
Romil committed
Nov 12, 2026 at 10:18 UTC
5a3e368c1b3d2729e51b16e17c92e73a043cb015
2 files changed
+9
-2
apps/server/src/orchestration-v2/ThreadDeletion.test.ts
+7
-1
@@ -279,7 +279,7 @@ it.effect("queues provider and resource cleanup and preserves an earlier deletio
279
assert.deepEqual(deleted.thread.deletedAt, createdAt);
280
assert.deepEqual(
281
deleted.providerSessions.map((session) => session.status),
282
- ["stopped", "error"],
282
+ ["stopped"],
283
);
284
assert.deepEqual(
285
plan.effects.map((effect) => effect.request),
@@ -290,6 +290,12 @@ it.effect("queues provider and resource cleanup and preserves an earlier deletio
290
detail: "Thread deleted.",
291
revokeMcpCredential: true,
292
},
293
+ {
294
+ type: "provider-session.detach",
295
+ providerSessionId: ProviderSessionId.make("session:delete-plan:error"),
296
+ detail: "Thread deleted.",
297
+ revokeMcpCredential: true,
298
+ },
299
{ type: "scheduled-tasks.cleanup" },
300
{ type: "terminal.cleanup" },
301
{ type: "preview.cleanup" },
apps/server/src/orchestration-v2/ThreadDeletion.ts
+2
-1
@@ -183,7 +183,8 @@ export const planThreadDeletion = Effect.fn("ThreadDeletion.planThreadDeletion")
183
}
184
185
for (const session of projection.providerSessions) {
186
- if (session.status === "stopped" || session.status === "error") continue;
186
+ // An errored session can still own a reusable live runtime.
187
+ if (session.status === "stopped") continue;
188
yield* emitEvent({
189
type: "provider-session.detached",
190
threadId: command.threadId,