@devries-cameron20 / t3code Mirror · read-only / commits / 5fa0d0be7d
Fork 0

The best way to control Claude Code, Codex and more from any computer or phone

Mirrored from https://github.com/Camo67/t3code.git

Synced Nov 22, 07:00 UTC

fix(clients): cancel oversized project icon responses (#29006)

luke committed Nov 3, 2026 at 01:36 UTC 5fa0d0be7df7aa810e924b703f7ca036d34c16d4
2 files changed +13 -2
packages/client-runtime/src/projectFaviconCache.test.ts
+9 -1
@@ -202,11 +202,19 @@ describe("project favicon image loader", () => {
202 await expect(load(url, signal())).rejects.toThrow("too large");
203 expect(pulled).toBeLessThan(PROJECT_FAVICON_MAX_SOURCE_BYTES / chunk.byteLength + 3);
204 expect(downscale).not.toHaveBeenCalled();
205 + let cancelled = false;
206 + const declaredStream = new ReadableStream<Uint8Array>({
207 + cancel() {
208 + cancelled = true;
209 + },
210 + });
211 const declared = loader(
206 - new Response("x", {
212 + new Response(declaredStream, {
213 headers: { "content-type": "image/png", "content-length": String(2 ** 40) },
214 }),
215 );
216 await expect(declared.load(url, signal())).rejects.toThrow("too large");
217 + expect(cancelled).toBe(true);
218 + expect(declared.downscale).not.toHaveBeenCalled();
219 });
220 });
packages/client-runtime/src/projectFaviconCache.ts
+4 -1
@@ -50,7 +50,10 @@ export interface ProjectFaviconStorage {
50
51 async function readBounded(response: Response, maxBytes: number) {
52 const declared = Number(response.headers.get("content-length"));
53 - if (declared > maxBytes) throw new Error("Project icon is too large to decode.");
53 + if (declared > maxBytes) {
54 + await response.body?.cancel().catch(() => {});
55 + throw new Error("Project icon is too large to decode.");
56 + }
57 if (!response.body) {
58 const bytes = new Uint8Array<ArrayBuffer>(await response.arrayBuffer());
59 if (bytes.byteLength > maxBytes) throw new Error("Project icon is too large to decode.");