The best way to control Claude Code, Codex and more from any computer or phone
Mirrored from https://github.com/Camo67/t3code.git
Synced Nov 21, 14:45 UTC
fix(web): diagnostics no longer shows near-second spans as "1000 ms" (#29377)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Mokhles elheni committed
Nov 14, 2026 at 15:13 UTC
5fe2f7e4567d9e530ded0dabc9d706db27d77b84
3 files changed
+21
-11
apps/web/src/components/settings/DiagnosticsSettings.logic.test.ts
new
+9
@@ -0,0 +1,9 @@
1
+import { describe, expect, it } from "vite-plus/test";
2
+
3
+import { formatDiagnosticsDuration } from "./DiagnosticsSettings.logic";
4
+
5
+describe("formatDiagnosticsDuration", () => {
6
+ it("prints durations that round up to a second in seconds", () => {
7
+ expect([999.4, 999.6, 1_000].map(formatDiagnosticsDuration)).toEqual(["999 ms", "1 s", "1 s"]);
8
+ });
9
+});
apps/web/src/components/settings/DiagnosticsSettings.logic.ts
new
+5
@@ -0,0 +1,5 @@
1
+export function formatDiagnosticsDuration(value: number): string {
2
+ const milliseconds = Math.round(value);
3
+ if (milliseconds < 1_000) return `${milliseconds} ms`;
4
+ return `${(value / 1_000).toFixed(value >= 10_000 ? 1 : 2).replace(/\.0+$/, "")} s`;
5
+}
apps/web/src/components/settings/DiagnosticsSettings.tsx
+7
-11
@@ -39,6 +39,7 @@ import { ScrollArea } from "../ui/scroll-area";
39
import { Toggle, ToggleGroup } from "../ui/toggle-group";
40
import { Tooltip, TooltipPopup, TooltipTrigger } from "../ui/tooltip";
41
import { toastManager } from "../ui/toast";
42
+import { formatDiagnosticsDuration } from "./DiagnosticsSettings.logic";
43
import { ExpandableText } from "./ExpandableText";
44
import { ResourceTelemetryDiagnostics } from "./ResourceTelemetryDiagnostics";
45
import { SettingsPageContainer, SettingsSection } from "./settingsLayout";
@@ -52,11 +53,6 @@ function formatCount(value: number): string {
53
return NUMBER_FORMAT.format(value);
54
}
55
55
-function formatDuration(value: number): string {
56
- if (value < 1_000) return `${Math.round(value)} ms`;
57
- return `${(value / 1_000).toFixed(value >= 10_000 ? 1 : 2).replace(/\.0+$/, "")} s`;
58
-}
59
-
56
function RelativeTimeNoWrap(props: { value: DateTime.Utc }) {
57
const relative = useRelativeTimeState(DateTime.formatIso(props.value));
58
if (relative.status !== "relative") return null;
@@ -1020,7 +1016,7 @@ function DiagnosticsSettingsBody() {
1016
resourceData
1017
? resourceData.sampleIntervalMs === 0
1018
? "On demand"
1023
- : formatDuration(resourceData.sampleIntervalMs)
1019
+ : formatDiagnosticsDuration(resourceData.sampleIntervalMs)
1020
: "..."
1021
}
1022
/>
@@ -1101,7 +1097,7 @@ function DiagnosticsSettingsBody() {
1097
value={data ? formatCount(data.slowSpanCount) : "..."}
1098
tooltip={
1099
data
1104
- ? `Spans with a duration of ${formatDuration(data.slowSpanThresholdMs)} or longer.`
1100
+ ? `Spans with a duration of ${formatDiagnosticsDuration(data.slowSpanThresholdMs)} or longer.`
1101
: "Spans at or above the configured slow-span threshold."
1102
}
1103
tone={data && data.slowSpanCount > 0 ? "warning" : "default"}
@@ -1157,7 +1153,7 @@ function DiagnosticsSettingsBody() {
1153
<ExpandableText text={failure.cause} />
1154
</td>
1155
<td className="px-4 py-3 align-top font-mono tabular-nums">
1160
- {formatDuration(failure.durationMs)}
1156
+ {formatDiagnosticsDuration(failure.durationMs)}
1157
</td>
1158
<td className="whitespace-nowrap px-4 py-3 align-top font-mono tabular-nums text-muted-foreground last:sm:pr-5">
1159
<RelativeTimeNoWrap value={failure.endedAt} />
@@ -1213,7 +1209,7 @@ function DiagnosticsSettingsBody() {
1209
{span.name}
1210
</td>
1211
<td className="px-4 py-3 align-top font-mono tabular-nums">
1216
- {formatDuration(span.durationMs)}
1212
+ {formatDiagnosticsDuration(span.durationMs)}
1213
</td>
1214
<td className="w-px whitespace-nowrap px-4 py-3 align-top font-mono tabular-nums text-muted-foreground">
1215
<RelativeTimeNoWrap value={span.endedAt} />
@@ -1313,10 +1309,10 @@ function DiagnosticsSettingsBody() {
1309
{formatCount(span.failureCount)}
1310
</td>
1311
<td className="whitespace-nowrap px-4 py-3 align-top font-mono tabular-nums">
1316
- {formatDuration(span.averageDurationMs)}
1312
+ {formatDiagnosticsDuration(span.averageDurationMs)}
1313
</td>
1314
<td className="whitespace-nowrap px-4 py-3 align-top font-mono tabular-nums last:sm:pr-5">
1319
- {formatDuration(span.maxDurationMs)}
1315
+ {formatDiagnosticsDuration(span.maxDurationMs)}
1316
</td>
1317
</tr>
1318
))}