The best way to control Claude Code, Codex and more from any computer or phone
Mirrored from https://github.com/Camo67/t3code.git
Synced Nov 22, 10:45 UTC
fix(server): launched threads step down to a runtime mode their provider offers (#26682)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: maria-rcks <maria@kuuro.net>
Henry Chu committed
Oct 30, 2026 at 21:42 UTC
65965f7ab8b104545b829d4883e66a67b919a014
5 files changed
+75
-4
apps/server/src/mcp/toolkits/project/handlers.test.ts
+56
@@ -244,6 +244,62 @@ it.effect(
244
}),
245
);
246
247
+it.effect("a launch steps an inherited mode down to the provider's, and refuses one it lacks", () =>
248
+ Effect.gen(function* () {
249
+ // Pi offers no Auto; a mode a provider lacks would run as Supervised.
250
+ const pi = ProviderInstanceId.make("pi");
251
+ const launchPi = Effect.fn("test.launchPi")(function* (runtimeMode?: RuntimeMode) {
252
+ const launched: Array<ThreadLaunch.ThreadLaunchInput> = [];
253
+ const { projectId, dependencies } = clientLaunchHarness({
254
+ runtimeModeCeiling: "auto",
255
+ launched,
256
+ providers: [
257
+ {
258
+ instanceId: pi,
259
+ driver: ProviderDriverKind.make("pi"),
260
+ enabled: true,
261
+ installed: true,
262
+ status: "ready",
263
+ version: null,
264
+ auth: { status: "authenticated" },
265
+ checkedAt: "2026-01-01T00:00:00Z",
266
+ models: [],
267
+ slashCommands: [],
268
+ skills: [],
269
+ supportedRuntimeModes: ["approval-required", "auto-accept-edits", "full-access"],
270
+ },
271
+ ],
272
+ });
273
+ const toolkit = yield* ProjectToolkit.pipe(
274
+ Effect.provide(
275
+ McpToolAccess.HandlersLayer.layer(ProjectHandlers.layer).pipe(
276
+ Layer.provide(dependencies),
277
+ ),
278
+ ),
279
+ );
280
+ const result = yield* toolkit
281
+ .handle("t3_thread_launch", {
282
+ projectId,
283
+ title: "Fix",
284
+ modelSelection: { instanceId: pi, model: "pi-model" },
285
+ ...(runtimeMode === undefined ? {} : { runtimeMode }),
286
+ })
287
+ .pipe(Stream.unwrap, Stream.runCollect, Effect.provide(dependencies));
288
+ return { result: result.at(-1)?.result, launched };
289
+ });
290
+
291
+ const inherited = yield* launchPi();
292
+ expect(inherited.launched[0]?.runtimeMode).toBe("auto-accept-edits");
293
+
294
+ const requested = yield* launchPi("auto");
295
+ expect(requested.result).toMatchObject({ code: "invalid_request" });
296
+ expect(requested.launched).toHaveLength(0);
297
+
298
+ const offered = yield* launchPi("approval-required");
299
+ expect(offered.launched[0]?.runtimeMode).toBe("approval-required");
300
+ }),
301
+);
302
+
303
it.effect("a launch retried with the same clientRequestId replays the first one", () =>
304
Effect.gen(function* () {
305
const launched: Array<ThreadLaunch.ThreadLaunchInput> = [];
apps/server/src/mcp/toolkits/project/handlers.ts
+10
-1
@@ -204,12 +204,21 @@ export const layer = McpToolAccess.toLayer(ProjectToolkit, {
204
message:
205
"Pass modelSelection: the project has no default model. orchestrator_capabilities lists providers and models.",
206
});
207
- const startedRuntimeMode =
207
+ let startedRuntimeMode =
208
projectDefaults !== undefined && input.runtimeMode === undefined
209
? yield* resolveRuntimeMode(runtimeMode, projectDefaults.defaultRuntimeMode).pipe(
210
Effect.orElseSucceed(() => runtimeMode),
211
)
212
: runtimeMode;
213
+ if (!replaying) {
214
+ const providers = yield* (yield* ProviderRegistry.ProviderRegistry).getProviders;
215
+ startedRuntimeMode = yield* resolveRuntimeMode(startedRuntimeMode, input.runtimeMode, {
216
+ modelSelection,
217
+ supportedRuntimeModes: providers.find(
218
+ (provider) => provider.instanceId === modelSelection.instanceId,
219
+ )?.supportedRuntimeModes,
220
+ });
221
+ }
222
const result = yield* ThreadMessageIntake.launchThread({
223
commandId,
224
threadId,
apps/server/src/peer/PeerForwarding.test.ts
+3
-1
@@ -225,7 +225,9 @@ const serveBox = (seen: Ref.Ref<Seen>, linkSession: Ref.Ref<string>) =>
225
),
226
),
227
Layer.provide(NodeServices.layer),
228
- Layer.provide(Layer.mock(ProviderRegistry.ProviderRegistry)({})),
228
+ Layer.provide(
229
+ Layer.mock(ProviderRegistry.ProviderRegistry)({ getProviders: Effect.succeed([]) }),
230
+ ),
231
Layer.provide(Layer.mock(ProviderAdapterRegistry.ProviderAdapterRegistryV2)({})),
232
Layer.provide(Layer.mock(ScheduledTaskService.ScheduledTaskService)({})),
233
Layer.provide(Layer.mock(ProjectCloneTracker.ProjectCloneTracker)({})),
apps/server/src/peer/RemoteDelegation.test.ts
+3
-1
@@ -482,7 +482,9 @@ const boxToolkitLayer = (thread: BoxThread) => {
482
Layer.provide(NodeServices.layer),
483
),
484
),
485
- Layer.provide(Layer.mock(ProviderRegistry.ProviderRegistry)({})),
485
+ Layer.provide(
486
+ Layer.mock(ProviderRegistry.ProviderRegistry)({ getProviders: Effect.succeed([]) }),
487
+ ),
488
Layer.provide(Layer.mock(ProviderAdapterRegistry.ProviderAdapterRegistryV2)({})),
489
Layer.provide(Layer.mock(ScheduledTaskService.ScheduledTaskService)({})),
490
Layer.provide(
docs/orchestration-v2/orchestrator-mcp-server.md
+3
-1
@@ -364,7 +364,9 @@ Pass the task in `message`. Project, model, and modes inherit when omitted;
364
workspace does not. `scratch: true` launches without a project, in a folder of
365
its own under the environment's Scratch project. For stacked PRs, use the parent branch as `baseRef` with
366
`startFromOrigin: false`. The new thread may not run with broader runtime or
367
-interaction modes than the caller. Launch has no retry key, so inspect existing threads after a failed or lost response before
367
+interaction modes than the caller. As for `delegate_task`, a runtime mode the
368
+provider does not offer is refused, and an inherited or default one steps down
369
+to the broadest mode it offers. Launch has no retry key, so inspect existing threads after a failed or lost response before
370
launching again. `create_threads` remains the batch option for a shared checkout.
371
372
### `t3_thread_list`