@devries-cameron20 / t3code Mirror · read-only / commits / 6618ccbebc
Fork 0

The best way to control Claude Code, Codex and more from any computer or phone

Mirrored from https://github.com/Camo67/t3code.git

Synced Nov 22, 15:45 UTC

chore(lint): enforce runEffectInsideEffect (#25096)

Julius Marminge committed Oct 25, 2026 at 23:01 UTC 6618ccbebc53ebb8bda5404a51e571f84acd82df
3 files changed +22 -19
apps/server/src/preview/ServerBrowser.ts
+17 -16
@@ -457,6 +457,7 @@ const make = Effect.gen(function* () {
457 const desktopChannel = yield* DesktopBrowserChannel.DesktopBrowserChannel;
458 const agentTurns = yield* (yield* PreviewAgentActivity.PreviewAgentActivity).changes;
459 const runFork = Effect.runForkWith(yield* Effect.context<never>());
460 + const runPromise = Effect.runPromiseWith(yield* Effect.context<never>());
461 const launchServices = yield* Effect.context<ChildProcessSpawner.ChildProcessSpawner>();
462 const setupCommand = yield* resolveRootCliCommand(PreviewBrowserHost.SETUP_SUBCOMMAND);
463
@@ -471,7 +472,7 @@ const make = Effect.gen(function* () {
472
473 const contexts = new ServerBrowserContexts({
474 profilesDir: NodePath.join(config.stateDir, "server-browser", "profiles"),
474 - executable: () => Effect.runPromise(previewBrowser.executable),
475 + executable: () => runPromise(previewBrowser.executable),
476 // Playwright's launch error drops Chrome's own output; its sandbox note survives.
477 diagnose: (executable, cause) =>
478 Effect.runPromiseWith(launchServices)(
@@ -677,7 +678,7 @@ const make = Effect.gen(function* () {
678
679 const desktopRenders = (snapshot: PreviewSessionSnapshot) =>
680 desktopChannel.available
680 - ? Effect.runPromise(
681 + ? runPromise(
682 desktopChannel.awaitAttached(
683 { threadId: snapshot.threadId, tabId: snapshot.tabId },
684 DESKTOP_ATTACH_TIMEOUT,
@@ -686,9 +687,9 @@ const make = Effect.gen(function* () {
687 : Promise.resolve(false);
688
689 const connectDesktop = async (snapshot: PreviewSessionSnapshot) => {
689 - const scope = await Effect.runPromise(Scope.make());
690 + const scope = await runPromise(Scope.make());
691 try {
691 - const endpoint = await Effect.runPromise(
692 + const endpoint = await runPromise(
693 desktopChannel
694 .endpoint({ threadId: snapshot.threadId, tabId: snapshot.tabId })
695 .pipe(Scope.provide(scope)),
@@ -698,11 +699,11 @@ const make = Effect.gen(function* () {
699 page: connected.page,
700 close: async () => {
701 await connected.browser.close().catch(constVoid);
701 - await Effect.runPromise(Scope.close(scope, Exit.void));
702 + await runPromise(Scope.close(scope, Exit.void));
703 },
704 };
705 } catch (cause) {
705 - await Effect.runPromise(Scope.close(scope, Exit.void));
706 + await runPromise(Scope.close(scope, Exit.void));
707 throw cause;
708 }
709 };
@@ -1184,7 +1185,7 @@ const make = Effect.gen(function* () {
1185 const controller = [...opener.viewers].find(
1186 (viewer) => viewer.id === opener.control.controller,
1187 );
1187 - await Effect.runPromise(
1188 + await runPromise(
1189 manager.open({
1190 threadId: opener.threadId,
1191 ...(/^https?:/i.test(url) ? { url } : {}),
@@ -1677,7 +1678,7 @@ const make = Effect.gen(function* () {
1678 const tab =
1679 request.tabId === undefined
1680 ? latestThreadTab(request.threadId, request.agentSessionId)
1680 - : await Effect.runPromise(
1681 + : await runPromise(
1682 findTab(request.threadId, request.tabId).pipe(Effect.orElseSucceed(constVoid)),
1683 );
1684 if (!tab) {
@@ -1741,7 +1742,7 @@ const make = Effect.gen(function* () {
1742
1743 const found =
1744 reuse && request.tabId !== undefined
1744 - ? await Effect.runPromise(
1745 + ? await runPromise(
1746 findTab(request.threadId, request.tabId).pipe(
1747 Effect.catchTags({
1748 ServerBrowserTabNotFoundError: () => Effect.void,
@@ -1750,7 +1751,7 @@ const make = Effect.gen(function* () {
1751 )
1752 : undefined;
1753 if (reuse && request.tabIdExplicit && !found) {
1753 - const { sessions } = await Effect.runPromise(
1754 + const { sessions } = await runPromise(
1755 manager.list({ threadId: ThreadId.make(request.threadId) }),
1756 );
1757 const desktop = sessions.some(
@@ -1777,7 +1778,7 @@ const make = Effect.gen(function* () {
1778 const tab =
1779 existing ??
1780 (await ensureTab(
1780 - await Effect.runPromise(
1781 + await runPromise(
1782 manager.open({
1783 threadId: request.threadId,
1784 ...(url ? { url } : {}),
@@ -1808,7 +1809,7 @@ const make = Effect.gen(function* () {
1809 }
1810 const reveal = open.open ?? open.show;
1811 if (reveal !== false) {
1811 - await Effect.runPromise(
1812 + await runPromise(
1813 manager.requestReveal({
1814 threadId: tab.threadId,
1815 tabId: tab.tabId,
@@ -1872,7 +1873,7 @@ const make = Effect.gen(function* () {
1873 if (tab.control.controller !== null)
1874 throw new BrowserControlInterrupted("A human controls this tab.", "humanControl");
1875 void tab.control.close().catch(constVoid);
1875 - await Effect.runPromise(manager.close({ threadId: tab.threadId, tabId: tab.tabId }));
1876 + await runPromise(manager.close({ threadId: tab.threadId, tabId: tab.tabId }));
1877 dropTab(tab, false);
1878 return {};
1879 }
@@ -1939,7 +1940,7 @@ const make = Effect.gen(function* () {
1940 }
1941 case "resize": {
1942 const setting = resolvePreviewViewport(input as PreviewAutomationResizeInput);
1942 - await Effect.runPromise(
1943 + await runPromise(
1944 manager.resize({ threadId: tab.threadId, tabId: tab.tabId, viewport: setting }),
1945 );
1946 await applySetting(tab, setting);
@@ -1951,7 +1952,7 @@ const make = Effect.gen(function* () {
1952 }
1953 case "setColorScheme": {
1954 const { colorScheme } = input as PreviewAutomationSetColorSchemeInput;
1954 - const snapshot = await Effect.runPromise(
1955 + const snapshot = await runPromise(
1956 manager.adjust({ threadId: tab.threadId, tabId: tab.tabId, colorScheme }),
1957 );
1958 await applyRendering(tab, snapshot);
@@ -2197,7 +2198,7 @@ const make = Effect.gen(function* () {
2198 }
2199 case "viewport": {
2200 const setting = decodeViewportSetting(message.setting);
2200 - await Effect.runPromise(
2201 + await runPromise(
2202 manager.resize({ threadId: tab.threadId, tabId: tab.tabId, viewport: setting }),
2203 );
2204 await applySetting(tab, setting);
packages/provider-cursor/src/server/credentialStore.ts
+4 -3
@@ -50,9 +50,10 @@ export const makeCursorCredentialStore = Effect.fn("makeCursorCredentialStore")(
50 ),
51 );
52 }
53 + const runPromise = Effect.runPromiseWith(yield* Effect.context<never>());
54 const store: SdkCredentialStore = {
55 load: () =>
55 - Effect.runPromise(
56 + runPromise(
57 credentials.get.pipe(
58 Effect.flatMap(
59 Option.match({
@@ -67,7 +68,7 @@ export const makeCursorCredentialStore = Effect.fn("makeCursorCredentialStore")(
68 ),
69 ),
70 save: (value) =>
70 - Effect.runPromise(
71 + runPromise(
72 encodeCredentials(value).pipe(
73 Effect.mapError(
74 () =>
@@ -80,7 +81,7 @@ export const makeCursorCredentialStore = Effect.fn("makeCursorCredentialStore")(
81 Effect.flatMap((encoded) => credentials.set(new TextEncoder().encode(encoded))),
82 ),
83 ),
83 - clear: () => Effect.runPromise(credentials.remove),
84 + clear: () => runPromise(credentials.remove),
85 };
86 return { store, binding: credentials.binding };
87 });
tsconfig.base.json
+1
@@ -24,6 +24,7 @@
24 "namespaceImportPackages": ["@effect/platform-node", "effect"],
25 "effectFn": ["span", "inferred-span", "suggested-span"],
26 "diagnosticSeverity": {
27 + "runEffectInsideEffect": "error",
28 "flatMapConditionalToFilterOrFail": "error",
29 "catchConditionalRefailToCatchIf": "error",
30 "tryCatchInEffectGen": "error",