@devries-cameron20 / t3code Mirror · read-only / commits / 6d05c5f496
Fork 0

The best way to control Claude Code, Codex and more from any computer or phone

Mirrored from https://github.com/Camo67/t3code.git

Synced Nov 21, 06:00 UTC

fix(server): HTML reports in dot-prefixed folders no longer open as Not Found (#38210)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: GPT 6.1 Sol <codex@openai.com>

Wout Stiens committed Nov 19, 2026 at 21:03 UTC 6d05c5f4964633d296e53d88706b5ab4213971d0
3 files changed +118 -4
apps/server/src/assets/AssetAccess.test.ts
+75
@@ -1056,6 +1056,52 @@ describe("AssetAccess", () => {
1056 }).pipe(Effect.provide(layerTest)),
1057 );
1058
1059 + it.effect.skipIf(!symlinksSupported)(
1060 + "validates canonical sibling assets for previews in dot-prefixed folders",
1061 + () =>
1062 + Effect.gen(function* () {
1063 + const fs = yield* FileSystem.FileSystem;
1064 + const path = yield* Path.Path;
1065 + const root = yield* fs.makeTempDirectoryScoped();
1066 + const reportsDirectory = path.join(root, ".reports");
1067 + yield* fs.makeDirectory(path.join(reportsDirectory, ".cache"), { recursive: true });
1068 + yield* fs.makeDirectory(path.join(root, ".secret"));
1069 + const page = path.join(reportsDirectory, "report.html");
1070 + yield* fs.writeFileString(page, "<!doctype html>");
1071 + const dependencies = [
1072 + { name: "linked.css", target: path.join(root, ".secret", "key.css"), allowed: false },
1073 + {
1074 + name: "inner.css",
1075 + target: path.join(reportsDirectory, ".cache", "hidden.css"),
1076 + allowed: false,
1077 + },
1078 + { name: "shared.css", target: path.join(root, "shared.css"), allowed: true },
1079 + ];
1080 + for (const { name, target } of dependencies) {
1081 + yield* fs.writeFileString(target, "fixture");
1082 + yield* fs.symlink(target, path.join(reportsDirectory, name));
1083 + }
1084 + const result = yield* issueAssetUrl({
1085 + resource: { _tag: "workspace-file", threadId: ThreadId.make("thread-1"), path: page },
1086 + workspaceRoot: root,
1087 + });
1088 + const suffix = result.relativeUrl.slice(ASSET_ROUTE_PREFIX.length + 1);
1089 + const token = suffix.slice(0, suffix.indexOf("/"));
1090 + for (const { name, target, allowed } of dependencies) {
1091 + const resolved = yield* resolveAsset(token, name);
1092 + if (allowed) {
1093 + expect(resolved).toEqual({
1094 + kind: "file",
1095 + path: yield* fs.realPath(target),
1096 + renderIntent: "file-preview",
1097 + });
1098 + } else {
1099 + expect(resolved).toBeNull();
1100 + }
1101 + }
1102 + }).pipe(Effect.provide(layerTest)),
1103 + );
1104 +
1105 it.effect("issues workspace URLs that resolve the entry file and sibling assets", () =>
1106 Effect.gen(function* () {
1107 const fileSystem = yield* FileSystem.FileSystem;
@@ -1123,6 +1169,35 @@ describe("AssetAccess", () => {
1169 expect(yield* resolveAsset(token, "../secret.txt")).toBeNull();
1170 expect(yield* resolveAsset(token, ".env")).toBeNull();
1171 expect(yield* resolveAsset(`${token}tampered`, "report.html")).toBeNull();
1172 +
1173 + const reportsDirectory = path.join(root, ".reports");
1174 + yield* fileSystem.makeDirectory(path.join(reportsDirectory, ".cache"), { recursive: true });
1175 + const dotHtmlPath = path.join(reportsDirectory, "report.html");
1176 + const dotCssPath = path.join(reportsDirectory, "report.css");
1177 + yield* fileSystem.writeFileString(dotHtmlPath, "<h1>Quarterly report</h1>");
1178 + yield* fileSystem.writeFileString(dotCssPath, "body { color: red; }");
1179 + yield* fileSystem.writeFileString(path.join(reportsDirectory, ".cache", "hidden.css"), "");
1180 + const dotUrl = yield* issueAssetUrl({
1181 + resource: {
1182 + _tag: "workspace-file",
1183 + threadId: ThreadId.make("thread-1"),
1184 + path: dotHtmlPath,
1185 + },
1186 + workspaceRoot: root,
1187 + });
1188 + const dotSuffix = dotUrl.relativeUrl.slice(`${ASSET_ROUTE_PREFIX}/`.length);
1189 + const dotToken = dotSuffix.slice(0, dotSuffix.indexOf("/"));
1190 + expect(yield* resolveAsset(dotToken, "report.html")).toEqual({
1191 + kind: "file",
1192 + path: yield* fileSystem.realPath(dotHtmlPath),
1193 + renderIntent: "file-preview",
1194 + });
1195 + expect(yield* resolveAsset(dotToken, "report.css")).toEqual({
1196 + kind: "file",
1197 + path: yield* fileSystem.realPath(dotCssPath),
1198 + renderIntent: "file-preview",
1199 + });
1200 + expect(yield* resolveAsset(dotToken, ".cache/hidden.css")).toBeNull();
1201 for (const extension of [
1202 "odt",
1203 "ods",
apps/server/src/assets/AssetAccess.ts
+16 -4
@@ -314,7 +314,8 @@ const resolveCanonicalWorkspaceFile = Effect.fn("AssetAccess.resolveCanonicalWor
314 function* (input: {
315 readonly workspaceRoot: string;
316 readonly relativePath: string;
317 - readonly previewDependency?: true;
317 + /** The HTML entry's folder, relative to the root, when serving one of its dependencies. */
318 + readonly previewBaseRelativePath?: string;
319 }) {
320 const fileSystem = yield* FileSystem.FileSystem;
321 const workspacePaths = yield* WorkspacePaths.WorkspacePaths;
@@ -336,7 +337,18 @@ const resolveCanonicalWorkspaceFile = Effect.fn("AssetAccess.resolveCanonicalWor
337 const relative = path.relative(canonicalRoot.value, canonicalFile.value);
338 if (relative === "" || relative.startsWith("..") || path.isAbsolute(relative)) return null;
339
339 - if (input.previewDependency && !isPreviewDependencyPath(relative, path)) return null;
340 + if (input.previewBaseRelativePath !== undefined) {
341 + // The opened entry's own folder may be hidden; nothing below it, or reached outside it, may.
342 + const canonicalBase = yield* ProjectFaviconResolver.optionOnNotFound(
343 + fileSystem.realPath(path.join(canonicalRoot.value, input.previewBaseRelativePath)),
344 + );
345 + const belowBase = Option.isSome(canonicalBase)
346 + ? path.relative(canonicalBase.value, canonicalFile.value)
347 + : "..";
348 + const dependency =
349 + belowBase.startsWith("..") || path.isAbsolute(belowBase) ? relative : belowBase;
350 + if (!isPreviewDependencyPath(dependency, path)) return null;
351 + }
352
353 const info = yield* ProjectFaviconResolver.optionOnNotFound(
354 fileSystem.stat(canonicalFile.value),
@@ -350,7 +362,7 @@ const resolveCanonicalWorkspaceFile = Effect.fn("AssetAccess.resolveCanonicalWor
362 const resolveCanonicalWorkspaceFileForRequest = (input: {
363 readonly workspaceRoot: string;
364 readonly relativePath: string;
353 - readonly previewDependency?: true;
365 + readonly previewBaseRelativePath?: string;
366 }) =>
367 resolveCanonicalWorkspaceFile(input).pipe(
368 Effect.tapError((cause) =>
@@ -1089,7 +1101,7 @@ export const resolveAsset = Effect.fn("AssetAccess.resolveAsset")(function* (
1101 const workspaceFile = yield* resolveCanonicalWorkspaceFileForRequest({
1102 workspaceRoot: claims.workspaceRoot,
1103 relativePath: joinedRelativePath,
1092 - previewDependency: true,
1104 + previewBaseRelativePath: claims.baseRelativePath,
1105 });
1106 return workspaceFile
1107 ? ({ kind: "file", path: workspaceFile, renderIntent: "file-preview" } satisfies ResolvedAsset)
scripts/scenarios/html-report-in-dot-folder.e2e.ts new
+27
@@ -0,0 +1,27 @@
1 +import { expect } from "e2e";
2 +
3 +import { test, WEB } from "./t3.ts";
4 +
5 +test(
6 + "An explicitly opened HTML report in a dot-prefixed folder renders its contents",
7 + WEB,
8 + async ({ t3, app, screen, browser }) => {
9 + const project = await t3.project("demo", {
10 + ".reports/report.html": "<!doctype html><html><body><h1>Quarterly report</h1></body></html>",
11 + });
12 + const thread = await t3.thread({ project, title: "Review report", messages: ["Start"] });
13 + await t3.open(thread);
14 + await expect(screen.getByText("fixture turn complete", { exact: false })).toBeVisible();
15 +
16 + await browser.keyboard.press("Control+p");
17 + await screen.getByPlaceholder("Search files…").fill("report.html");
18 + await screen.getByRole("option", "report.html", { exact: false }).tap();
19 +
20 + const document = browser.frameLocator('iframe[title=".reports/report.html"]');
21 + try {
22 + await expect(document.locator("body")).toContainText("Quarterly report");
23 + } finally {
24 + await app.screenshot("report-preview");
25 + }
26 + },
27 +);