The best way to control Claude Code, Codex and more from any computer or phone
Mirrored from https://github.com/Camo67/t3code.git
Synced Nov 22, 14:30 UTC
refactor(web): file tree drag mentions use React drag handlers (#25913)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Julius Marminge committed
Oct 27, 2026 at 05:35 UTC
6dc4842523217b7b724c23a1c64016791fe76b56
2 files changed
+82
-19
apps/web/src/components/files/FileBrowserPanel.browser.test.tsx
new
+79
@@ -0,0 +1,79 @@
1
+import { EnvironmentId, type ProjectEntry } from "@t3tools/contracts";
2
+import { describe, expect, it, vi } from "vite-plus/test";
3
+
4
+import { COMPOSER_MENTION_DRAG_TYPE } from "~/components/chat/composerMentionDrag";
5
+import { render } from "../../../test/render";
6
+import FileBrowserPanel from "./FileBrowserPanel";
7
+
8
+const entries: readonly ProjectEntry[] = [
9
+ { path: "src", kind: "directory" },
10
+ { path: "README.md", kind: "file" },
11
+];
12
+const loadingDirectories: ReadonlySet<string> = new Set();
13
+const directory = {
14
+ entries,
15
+ load: () => Promise.resolve(),
16
+ refresh: () => {},
17
+ ready: true,
18
+ error: null,
19
+ isPending: false,
20
+ loadingDirectories,
21
+};
22
+const pathSearch = {
23
+ entries: [],
24
+ isPending: false,
25
+ error: null,
26
+ truncated: false,
27
+ refresh: () => {},
28
+};
29
+
30
+vi.mock("./useDirectoryEntries", () => ({ useDirectoryEntries: () => directory }));
31
+vi.mock("~/state/queries", () => ({ useProjectPathSearch: () => pathSearch }));
32
+vi.mock("~/fileContextMenu", () => ({
33
+ useFileContextMenu: () => ({ buildItems: () => [], activate: () => Promise.resolve() }),
34
+}));
35
+vi.mock("~/hooks/useWorkspaceMutationRefresh", () => ({ useWorkspaceMutationRefresh: () => {} }));
36
+
37
+function findTreeRow(path: string): HTMLElement | null {
38
+ for (const host of document.querySelectorAll("*")) {
39
+ const row = host.shadowRoot?.querySelector<HTMLElement>(`[data-item-path="${path}"]`);
40
+ if (row) return row;
41
+ }
42
+ return null;
43
+}
44
+
45
+describe("FileBrowserPanel", () => {
46
+ it("dragging a file row carries a composer mention without opening it, and dragend releases it", async () => {
47
+ const onOpenFile = vi.fn();
48
+ await using _screen = await render(
49
+ <FileBrowserPanel
50
+ environmentId={EnvironmentId.make("env-files")}
51
+ cwd="/repo"
52
+ projectName="repo"
53
+ selectedPath={null}
54
+ selectedPathRevealId={0}
55
+ onOpenFile={onOpenFile}
56
+ workspaceMutationId={null}
57
+ />,
58
+ );
59
+ await vi.waitFor(() => expect(findTreeRow("README.md")).not.toBeNull());
60
+ const row = findTreeRow("README.md")!;
61
+
62
+ const dataTransfer = new DataTransfer();
63
+ row.dispatchEvent(
64
+ new DragEvent("dragstart", { bubbles: true, cancelable: true, composed: true, dataTransfer }),
65
+ );
66
+ // The tree selects the row the drag picked up; mid-drag that must not open it.
67
+ row.click();
68
+ await vi.waitFor(() => expect(row.getAttribute("aria-selected")).toBe("true"));
69
+
70
+ expect(dataTransfer.getData(COMPOSER_MENTION_DRAG_TYPE)).toContain("README.md");
71
+ expect(onOpenFile).not.toHaveBeenCalled();
72
+
73
+ row.dispatchEvent(new DragEvent("dragend", { bubbles: true, composed: true, dataTransfer }));
74
+ await vi.waitFor(() => expect(row.getAttribute("aria-selected")).not.toBe("true"));
75
+
76
+ row.click();
77
+ await vi.waitFor(() => expect(onOpenFile).toHaveBeenCalledTimes(1));
78
+ });
79
+});
apps/web/src/components/files/FileBrowserPanel.tsx
+3
-19
@@ -463,33 +463,17 @@ export default function FileBrowserPanel({
463
});
464
}, [entryKinds, model, selectedPath, selectedPathRevealId]);
465
466
- // Capture dragstart before the tree selects the row so selection sees the drag flag.
467
- const panelRef = useRef<HTMLDivElement | null>(null);
468
- useEffect(() => {
469
- const panel = panelRef.current;
470
- if (panel === null) {
471
- return;
472
- }
473
- const handleDragStart = (event: DragEvent) => dragMention.handleDragStart(event);
474
- const handleDragEnd = () =>
475
- dragMention.handleDragEnd((path) => model.getItem(path)?.deselect());
476
- panel.addEventListener("dragstart", handleDragStart, true);
477
- panel.addEventListener("dragend", handleDragEnd);
478
- return () => {
479
- panel.removeEventListener("dragstart", handleDragStart, true);
480
- panel.removeEventListener("dragend", handleDragEnd);
481
- };
482
- }, [dragMention, model]);
483
-
466
return (
467
<div
486
- ref={panelRef}
468
className="flex min-h-0 flex-1 flex-col bg-background"
469
data-file-browser-panel={`${environmentId}:${cwd}`}
470
// Capture runs before the tree's shadow-internal row handler opens the menu.
471
onContextMenuCapture={(event) => {
472
contextMenuPointerRef.current = { x: event.clientX, y: event.clientY, at: event.timeStamp };
473
}}
474
+ // Capture dragstart before the tree selects the row so selection sees the drag flag.
475
+ onDragStartCapture={(event) => dragMention.handleDragStart(event.nativeEvent)}
476
+ onDragEnd={() => dragMention.handleDragEnd((path) => model.getItem(path)?.deselect())}
477
>
478
<div
479
className="flex h-10 min-h-10 shrink-0 items-center gap-1 border-b border-border/60 bg-background px-2 in-data-[preview-panel-mode=inline]:mb-1 in-data-[preview-panel-mode=inline]:h-9 in-data-[preview-panel-mode=inline]:min-h-9 in-data-[preview-panel-mode=inline]:border-b-transparent"