The best way to control Claude Code, Codex and more from any computer or phone
Mirrored from https://github.com/Camo67/t3code.git
Synced Nov 21, 14:45 UTC
test(web): wait for Settings focus before testing the theme editor's Escape (#36754)
Julius Marminge committed
Nov 14, 2026 at 05:24 UTC
76748e942bc39d183d4fee29ca9f1d1b822fefa5
1 file changed
+23
-17
apps/web/src/components/settings/ThemeEditorPanel.browser.test.tsx
+23
-17
@@ -79,27 +79,33 @@ async function renderPanel() {
79
async function renderBesideSettings() {
80
const onSettingsOpenChange = vi.fn();
81
const onEditorOpenChange = vi.fn();
82
- const screen = await render(
83
- <>
84
- <Dialog onOpenChange={onSettingsOpenChange} open>
85
- <DialogPopup>
86
- <DialogTitle>Settings</DialogTitle>
87
- </DialogPopup>
88
- </Dialog>
89
- <ThemeEditorPanel
90
- open
91
- onOpenChange={onEditorOpenChange}
92
- onSaved={() => true}
93
- editingTheme={null}
94
- initialAppearance="light"
95
- restoreTheme={() => {}}
96
- />
97
- </>,
82
+ await using stack = new AsyncDisposableStack();
83
+ stack.use(
84
+ await render(
85
+ <>
86
+ <Dialog onOpenChange={onSettingsOpenChange} open>
87
+ <DialogPopup>
88
+ <DialogTitle>Settings</DialogTitle>
89
+ </DialogPopup>
90
+ </Dialog>
91
+ <ThemeEditorPanel
92
+ open
93
+ onOpenChange={onEditorOpenChange}
94
+ onSaved={() => true}
95
+ editingTheme={null}
96
+ initialAppearance="light"
97
+ restoreTheme={() => {}}
98
+ />
99
+ </>,
100
+ ),
101
);
102
+ // Settings moves focus in on a later frame; landing after the test focuses the editor, it steals it.
103
+ await expect.element(page.getByRole("button", { name: "Close" })).toHaveFocus();
104
+ const screen = stack.move();
105
return {
106
onSettingsOpenChange,
107
onEditorOpenChange,
102
- [Symbol.asyncDispose]: () => screen[Symbol.asyncDispose](),
108
+ [Symbol.asyncDispose]: () => screen.disposeAsync(),
109
};
110
}
111