The best way to control Claude Code, Codex and more from any computer or phone
Mirrored from https://github.com/Camo67/t3code.git
Synced Nov 21, 07:15 UTC
fix(server): RTF tracked deletions are left out of the extracted text (#38605)
Co-authored-by: asssslay <avramova.ruslana.a.r.r@gmail.com> Co-authored-by: Julius Marminge <julius0216@outlook.com>
Ibrahim Elkamali committed
Nov 18, 2026 at 16:16 UTC
7e4c4294823f6507c41722cf919b597a8f9352b3
2 files changed
+38
-16
apps/server/src/provider/documentTextWorker.ts
+18
-16
@@ -414,8 +414,9 @@ function* notebook(source: string): Generator<string, void> {
414
415
function* rtf(source: string): Generator<string, void> {
416
if (!source.startsWith("{\\rtf")) throw new Error("Invalid RTF document");
417
- let state = { skip: false, uc: 1, decoder: new TextDecoder("windows-1252") };
417
+ let state = { skip: false, deleted: false, uc: 1, decoder: new TextDecoder("windows-1252") };
418
const stack: Array<typeof state> = [];
419
+ const hidden = () => state.skip || state.deleted;
420
const symbols = new Map([
421
["endash", "–"],
422
["emdash", characterEntities.mdash],
@@ -449,8 +450,7 @@ function* rtf(source: string): Generator<string, void> {
450
const word = /^([a-z]+)(-?\d+)? ?/i.exec(rest);
451
if (hex) {
452
if (fallback) fallback--;
452
- else if (!state.skip)
453
- yield state.decoder.decode(Uint8Array.of(Number.parseInt(hex[1]!, 16)));
453
+ else if (!hidden()) yield state.decoder.decode(Uint8Array.of(Number.parseInt(hex[1]!, 16)));
454
i += 3;
455
} else if (word) {
456
i += word[0].length;
@@ -485,6 +485,8 @@ function* rtf(source: string): Generator<string, void> {
485
].includes(control)
486
)
487
state.skip = true;
488
+ if (control === "deleted") state.deleted = value !== 0;
489
+ else if (control === "plain") state.deleted = false;
490
if (control === "ansicpg") {
491
// Per-byte decoding only supports single-byte Windows code pages.
492
if (value !== 874 && (value < 1250 || value > 1258))
@@ -494,28 +496,28 @@ function* rtf(source: string): Generator<string, void> {
496
if (!Number.isSafeInteger(value) || value < 0)
497
throw new Error("Invalid RTF fallback count");
498
state.uc = value;
497
- } else if (control === "u" && !state.skip) {
498
- yield String.fromCharCode(value < 0 ? value + 65536 : value);
499
+ } else if (control === "u") {
500
+ if (!hidden()) yield String.fromCharCode(value < 0 ? value + 65536 : value);
501
fallback = state.uc;
500
- } else if (
501
- !state.skip &&
502
- ["par", "line", "row", "sect", "page", "column"].includes(control)
503
- )
502
+ } else if (!hidden() && ["par", "line", "sect", "page", "column"].includes(control))
503
yield "\n";
505
- else if (!state.skip && ["tab", "cell"].includes(control)) yield "\t";
506
- else if (!state.skip && symbols.has(control)) yield symbols.get(control)!;
504
+ else if (!hidden() && control === "tab") yield "\t";
505
+ // Table structure survives tracked deletions; only the deleted cell text is dropped.
506
+ else if (!state.skip && control === "row") yield "\n";
507
+ else if (!state.skip && control === "cell") yield "\t";
508
+ else if (!hidden() && symbols.has(control)) yield symbols.get(control)!;
509
} else {
510
i++;
511
if (fallback) fallback--;
512
else if (rest[0] === "*") state.skip = true;
513
// A backslash before a line break is \par; TextEdit ends paragraphs this way.
512
- else if (!state.skip && (rest[0] === "\n" || rest[0] === "\r")) yield "\n";
513
- else if (!state.skip && ["\\", "{", "}"].includes(rest[0]!)) yield rest[0]!;
514
- else if (!state.skip && symbols.has(rest[0]!)) yield symbols.get(rest[0]!)!;
514
+ else if (!hidden() && (rest[0] === "\n" || rest[0] === "\r")) yield "\n";
515
+ else if (!hidden() && ["\\", "{", "}"].includes(rest[0]!)) yield rest[0]!;
516
+ else if (!hidden() && symbols.has(rest[0]!)) yield symbols.get(rest[0]!)!;
517
}
516
- } else if (!state.skip && char !== "\n" && char !== "\r") {
518
+ } else if (char !== "\n" && char !== "\r") {
519
if (fallback) fallback--;
518
- else
520
+ else if (!hidden())
521
yield char.charCodeAt(0) < 128
522
? char
523
: state.decoder.decode(Uint8Array.of(char.charCodeAt(0)));
apps/server/src/provider/userInputAttachments.test.ts
+20
@@ -309,6 +309,26 @@ describe("question answer paths", () => {
309
["hyphen symbol fallback", String.raw`{\rtf1\ansi\uc3\u945\~\_\-Z}`, "αZ"],
310
["control word", String.raw`{\rtf1\ansi A\u9\tab X}`, "A\tX"],
311
["line break paragraphs", "{\\rtf1\\ansi First\\\nSecond\\\r\nThird}", "First\nSecond\nThird"],
312
+ [
313
+ "tracked deletion",
314
+ String.raw`{\rtf1\ansi The fee is {\deleted\revauthdel1\revdttmdel1 $500}{\revised\revauth1 $700}.}`,
315
+ "The fee is $700.",
316
+ ],
317
+ [
318
+ "tracked deletion end",
319
+ String.raw`{\rtf1\ansi{\header Header\plain Plain}A\deleted B\deleted0 C\deleted D\plain E}`,
320
+ "ACE",
321
+ ],
322
+ [
323
+ "tracked deletion fallback",
324
+ String.raw`{\rtf1\ansi A{\deleted\uc1\u945\deleted0 B}\deleted\u946?\deleted0 C}`,
325
+ "AC",
326
+ ],
327
+ [
328
+ "tracked deletion table",
329
+ String.raw`{\rtf1\ansi\trowd\cellx1000\cellx2000\intbl A\deleted\cell\deleted0 B\cell\deleted\row\deleted0 C\cell}`,
330
+ "A\tB\t\nC",
331
+ ],
332
[
333
"document breaks",
334
String.raw`{\rtf1\ansi\sectd\cols2\pard North quota: 120\column South quota: 240\page East quota: 360\sect\sectd\pard West quota: 480\par}`,